Hi Laurent,
Thanks for your explanation.
I'm fine with current situation.
I have also checked other drivers and they did the same.
As you said, let's improve this driver when the time comes.
Thanks.
Best regards,
KHIEM Nguyen
On 6/4/2014 2:39 AM, Laurent Pinchart wrote:
> Hi,
>
> On Tuesday
Hi,
On Tuesday 03 June 2014 13:57:38 Khiem Nguyen wrote:
> Hi Laurent,
>
> Thanks for the patch.
>
> > + if (!iommu_present(&platform_bus_type))
> > + bus_set_iommu(&platform_bus_type, &ipmmu_ops);
>
> With this code, if error occurs, it's hidden.
>
> I think it should be like belo
Hi Laurent,
Thanks for the patch.
+ if (!iommu_present(&platform_bus_type))
+ bus_set_iommu(&platform_bus_type, &ipmmu_ops);
With this code, if error occurs, it's hidden.
I think it should be like below,
+ ret = bus_set_iommu(&platform_bus_type, &ipmmu_ops);
+
Hi Joerg,
On Wednesday 14 May 2014 00:00:23 Joerg Roedel wrote:
> On Tue, May 13, 2014 at 11:04:10PM +0200, Laurent Pinchart wrote:
> > > Isn't this the same as ipmmu_tlb_invalidate()?
> >
> > ipmmu_tlb_invalidate() performs a read-update-write operation on the IMCTR
> > register to set the FLUSH
On Tue, May 13, 2014 at 11:04:10PM +0200, Laurent Pinchart wrote:
> > Isn't this the same as ipmmu_tlb_invalidate()?
>
> ipmmu_tlb_invalidate() performs a read-update-write operation on the IMCTR
> register to set the FLUSH bit without modifying the other bits, while this
> function writes the F
Hi Joerg,
On Tuesday 13 May 2014 19:55:29 Joerg Roedel wrote:
> Hi Laurent,
>
> Sorry for taking so long with this.
No worries. As long as the driver gets in v3.16 (wink wink :-)) that's fine
> The code looks good and clean overall, besides my second comment.
>
> On Wed, Apr 02, 2014 at 12:47:
Hi Laurent,
Sorry for taking so long with this. The code looks good and clean
overall, besides my second comment.
On Wed, Apr 02, 2014 at 12:47:37PM +0200, Laurent Pinchart wrote:
> +static void ipmmu_domain_destroy_context(struct ipmmu_vmsa_domain *domain)
> +{
> + /*
> + * Disable the
Hi Joerg,
On Thursday 17 April 2014 12:14:00 Laurent Pinchart wrote:
> On Wednesday 09 April 2014 12:57:03 Joerg Roedel wrote:
> > On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote:
> > > On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote:
> > > > Signed-off-by: Laurent Pinc
Hi Joerg,
On Wednesday 09 April 2014 12:57:03 Joerg Roedel wrote:
> On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote:
> > On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote:
> > > Signed-off-by: Laurent Pinchart
> > >
> > > ---
> > >
> > > drivers/iommu/Kconfig
Hi Joerg,
On Wednesday 09 April 2014 12:57:03 Joerg Roedel wrote:
> Hi Laurent,
>
> On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote:
> > On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote:
> > > Signed-off-by: Laurent Pinchart
> > >
> > > ---
> > >
> > > drivers/iommu/
Hi Laurent,
On Wed, Apr 09, 2014 at 12:43:57PM +0200, Laurent Pinchart wrote:
> On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart
> > ---
> > drivers/iommu/Kconfig| 12 +
> > drivers/iommu/Makefile |1 +
> >
Hi Joerg,
On Wednesday 02 April 2014 12:47:37 Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart
> ---
> drivers/iommu/Kconfig| 12 +
> drivers/iommu/Makefile |1 +
> drivers/iommu/ipmmu-vmsa.c | 1070 +++
>
Signed-off-by: Laurent Pinchart
---
drivers/iommu/Kconfig| 12 +
drivers/iommu/Makefile |1 +
drivers/iommu/ipmmu-vmsa.c | 1070 ++
include/linux/platform_data/ipmmu-vmsa.h | 24 +
4 files changed, 1107 insert
13 matches
Mail list logo
