Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-29 Thread Masahiro Yamada
On Wed, Aug 28, 2019 at 9:23 PM Masahiro Yamada wrote: > > On Wed, Aug 28, 2019 at 7:53 PM Masahiro Yamada > wrote: > > > > Hi Christoph, > > > > On Tue, Aug 27, 2019 at 8:55 PM Christoph Hellwig wrote: > > > > > > On Tue, Aug 27, 2019 at 06:03:14PM +0900, Masahiro Yamada wrote: > > > > Yes, thi

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-28 Thread Masahiro Yamada
On Wed, Aug 28, 2019 at 7:53 PM Masahiro Yamada wrote: > > Hi Christoph, > > On Tue, Aug 27, 2019 at 8:55 PM Christoph Hellwig wrote: > > > > On Tue, Aug 27, 2019 at 06:03:14PM +0900, Masahiro Yamada wrote: > > > Yes, this makes my driver working again > > > when CONFIG_DMA_CMA=y. > > > > > > > >

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-28 Thread Masahiro Yamada
Hi Christoph, On Tue, Aug 27, 2019 at 8:55 PM Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 06:03:14PM +0900, Masahiro Yamada wrote: > > Yes, this makes my driver working again > > when CONFIG_DMA_CMA=y. > > > > > > If I apply the following, my driver gets back working > > irrespective of

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 06:03:14PM +0900, Masahiro Yamada wrote: > Yes, this makes my driver working again > when CONFIG_DMA_CMA=y. > > > If I apply the following, my driver gets back working > irrespective of CONFIG_DMA_CMA. That sounds a lot like the device simply isn't 64-bit DMA capable, and

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Masahiro Yamada
On Tue, Aug 27, 2019 at 4:50 PM Christoph Hellwig wrote: > > On Tue, Aug 27, 2019 at 04:45:20PM +0900, Masahiro Yamada wrote: > > On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > > > > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > > > This is included in v5.3-

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Christoph Hellwig
On Tue, Aug 27, 2019 at 04:45:20PM +0900, Masahiro Yamada wrote: > On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > > This is included in v5.3-rc6 > > > so I tested it. > > > > So there is no allocation failure, b

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-27 Thread Masahiro Yamada
On Mon, Aug 26, 2019 at 4:33 PM Christoph Hellwig wrote: > > On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > > This is included in v5.3-rc6 > > so I tested it. > > So there is no allocation failure, but you get I/O errors later? Right. > > Does the device use a device-private

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-26 Thread Christoph Hellwig
On Mon, Aug 26, 2019 at 11:05:00AM +0900, Masahiro Yamada wrote: > This is included in v5.3-rc6 > so I tested it. So there is no allocation failure, but you get I/O errors later? Does the device use a device-private CMA area? Does it work with Linux 5.2 if CONFIG_DMA_CMA is disabled?

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-25 Thread Masahiro Yamada
Christoph, On Sun, Aug 25, 2019 at 10:10 AM Christoph Hellwig wrote: > > On Fri, Aug 23, 2019 at 09:56:52PM +0900, Masahiro Yamada wrote: > > + linux-mmc, Ulf Hansson, Adrian Hunter, > > > > > > ADMA of SDHCI is not working > > since bd2e75633c8012fc8a7431c82fda66237133bf7e > > Does it work for y

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-25 Thread Masahiro Yamada
Hi Nicolin, On Sat, Aug 24, 2019 at 7:10 AM Nicolin Chen wrote: > > On Fri, Aug 23, 2019 at 09:49:46PM +0900, Masahiro Yamada wrote: > > > > Reverting this commit fixed the problem. > > We are having another problem with the new API and Christoph > submitted a patch at: https://lkml.org/lkml/201

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-24 Thread Christoph Hellwig
On Fri, Aug 23, 2019 at 09:56:52PM +0900, Masahiro Yamada wrote: > + linux-mmc, Ulf Hansson, Adrian Hunter, > > > ADMA of SDHCI is not working > since bd2e75633c8012fc8a7431c82fda66237133bf7e Does it work for you with this commit: http://git.infradead.org/users/hch/dma-mapping.git/commitdiff/90

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-23 Thread Nicolin Chen
On Fri, Aug 23, 2019 at 09:49:46PM +0900, Masahiro Yamada wrote: > On Tue, May 7, 2019 at 7:36 AM Nicolin Chen wrote: > > > > The addresses within a single page are always contiguous, so it's > > not so necessary to always allocate one single page from CMA area. > > Since the CMA area has a limite

Re: [PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-08-23 Thread Masahiro Yamada
+ linux-mmc, Ulf Hansson, Adrian Hunter, ADMA of SDHCI is not working since bd2e75633c8012fc8a7431c82fda66237133bf7e Did anybody see the same problem? Masahiro On Fri, Aug 23, 2019 at 9:49 PM Masahiro Yamada wrote: > > On Tue, May 7, 2019 at 7:36 AM Nicolin Chen wrote: > > > > The addre

[PATCH v2 2/2] dma-contiguous: Use fallback alloc_pages for single pages

2019-05-06 Thread Nicolin Chen
The addresses within a single page are always contiguous, so it's not so necessary to always allocate one single page from CMA area. Since the CMA area has a limited predefined size of space, it may run out of space in heavy use cases, where there might be quite a lot CMA pages being allocated for