RE: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-07-04 Thread Craig Stein
June 28, 2017 4:37 AM > > To: Jan Vesely; Deucher, Alexander > > Cc: Lendacky, Thomas; Nath, Arindam; Craig Stein; iommu@lists.linux- > > foundation.org; Duran, Leo; Suthikulpanit, Suravee > > Subject: Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush > > >

RE: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-28 Thread Deucher, Alexander
; Subject: Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush > > [Adding Alex Deucher] > > Hey Alex, > > On Tue, Jun 27, 2017 at 12:24:35PM -0400, Jan Vesely wrote: > > On Mon, 2017-06-26 at 14:14 +0200, Joerg Roedel wrote: > > > > How does that &#x

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-28 Thread Joerg Roedel
[Adding Alex Deucher] Hey Alex, On Tue, Jun 27, 2017 at 12:24:35PM -0400, Jan Vesely wrote: > On Mon, 2017-06-26 at 14:14 +0200, Joerg Roedel wrote: > > How does that 'dGPU goes to sleep' work? Do you put it to sleep manually > > via sysfs or something? Or is that something that amdgpu does on i

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-27 Thread Jan Vesely
On Mon, 2017-06-26 at 14:14 +0200, Joerg Roedel wrote: > On Fri, Jun 23, 2017 at 10:20:47AM -0400, Jan Vesely wrote: > > I was able to trigger "Completion-Wait loop timed out" messages in the > > following situation: > > Hung OpenCL task running on dGPU. > > dGPU goes to sleep. > > sigterm to hung

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-26 Thread Joerg Roedel
On Fri, Jun 23, 2017 at 10:20:47AM -0400, Jan Vesely wrote: > I was able to trigger "Completion-Wait loop timed out" messages in the > following situation: > Hung OpenCL task running on dGPU. > dGPU goes to sleep. > sigterm to hung task. > it seems to recover OK after the dGPU is powered back on H

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-23 Thread Jan Vesely
On Thu, 2017-06-22 at 23:57 +0200, Joerg Roedel wrote: > On Thu, Jun 22, 2017 at 11:13:09AM -0400, Jan Vesely wrote: > > It looks like I tested different patches. > > linux-4.10.17 with both > > "iommu/amd: Optimize iova queue flushing" > > This patch isn't in my tree and will not go upstream. >

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-22 Thread Joerg Roedel
On Thu, Jun 22, 2017 at 11:13:09AM -0400, Jan Vesely wrote: > It looks like I tested different patches. > linux-4.10.17 with both > "iommu/amd: Optimize iova queue flushing" This patch isn't in my tree and will not go upstream. > and > "iommu/amd: Disable previously enabled IOMMUs at boot" This

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-22 Thread Jan Vesely
On Thu, 2017-06-22 at 11:20 +0200, Joerg Roedel wrote: > On Wed, Jun 21, 2017 at 05:09:31PM -0400, Jan Vesely wrote: > > On Wed, 2017-06-21 at 12:01 -0500, Tom Lendacky wrote: > > > On 6/21/2017 11:20 AM, Jan Vesely wrote: > > > > Hi Arindam, > > > > > > > > has this patch been replaced by Joerg's

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-22 Thread Joerg Roedel
On Wed, Jun 21, 2017 at 05:09:31PM -0400, Jan Vesely wrote: > On Wed, 2017-06-21 at 12:01 -0500, Tom Lendacky wrote: > > On 6/21/2017 11:20 AM, Jan Vesely wrote: > > > Hi Arindam, > > > > > > has this patch been replaced by Joerg's "[PATCH 0/7] iommu/amd: > > > Optimize iova queue flushing" series

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-21 Thread Jan Vesely
at 10:02 +, Nath, Arindam wrote: > > > > > -Original Message- > > > > > From: Lendacky, Thomas > > > > > Sent: Tuesday, June 06, 2017 1:23 AM > > > > > To: iommu@lists.linux-foundation.org > > > > > Cc: Nath, Arindam ; Jo

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-21 Thread Tom Lendacky
it, Suravee Subject: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush After reducing the amount of MMIO performed by the IOMMU during operation, perf data shows that flushing the TLB for all protection domains during DMA unmapping is a performance issue. It is not necessary to flush the TLB

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-21 Thread Jan Vesely
gt; > > From: Lendacky, Thomas > > > Sent: Tuesday, June 06, 2017 1:23 AM > > > To: iommu@lists.linux-foundation.org > > > Cc: Nath, Arindam ; Joerg Roedel > > > ; Duran, Leo ; Suthikulpanit, > > > Suravee > > > Subject: [PATCH v1 3/3] iommu/am

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-08 Thread Craig Stein
Tuesday, June 06, 2017 1:23 AM > > > To: iommu@lists.linux-foundation.org > > > Cc: Nath, Arindam ; Joerg Roedel > > > ; Duran, Leo ; Suthikulpanit, > > > Suravee > > > Subject: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush > > > >

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-08 Thread Jan Vesely
hikulpanit, > > Suravee > > Subject: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush > > > > After reducing the amount of MMIO performed by the IOMMU during > > operation, > > perf data shows that flushing the TLB for all protection domains during > > D

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-07 Thread Joerg Roedel
Hey Tom, On Wed, Jun 07, 2017 at 09:03:15AM -0500, Tom Lendacky wrote: > I was able to run your patches in combination with the first two patches > that I submitted and the results look good. Let me know if you'd like > me to resubmit the series minus the third patch. Thanks a lot for testing th

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-07 Thread Tom Lendacky
On 6/6/2017 8:36 AM, Tom Lendacky wrote: On 6/6/2017 7:05 AM, Joerg Roedel wrote: Hey Tom, Hi Joerg, On Mon, Jun 05, 2017 at 02:52:35PM -0500, Tom Lendacky wrote: After reducing the amount of MMIO performed by the IOMMU during operation, perf data shows that flushing the TLB for all prote

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-06 Thread Tom Lendacky
On 6/6/2017 7:05 AM, Joerg Roedel wrote: Hey Tom, Hi Joerg, On Mon, Jun 05, 2017 at 02:52:35PM -0500, Tom Lendacky wrote: After reducing the amount of MMIO performed by the IOMMU during operation, perf data shows that flushing the TLB for all protection domains during DMA unmapping is a per

Re: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-06 Thread Joerg Roedel
Hey Tom, On Mon, Jun 05, 2017 at 02:52:35PM -0500, Tom Lendacky wrote: > After reducing the amount of MMIO performed by the IOMMU during operation, > perf data shows that flushing the TLB for all protection domains during > DMA unmapping is a performance issue. It is not necessary to flush the > T

RE: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-06 Thread Nath, Arindam
>-Original Message- >From: Lendacky, Thomas >Sent: Tuesday, June 06, 2017 1:23 AM >To: iommu@lists.linux-foundation.org >Cc: Nath, Arindam ; Joerg Roedel >; Duran, Leo ; Suthikulpanit, >Suravee >Subject: [PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush >

[PATCH v1 3/3] iommu/amd: Optimize the IOMMU queue flush

2017-06-05 Thread Tom Lendacky
After reducing the amount of MMIO performed by the IOMMU during operation, perf data shows that flushing the TLB for all protection domains during DMA unmapping is a performance issue. It is not necessary to flush the TLBs for all protection domains, only the protection domains associated with iova