Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-03-04 Thread Lu Baolu
Hi Joerg, On 2020/3/3 21:13, Joerg Roedel wrote: Hi Baolu, On Tue, Mar 03, 2020 at 02:47:02PM +0800, Lu Baolu wrote: Theoretically speaking, per-device default domain is impractical. PCI aliased devices (PCI bridge and all devices beneath it, VMD devices and various devices quirked with pci_ad

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-03-03 Thread Joerg Roedel
Hi Baolu, On Tue, Mar 03, 2020 at 02:47:02PM +0800, Lu Baolu wrote: > Theoretically speaking, per-device default domain is impractical. PCI > aliased devices (PCI bridge and all devices beneath it, VMD devices and > various devices quirked with pci_add_dma_alias()) must use the same > domain. It's

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-03-02 Thread Lu Baolu
Hi Joerg, On 2020/3/2 23:08, Joerg Roedel wrote: Hello Sai, Baolu, On Sun, Feb 16, 2020 at 01:57:26PM -0800, Sai Praneeth Prakhya wrote: Hence it will be helpful if there is some way to change the default domain of a B:D.F dynamically. Since, linux iommu subsystem prefers to deal at iommu_grou

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-03-02 Thread Joerg Roedel
Hello Sai, Baolu, On Sun, Feb 16, 2020 at 01:57:26PM -0800, Sai Praneeth Prakhya wrote: > Hence it will be helpful if there is some way to change the default > domain of a B:D.F dynamically. Since, linux iommu subsystem prefers to > deal at iommu_group level instead of B:D.F level, it might be hel

RE: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-24 Thread Prakhya, Sai Praneeth
> On 2020/2/24 16:12, Lu Baolu wrote: > > On 2020/2/24 15:57, Prakhya, Sai Praneeth wrote: > >>> On 2020/2/24 15:03, Prakhya, Sai Praneeth wrote: > > On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: > +    list_for_each_entry_safe(grp_dev, temp, &group->devices, > list) { > >>

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-24 Thread Lu Baolu
On 2020/2/24 16:12, Lu Baolu wrote: On 2020/2/24 15:57, Prakhya, Sai Praneeth wrote: On 2020/2/24 15:03, Prakhya, Sai Praneeth wrote: On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: +    list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { +    struct device *dev; + +   

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-24 Thread Lu Baolu
On 2020/2/24 15:57, Prakhya, Sai Praneeth wrote: On 2020/2/24 15:03, Prakhya, Sai Praneeth wrote: On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { + struct device *dev; + + dev = grp_dev->dev; +

RE: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-23 Thread Prakhya, Sai Praneeth
> On 2020/2/24 15:03, Prakhya, Sai Praneeth wrote: > >> On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: > > + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { > > + struct device *dev; > > + > > + dev = grp_dev->dev; > > +

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-23 Thread Lu Baolu
On 2020/2/24 15:03, Prakhya, Sai Praneeth wrote: On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { + struct device *dev; + + dev = grp_dev->dev; + iommu_release_device(dev); + +

RE: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-23 Thread Prakhya, Sai Praneeth
> On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: > >>> + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { > >>> + struct device *dev; > >>> + > >>> + dev = grp_dev->dev; > >>> + iommu_release_device(dev); > >>> + > >>> + ret = iommu_group_add_device

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-23 Thread Lu Baolu
Hi Sai, On 2020/2/24 11:20, Prakhya, Sai Praneeth wrote: + list_for_each_entry_safe(grp_dev, temp, &group->devices, list) { + struct device *dev; + + dev = grp_dev->dev; + iommu_release_device(dev); + + ret = iommu_group_add_device(gr

RE: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-23 Thread Prakhya, Sai Praneeth
> On 2020/2/17 5:57, Sai Praneeth Prakhya wrote: > > Presently, the default domain of an iommu_group is allocated during > > boot time (i.e. when a device is being added to a group) and it cannot > > be changed later. So, the device would typically be either in identity > > (also known as pass_thro

Re: [PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-22 Thread Lu Baolu
Hi, On 2020/2/17 5:57, Sai Praneeth Prakhya wrote: Presently, the default domain of an iommu_group is allocated during boot time (i.e. when a device is being added to a group) and it cannot be changed later. So, the device would typically be either in identity (also known as pass_through) mode (

[PATCH V2 3/5] iommu: Add support to change default domain of an iommu_group

2020-02-16 Thread Sai Praneeth Prakhya
Presently, the default domain of an iommu_group is allocated during boot time (i.e. when a device is being added to a group) and it cannot be changed later. So, the device would typically be either in identity (also known as pass_through) mode (controlled by "iommu=pt" kernel command line argument)