RE: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-09 Thread Sricharan
o.org; >linux-arm-...@vger.kernel.org; j...@8bytes.org; >will.dea...@arm.com; iommu@lists.linux-foundation.org; robh...@kernel.org; >sb...@codeaurora.org; linux-arm- >ker...@lists.infradead.org; m.szyprow...@samsung.com >Subject: Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sle

Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Robin Murphy
On 08/02/17 13:52, Mark Rutland wrote: > On Wed, Feb 08, 2017 at 07:15:37PM +0530, Sricharan wrote: >>> Clocks are not architectural, so it only makes sense to associate them >>> with an implementation-specific compatible string. There's also no >> >> ok, it for this the QCOM specific implementatio

Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 07:15:37PM +0530, Sricharan wrote: > >Clocks are not architectural, so it only makes sense to associate them > >with an implementation-specific compatible string. There's also no > > ok, it for this the QCOM specific implementation binding is tried(going to). > > >guarante

RE: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Sricharan
Hi Robin, > On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: >> +- clock-names:Should be a pair of "smmu_iface_clk" and >> "smmu_bus_clk" >> + required for smmu's register group access and >> interface >> + clk for the smm

Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Robin Murphy
On 08/02/17 12:30, Sricharan wrote: > Hi Mark, > >> On Wed, Feb 08, 2017 at 04:23:17PM +0530, Sricharan wrote: On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: > +- clock-names:Should be a pair of "smmu_iface_clk" and "smmu_bus_clk" > + required for sm

RE: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Sricharan
Hi Mark, >On Wed, Feb 08, 2017 at 04:23:17PM +0530, Sricharan wrote: >> >On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: >> >> +- clock-names:Should be a pair of "smmu_iface_clk" and "smmu_bus_clk" >> >> + required for smmu's register group access and interface >>

Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Mark Rutland
On Wed, Feb 08, 2017 at 04:23:17PM +0530, Sricharan wrote: > >On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: > >> +- clock-names:Should be a pair of "smmu_iface_clk" and "smmu_bus_clk" > >> + required for smmu's register group access and interface > >> +

RE: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-08 Thread Sricharan
Hi Mark, > >On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: >> +- clock-names:Should be a pair of "smmu_iface_clk" and "smmu_bus_clk" >> + required for smmu's register group access and interface >> + clk for the smmu's underlying bus access. >> +

Re: [PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-02 Thread Mark Rutland
Hi, On Thu, Feb 02, 2017 at 10:40:18PM +0530, Sricharan R wrote: > +- clock-names:Should be a pair of "smmu_iface_clk" and "smmu_bus_clk" > + required for smmu's register group access and interface > + clk for the smmu's underlying bus access. > + > +- clocks:

[PATCH V2 1/3] iommu/arm-smmu: Add pm_runtime/sleep ops

2017-02-02 Thread Sricharan R
The smmu needs to be functional only when the respective master's using it are active. The device_link feature helps to track such functional dependencies, so that the iommu gets powered when the master device enables itself using pm_runtime. So by adapting the smmu driver for runtime pm, above sai