Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-10 Thread Robin Murphy
On 08/04/17 00:13, Frank Rowand wrote: > On 04/07/17 07:46, Robin Murphy wrote: >> On 06/04/17 20:34, Frank Rowand wrote: >>> On 04/06/17 04:01, Sricharan R wrote: Hi Frank, On 4/6/2017 12:31 PM, Frank Rowand wrote: > On 04/04/17 03:18, Sricharan R wrote: >> Size of the dma-r

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-07 Thread Frank Rowand
On 04/07/17 07:46, Robin Murphy wrote: > On 06/04/17 20:34, Frank Rowand wrote: >> On 04/06/17 04:01, Sricharan R wrote: >>> Hi Frank, >>> >>> On 4/6/2017 12:31 PM, Frank Rowand wrote: On 04/04/17 03:18, Sricharan R wrote: > Size of the dma-range is calculated as coherent_dma_mask + 1

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-07 Thread Frank Rowand
On 04/06/17 00:01, Frank Rowand wrote: > On 04/04/17 03:18, Sricharan R wrote: >> Size of the dma-range is calculated as coherent_dma_mask + 1 >> and passed to arch_setup_dma_ops further. It overflows when >> the coherent_dma_mask is set for full 64 bits 0x, >> resulting in size get

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-07 Thread Robin Murphy
On 06/04/17 20:34, Frank Rowand wrote: > On 04/06/17 04:01, Sricharan R wrote: >> Hi Frank, >> >> On 4/6/2017 12:31 PM, Frank Rowand wrote: >>> On 04/04/17 03:18, Sricharan R wrote: Size of the dma-range is calculated as coherent_dma_mask + 1 and passed to arch_setup_dma_ops further. It o

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Sricharan R
Hi Frank, On 4/7/2017 1:04 AM, Frank Rowand wrote: On 04/06/17 04:01, Sricharan R wrote: Hi Frank, On 4/6/2017 12:31 PM, Frank Rowand wrote: On 04/04/17 03:18, Sricharan R wrote: Size of the dma-range is calculated as coherent_dma_mask + 1 and passed to arch_setup_dma_ops further. It overflo

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/06/17 04:01, Sricharan R wrote: > Hi Frank, > > On 4/6/2017 12:31 PM, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflows when >>> the coherent_dma_mask is set

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/06/17 03:24, Robin Murphy wrote: > On 06/04/17 08:01, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflows when >>> the coherent_dma_mask is set for full 64 bits

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Robin Murphy
On 06/04/17 14:56, Rob Herring wrote: > On Thu, Apr 6, 2017 at 5:24 AM, Robin Murphy wrote: >> On 06/04/17 08:01, Frank Rowand wrote: >>> On 04/04/17 03:18, Sricharan R wrote: Size of the dma-range is calculated as coherent_dma_mask + 1 and passed to arch_setup_dma_ops further. It overfl

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Rob Herring
On Thu, Apr 6, 2017 at 5:24 AM, Robin Murphy wrote: > On 06/04/17 08:01, Frank Rowand wrote: >> On 04/04/17 03:18, Sricharan R wrote: >>> Size of the dma-range is calculated as coherent_dma_mask + 1 >>> and passed to arch_setup_dma_ops further. It overflows when >>> the coherent_dma_mask is set fo

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Sricharan R
Hi Frank, On 4/6/2017 12:31 PM, Frank Rowand wrote: On 04/04/17 03:18, Sricharan R wrote: Size of the dma-range is calculated as coherent_dma_mask + 1 and passed to arch_setup_dma_ops further. It overflows when the coherent_dma_mask is set for full 64 bits 0x, resulting in size

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Robin Murphy
On 06/04/17 08:01, Frank Rowand wrote: > On 04/04/17 03:18, Sricharan R wrote: >> Size of the dma-range is calculated as coherent_dma_mask + 1 >> and passed to arch_setup_dma_ops further. It overflows when >> the coherent_dma_mask is set for full 64 bits 0x, >> resulting in size get

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-06 Thread Frank Rowand
On 04/04/17 03:18, Sricharan R wrote: > Size of the dma-range is calculated as coherent_dma_mask + 1 > and passed to arch_setup_dma_ops further. It overflows when > the coherent_dma_mask is set for full 64 bits 0x, > resulting in size getting passed as 0 wrongly. Fix this by > passs

Re: [PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-04 Thread Robin Murphy
On 04/04/17 11:18, Sricharan R wrote: > Size of the dma-range is calculated as coherent_dma_mask + 1 > and passed to arch_setup_dma_ops further. It overflows when > the coherent_dma_mask is set for full 64 bits 0x, > resulting in size getting passed as 0 wrongly. Fix this by > passs

[PATCH V10 06/12] of: device: Fix overflow of coherent_dma_mask

2017-04-04 Thread Sricharan R
Size of the dma-range is calculated as coherent_dma_mask + 1 and passed to arch_setup_dma_ops further. It overflows when the coherent_dma_mask is set for full 64 bits 0x, resulting in size getting passed as 0 wrongly. Fix this by passsing in max(mask, mask + 1). Note that in this ca