Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2018 at 05:38:53PM +0200, Yehezkel Bernat wrote: > Good point. But I thought about per-TBT-device decision. If the platform is > configured for IOMMU+"user" security level, while approving the device the > user > may want to set also in which IOMMU group to put all the PCIe devices

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Yehezkel Bernat
On Tue, Nov 13, 2018 at 5:20 PM Mika Westerberg wrote: > > On Tue, Nov 13, 2018 at 04:42:58PM +0200, Yehezkel Bernat wrote: > > On Tue, Nov 13, 2018 at 1:40 PM Mika Westerberg > > wrote: > > > > > > On Tue, Nov 13, 2018 at 01:13:31PM +0200, Yehezkel Bernat wrote: > > > > On Tue, Nov 13, 2018 at 1

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2018 at 04:42:58PM +0200, Yehezkel Bernat wrote: > On Tue, Nov 13, 2018 at 1:40 PM Mika Westerberg > wrote: > > > > On Tue, Nov 13, 2018 at 01:13:31PM +0200, Yehezkel Bernat wrote: > > > On Tue, Nov 13, 2018 at 12:56 PM Mika Westerberg > > > wrote: > > > > > > > > > Just one point

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Yehezkel Bernat
On Tue, Nov 13, 2018 at 1:40 PM Mika Westerberg wrote: > > On Tue, Nov 13, 2018 at 01:13:31PM +0200, Yehezkel Bernat wrote: > > On Tue, Nov 13, 2018 at 12:56 PM Mika Westerberg > > wrote: > > > > > > > Just one point: > > > > Have you considered the option to add this property per (TBT?) device?

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Mika Westerberg
On Tue, Nov 13, 2018 at 01:13:31PM +0200, Yehezkel Bernat wrote: > On Tue, Nov 13, 2018 at 12:56 PM Mika Westerberg > wrote: > > > > > Just one point: > > > Have you considered the option to add this property per (TBT?) device? > > > > No. ;-) > > > > You mean that one device uses security levels

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Yehezkel Bernat
On Tue, Nov 13, 2018 at 12:56 PM Mika Westerberg wrote: > > > Just one point: > > Have you considered the option to add this property per (TBT?) device? > > No. ;-) > > You mean that one device uses security levels and another IOMMU? I don't > think it is possible without having some sort of table

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Mika Westerberg
On Mon, Nov 12, 2018 at 06:59:02PM +0200, Yehezkel Bernat wrote: > On Mon, Nov 12, 2018 at 6:06 PM Mika Westerberg > wrote: > > > > Recent systems shipping with Windows 10 version 1803 or later may > > support a feature called Kernel DMA protection [1]. In practice this > > means that Thunderbolt

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-13 Thread Mika Westerberg
On Mon, Nov 12, 2018 at 04:22:25PM +, mario.limoncie...@dell.com wrote: > > +DMA protection utilizing IOMMU > > +-- > > +Recent systems shipping with Windows 10 version 1803 or later may support a > > +feature called `Kernel DMA Protection for Thunderbolt 3`_. This

Re: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-12 Thread Yehezkel Bernat
On Mon, Nov 12, 2018 at 6:06 PM Mika Westerberg wrote: > > Recent systems shipping with Windows 10 version 1803 or later may > support a feature called Kernel DMA protection [1]. In practice this > means that Thunderbolt connected devices are placed behind an IOMMU > during the whole time it is co

RE: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-12 Thread Mario.Limonciello
amet; Yehezkel Bernat; Lukas > Wunner; Christian Kellner; Limonciello, Mario; Anthony Wong; Mika Westerberg; > linux-a...@vger.kernel.org; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support > to us

[PATCH 4/4] thunderbolt: Export IOMMU based DMA protection support to userspace

2018-11-12 Thread Mika Westerberg
Recent systems shipping with Windows 10 version 1803 or later may support a feature called Kernel DMA protection [1]. In practice this means that Thunderbolt connected devices are placed behind an IOMMU during the whole time it is connected (including during boot) making Thunderbolt security levels