Re: [PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-12 Thread Will Deacon
On Fri, Feb 12, 2016 at 03:23:04PM +, Robin Murphy wrote: > On 12/02/16 12:32, Laurent Pinchart wrote: > >On Friday 12 February 2016 12:08:58 Will Deacon wrote: > >>On Thu, Feb 11, 2016 at 04:13:45PM +, Robin Murphy wrote: > >>>@@ -173,10 +187,12 @@ static inline void io_pgtable_tlb_sync(st

Re: [PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-12 Thread Robin Murphy
On 12/02/16 12:32, Laurent Pinchart wrote: On Friday 12 February 2016 12:08:58 Will Deacon wrote: On Thu, Feb 11, 2016 at 04:13:45PM +, Robin Murphy wrote: As the number of io-pgtable implementations grows beyond 1, it's time to rationalise the quirks mechanism before things have a chance t

Re: [PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-12 Thread Laurent Pinchart
On Friday 12 February 2016 12:08:58 Will Deacon wrote: > On Thu, Feb 11, 2016 at 04:13:45PM +, Robin Murphy wrote: > > As the number of io-pgtable implementations grows beyond 1, it's time > > to rationalise the quirks mechanism before things have a chance to > > start getting really ugly and o

Re: [PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-12 Thread Will Deacon
On Thu, Feb 11, 2016 at 04:13:45PM +, Robin Murphy wrote: > As the number of io-pgtable implementations grows beyond 1, it's time > to rationalise the quirks mechanism before things have a chance to > start getting really ugly and out-of-hand. > > To that end: > - Indicate exactly which quirks

Re: [PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-11 Thread Laurent Pinchart
Hi Robin, Thank you for the patch. On Thursday 11 February 2016 16:13:45 Robin Murphy wrote: > As the number of io-pgtable implementations grows beyond 1, it's time > to rationalise the quirks mechanism before things have a chance to > start getting really ugly and out-of-hand. > > To that end:

[PATCH 4/3] iommu/io-pgtable: Rationalise quirk handling

2016-02-11 Thread Robin Murphy
As the number of io-pgtable implementations grows beyond 1, it's time to rationalise the quirks mechanism before things have a chance to start getting really ugly and out-of-hand. To that end: - Indicate exactly which quirks each format can/does support. - Fail creating a table if a caller wants u