Re: [PATCH 3/4] iommu/arm-smmu-v3: Add support for PCI ATS

2019-03-25 Thread Jean-Philippe Brucker
On 21/03/2019 15:52, Sinan Kaya wrote: > On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: >> pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ATS); >> +    if (!pos) >> +    return -ENOSYS; >> + > > You don't need this. pci_enable_ats() validates this via. > > if (!dev->ats_cap) >    

Re: [PATCH 3/4] iommu/arm-smmu-v3: Add support for PCI ATS

2019-03-21 Thread Sinan Kaya
On 3/20/2019 1:36 PM, Jean-Philippe Brucker wrote: pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ATS); + if (!pos) + return -ENOSYS; + You don't need this. pci_enable_ats() validates this via. if (!dev->ats_cap) return -EINVAL; ___

[PATCH 3/4] iommu/arm-smmu-v3: Add support for PCI ATS

2019-03-20 Thread Jean-Philippe Brucker
PCIe devices can implement their own TLB, named Address Translation Cache (ATC). Enable Address Translation Service (ATS) for devices that support it and send them invalidation requests whenever we invalidate the IOTLBs. ATC invalidation is allowed to take up to 90 seconds, according to the PCIe s