Re: [PATCH 2/5] iommu/arm-smmu: Sort out coherency

2015-07-28 Thread Robin Murphy
Hi Will, On 28/07/15 10:43, Will Deacon wrote: Hi Robin, Cheers for doing this. Just a few comments (mainly in relation to being consistent with SMMUv3). Thanks! On Mon, Jul 27, 2015 at 07:18:09PM +0100, Robin Murphy wrote: Currently we detect the whether the SMMU has coherent page table w

Re: [PATCH 2/5] iommu/arm-smmu: Sort out coherency

2015-07-28 Thread Will Deacon
Hi Robin, Cheers for doing this. Just a few comments (mainly in relation to being consistent with SMMUv3). On Mon, Jul 27, 2015 at 07:18:09PM +0100, Robin Murphy wrote: > Currently we detect the whether the SMMU has coherent page table walk "we detect the whether"? > capability from the IDR0.CT

[PATCH 2/5] iommu/arm-smmu: Sort out coherency

2015-07-27 Thread Robin Murphy
Currently we detect the whether the SMMU has coherent page table walk capability from the IDR0.CTTW field, and base our cache maintenance decisions on that. In preparation for fixing the bogus DMA API usage, however, we need to ensure that the DMA API agrees about this, which necessitates deferring