Re: [PATCH 2/3] iommu: Add Allwinner H6 IOMMU driver

2020-02-11 Thread Maxime Ripard
Hi Robin, On Mon, Jan 27, 2020 at 07:01:02PM +, Robin Murphy wrote: > > > > +static void sun50i_iommu_domain_free(struct iommu_domain *domain) > > > > +{ > > > > + struct sun50i_iommu_domain *sun50i_domain = > > > > to_sun50i_domain(domain); > > > > + struct sun50i_iommu *iommu =

Re: [PATCH 2/3] iommu: Add Allwinner H6 IOMMU driver

2020-01-27 Thread Robin Murphy
On 27/01/2020 2:22 pm, Maxime Ripard wrote: Hi Robin, Thanks for the extensive review :) On Thu, Jan 23, 2020 at 06:47:14PM +, Robin Murphy wrote: This looks like a pretty decent first cut of a driver, thanks! Plenty of comments, but overall it looks to be in mostly the right shape to begi

Re: [PATCH 2/3] iommu: Add Allwinner H6 IOMMU driver

2020-01-27 Thread Maxime Ripard
Hi Robin, Thanks for the extensive review :) On Thu, Jan 23, 2020 at 06:47:14PM +, Robin Murphy wrote: > This looks like a pretty decent first cut of a driver, thanks! Plenty of > comments, but overall it looks to be in mostly the right shape to begin > with. > > On 22/01/2020 12:44 pm, Maxim

Re: [PATCH 2/3] iommu: Add Allwinner H6 IOMMU driver

2020-01-23 Thread Robin Murphy
Hi Maxime, This looks like a pretty decent first cut of a driver, thanks! Plenty of comments, but overall it looks to be in mostly the right shape to begin with. On 22/01/2020 12:44 pm, Maxime Ripard wrote: The Allwinner H6 has introduced an IOMMU for a few DMA controllers, mostly video rela

[PATCH 2/3] iommu: Add Allwinner H6 IOMMU driver

2020-01-22 Thread Maxime Ripard
The Allwinner H6 has introduced an IOMMU for a few DMA controllers, mostly video related: the display engine, the video decoders / encoders, the camera capture controller, etc. The design is pretty simple compared to other IOMMUs found in SoCs: there's a single instance, controlling all the master