Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-12-12 Thread Joerg Roedel
Hi Jerry, On Thu, Dec 11, 2014 at 09:35:34AM -0700, Jerry Hoemann wrote: > On Tue, Dec 09, 2014 at 01:15:25PM +0100, Joerg Roedel wrote: > > >From d65b236d0f27fe3ef7ac4d12cceb0da67aec86ce Mon Sep 17 00:00:00 2001 > > From: Joerg Roedel > > Date: Tue, 9 Dec 2014 12:56:45 +0100 > > Subject: [PATCH]

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-12-11 Thread Jerry Hoemann
On Tue, Dec 09, 2014 at 01:15:25PM +0100, Joerg Roedel wrote: > On Thu, Nov 06, 2014 at 09:16:05AM -0700, Alex Williamson wrote: > > But the domains are unlinked from device_domain_list using > > unlink_domain_info() which is called from both domain_remove_dev_info() > > and domain_remove_one_dev_i

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-12-09 Thread Joerg Roedel
On Thu, Nov 06, 2014 at 09:16:05AM -0700, Alex Williamson wrote: > But the domains are unlinked from device_domain_list using > unlink_domain_info() which is called from both domain_remove_dev_info() > and domain_remove_one_dev_info() which are both part of that more > likely, unlikely branch in in

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-11-06 Thread Alex Williamson
On Thu, 2014-11-06 at 09:16 -0700, Alex Williamson wrote: > On Thu, 2014-11-06 at 13:54 +0100, Joerg Roedel wrote: > > Hi Alex, > > > > On Tue, Nov 04, 2014 at 09:12:17AM -0700, Alex Williamson wrote: > > > I haven't tested it, but I'm concerned whether this has introduced a > > > domain leak. If

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-11-06 Thread Alex Williamson
On Thu, 2014-11-06 at 13:54 +0100, Joerg Roedel wrote: > Hi Alex, > > On Tue, Nov 04, 2014 at 09:12:17AM -0700, Alex Williamson wrote: > > I haven't tested it, but I'm concerned whether this has introduced a > > domain leak. If we think about the case of unbinding a device from a > > host driver

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-11-06 Thread Joerg Roedel
Hi Alex, On Tue, Nov 04, 2014 at 09:12:17AM -0700, Alex Williamson wrote: > I haven't tested it, but I'm concerned whether this has introduced a > domain leak. If we think about the case of unbinding a device from a > host driver and attaching it to a domain through the IOMMU API, I think > we us

Re: [PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-11-04 Thread Alex Williamson
On Tue, 2014-09-30 at 13:02 +0200, Joerg Roedel wrote: > From: Joerg Roedel > > This makes sure any RMRR mappings stay in place when the > driver is unbound from the device. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/intel-iommu.c | 11 +-- > 1 file changed, 1 insertion(+),

[PATCH 2/2] iommu/vt-d: Only remove domain when device is removed

2014-09-30 Thread Joerg Roedel
From: Joerg Roedel This makes sure any RMRR mappings stay in place when the driver is unbound from the device. Signed-off-by: Joerg Roedel --- drivers/iommu/intel-iommu.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu