Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-26 Thread j...@8bytes.org
On Wed, Jan 25, 2012 at 08:39:32AM +0100, Hiroshi Doyu wrote: > From: Hiroshi DOYU > Date: Thu, 17 Nov 2011 07:31:31 +0200 > Subject: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver > > Tegra 30 IOMMU H/W, SMMU (System Memory Management Unit). This patch >

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Hiroshi Doyu
From: "j...@8bytes.org" Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver Date: Tue, 24 Jan 2012 15:25:21 +0100 Message-ID: <20120124142521.ge6...@8bytes.org> > On Tue, Jan 24, 2012 at 03:46:01PM +0200, Felipe Balbi wrote: > > On Tue, Jan 24,

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Felipe Balbi
Hi, On Tue, Jan 24, 2012 at 02:41:21PM +0100, Hiroshi Doyu wrote: > From: Joerg Roedel > Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver > Date: Mon, 23 Jan 2012 16:43:10 +0100 > Message-ID: <20120123154310.gc

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread j...@8bytes.org
On Tue, Jan 24, 2012 at 03:46:01PM +0200, Felipe Balbi wrote: > On Tue, Jan 24, 2012 at 02:41:21PM +0100, Hiroshi Doyu wrote: > > Actually I really like the concept of this "domain" now, which hides > > the H/W hierarchy from users. > > > > But in Tegra SMMU/GART case, there's a single one IOMMU d

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Hiroshi Doyu
From: Joerg Roedel Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver Date: Mon, 23 Jan 2012 16:43:10 +0100 Message-ID: <20120123154310.gc6...@8bytes.org> > > + } > > + > > + spin_unlock_irqrestore(&as->lock, flags); > > + > &g

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Hiroshi Doyu
From: "joerg.roe...@amd.com" Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver Date: Tue, 24 Jan 2012 12:57:23 +0100 Message-ID: <20120124115723.gc19...@amd.com> > On Tue, Jan 24, 2012 at 12:36:14PM +0100, Hiroshi Doyu wrote: > > > A domai

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread joerg.roe...@amd.com
On Tue, Jan 24, 2012 at 12:36:14PM +0100, Hiroshi Doyu wrote: > > A domain is, as you said, a virtual address space for IO devices. But > > the important point is, an arbitrary number of devices can be part of a > > domain. This also means that the devices can be behind different > > hardware SMMUs

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Hiroshi Doyu
From: Joerg Roedel Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver Date: Tue, 24 Jan 2012 12:04:44 +0100 Message-ID: <20120124110444.gb19...@amd.com> > > > Hmm, this looks like there is a 1-1 mapping between hardware SMMU > > > devices

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Joerg Roedel
On Tue, Jan 24, 2012 at 10:57:01AM +0100, Hiroshi Doyu wrote: > > Why do you completly ignore the size parameter in this function (and > > in the unmap part below)? > > According to the page-sizes you export to the generic layer size can be > > 4k or 4M. You need to take care of that in this functi

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-24 Thread Hiroshi Doyu
Hi Joerg, From: Joerg Roedel Subject: Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver Date: Mon, 23 Jan 2012 16:43:10 +0100 Message-ID: <20120123154310.gc6...@8bytes.org> > Hi, > > please see my comments inline. When you fix these issues I think the > d

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-23 Thread Joerg Roedel
Hi, please see my comments inline. When you fix these issues I think the driver is ready for merging. On Thu, Jan 05, 2012 at 09:11:49AM +0200, Hiroshi DOYU wrote: > +static int smmu_iommu_map(struct iommu_domain *domain, unsigned long iova, > + phys_addr_t pa, size_t bytes,