Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper

2020-02-19 Thread Joerg Roedel
On Tue, Feb 18, 2020 at 09:14:54AM -0800, Christoph Hellwig wrote: > > +static bool attach_deferred(struct device *dev) > > +{ > > + return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO; > > +} > > This is not a very useful helper. Depends on what one considers useful. I think such helpers ma

Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper

2020-02-18 Thread Christoph Hellwig
> +static bool attach_deferred(struct device *dev) > +{ > + return dev->archdata.iommu == DEFER_DEVICE_DOMAIN_INFO; > +} This is not a very useful helper. > + > /** > * is_downstream_to_pci_bridge - test if a device belongs to the PCI > *sub-hierarchy of a can

Re: [PATCH 1/5] iommu/vt-d: Add attach_deferred() helper

2020-02-17 Thread Jerry Snitselaar
On Mon Feb 17 20, Joerg Roedel wrote: From: Joerg Roedel Implement a helper function to check whether a device's attach process is deferred. Signed-off-by: Joerg Roedel Reviewed-by: Jerry Snitselaar ___ iommu mailing list iommu@lists.linux-found

[PATCH 1/5] iommu/vt-d: Add attach_deferred() helper

2020-02-17 Thread Joerg Roedel
From: Joerg Roedel Implement a helper function to check whether a device's attach process is deferred. Signed-off-by: Joerg Roedel --- drivers/iommu/intel-iommu.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-