Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Robin Murphy
On 10/02/17 16:11, Joerg Roedel wrote: > On Fri, Feb 10, 2017 at 04:03:07PM +, Robin Murphy wrote: >> Yeah, on reflection explicit initialisation is certainly easier to read >> than a bunch of arguments handled implicitly by register(), but then >> from that angle, even more clear would be to s

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Joerg Roedel
On Fri, Feb 10, 2017 at 04:03:07PM +, Robin Murphy wrote: > Yeah, on reflection explicit initialisation is certainly easier to read > than a bunch of arguments handled implicitly by register(), but then > from that angle, even more clear would be to simply have the drivers > write the relevant

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Robin Murphy
On 10/02/17 15:22, Joerg Roedel wrote: > Hi Robin, > > On Fri, Feb 10, 2017 at 02:16:54PM +, Robin Murphy wrote: >>> +static inline void iommu_device_set_fwnode(struct iommu_device *iommu, >>> + struct fwnode_handle *fwnode) >>> +{ >>> + iommu->fwnode = f

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Joerg Roedel
Hi Robin, On Fri, Feb 10, 2017 at 02:16:54PM +, Robin Murphy wrote: > > +static inline void iommu_device_set_fwnode(struct iommu_device *iommu, > > + struct fwnode_handle *fwnode) > > +{ > > + iommu->fwnode = fwnode; > > +} > > Would it make sense to sim

Re: [PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-10 Thread Robin Murphy
On 09/02/17 11:32, Joerg Roedel wrote: > From: Joerg Roedel > > Allow to store a fwnode in 'struct iommu_device'; > > Signed-off-by: Joerg Roedel > --- > include/linux/iommu.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h

[PATCH 06/11] iommu: Add iommu_device_set_fwnode() interface

2017-02-09 Thread Joerg Roedel
From: Joerg Roedel Allow to store a fwnode in 'struct iommu_device'; Signed-off-by: Joerg Roedel --- include/linux/iommu.h | 12 1 file changed, 12 insertions(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index bae3cfc..626c935 100644 --- a/include/linux/iommu.h +