Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 5:26 PM, Tuukka Toivonen wrote: > Hi Tomasz, > > Couple of small comments below. > > On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) >> >> +{ >> >> + struct ipu3_mmu_domain *mmu_dom = >> >> +

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 8:16 PM, Sakari Ailus wrote: > Hi Tomasz, > > On Fri, Jun 09, 2017 at 02:59:10PM +0900, Tomasz Figa wrote: >> On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: >> >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) >> >> >> +{ >> >> >> + struct ipu3_mm

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Sakari Ailus
Hi Tomasz, On Fri, Jun 09, 2017 at 02:59:10PM +0900, Tomasz Figa wrote: > On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: > >> >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) > >> >> +{ > >> >> + struct ipu3_mmu_domain *mmu_dom = > >> >> + container_of(dom,

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-09 Thread Tuukka Toivonen
Hi Tomasz, Couple of small comments below. On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: > >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) > >> +{ > >> + struct ipu3_mmu_domain *mmu_dom = > >> + container_of(dom, struct ipu3_mmu_domain, domain); > >> +

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
On Fri, Jun 9, 2017 at 1:43 AM, Sakari Ailus wrote: > Hi Tomasz, > > On Wed, Jun 07, 2017 at 05:35:13PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> Continuing from yesterday. Please see comments inline. >> >> > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: >> [snip] >> >> + ptr =

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Sakari Ailus
Hi Tomasz, On Wed, Jun 07, 2017 at 05:35:13PM +0900, Tomasz Figa wrote: > Hi Yong, Tuukka, > > Continuing from yesterday. Please see comments inline. > > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > [snip] > >> + ptr = ipu3_mmu_alloc_page_table(mmu_dom, false); > >> + if (!pt

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-08 Thread Tomasz Figa
Hi Sakari, On Thu, Jun 8, 2017 at 6:59 AM, Sakari Ailus wrote: > Hi Tomasz, > > On Tue, Jun 06, 2017 at 07:13:19PM +0900, Tomasz Figa wrote: >> Hi Yong, Tuukka, >> >> +CC IOMMU ML and Joerg. (Technically you should resend this patch >> including them.) > > Thanks! > >> >> On Tue, Jun 6, 2017 at 5

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-07 Thread Sakari Ailus
Hi Tomasz, On Tue, Jun 06, 2017 at 07:13:19PM +0900, Tomasz Figa wrote: > Hi Yong, Tuukka, > > +CC IOMMU ML and Joerg. (Technically you should resend this patch > including them.) Thanks! > > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: ... > > diff --git a/drivers/media/pci/intel/ipu3/Kco

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-07 Thread Tomasz Figa
Hi Yong, Tuukka, Continuing from yesterday. Please see comments inline. > On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: [snip] >> + ptr = ipu3_mmu_alloc_page_table(mmu_dom, false); >> + if (!ptr) >> + goto fail_page_table; >> + >> + /* >> +* We always ma

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

2017-06-06 Thread Tomasz Figa
Hi Yong, Tuukka, +CC IOMMU ML and Joerg. (Technically you should resend this patch including them.) On Tue, Jun 6, 2017 at 5:39 AM, Yong Zhi wrote: > From: Tuukka Toivonen > > This driver translates Intel IPU3 internal virtual > address to physical address. Please see my comments inline. > >