Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-07 Thread Jean-Philippe Brucker
On Wed, Nov 06, 2019 at 10:11:55PM -0800, Saravana Kannan wrote: > > Right, in short the fundamental problem is that of_iommu_configure() now > > does the wrong thing. Deferring probe of the entire host bridge/root > > complex based on "iommu-map" would indeed happen to solve the problem by > > bru

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-06 Thread Saravana Kannan via iommu
On Wed, Oct 30, 2019 at 5:57 PM Saravana Kannan wrote: > > On Wed, Oct 30, 2019 at 8:54 AM Will Deacon wrote: > > > > Hi Robin, > > > > On Wed, Oct 30, 2019 at 03:35:55PM +, Robin Murphy wrote: > > > On 30/10/2019 14:51, Will Deacon wrote: > > > > As part of the work to enable a "Generic Kern

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-06 Thread Saravana Kannan via iommu
On Mon, Nov 4, 2019 at 5:29 AM Robin Murphy wrote: > > On 04/11/2019 12:16, John Garry wrote: > > On 01/11/2019 21:13, Saravana Kannan wrote: > >> On Fri, Nov 1, 2019 at 3:28 AM John Garry wrote: > >>> > >>> On 31/10/2019 23:34, Saravana Kannan via iommu wrote: > I looked into the iommu-map

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-06 Thread Saravana Kannan via iommu
On Mon, Nov 4, 2019 at 4:16 AM John Garry wrote: > > On 01/11/2019 21:13, Saravana Kannan wrote: > > On Fri, Nov 1, 2019 at 3:28 AM John Garry wrote: > >> > >> On 31/10/2019 23:34, Saravana Kannan via iommu wrote: > >>> I looked into the iommu-map property and it shouldn't be too hard to > >>> ad

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-06 Thread Saravana Kannan via iommu
On Mon, Nov 4, 2019 at 3:43 AM Lorenzo Pieralisi wrote: > > On Fri, Nov 01, 2019 at 02:26:05PM -0700, Saravana Kannan wrote: > > On Fri, Nov 1, 2019 at 5:28 AM Lorenzo Pieralisi > > wrote: > > > > > > On Fri, Nov 01, 2019 at 12:41:48PM +0100, Jean-Philippe Brucker wrote: > > > > > > [...] > > > >

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-04 Thread Robin Murphy
On 04/11/2019 12:16, John Garry wrote: On 01/11/2019 21:13, Saravana Kannan wrote: On Fri, Nov 1, 2019 at 3:28 AM John Garry wrote: On 31/10/2019 23:34, Saravana Kannan via iommu wrote: I looked into the iommu-map property and it shouldn't be too hard to add support for it. Looks like we can

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-04 Thread John Garry
On 01/11/2019 21:13, Saravana Kannan wrote: On Fri, Nov 1, 2019 at 3:28 AM John Garry wrote: On 31/10/2019 23:34, Saravana Kannan via iommu wrote: I looked into the iommu-map property and it shouldn't be too hard to add support for it. Looks like we can simply hold off on probing the root bri

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-04 Thread Lorenzo Pieralisi
On Fri, Nov 01, 2019 at 02:26:05PM -0700, Saravana Kannan wrote: > On Fri, Nov 1, 2019 at 5:28 AM Lorenzo Pieralisi > wrote: > > > > On Fri, Nov 01, 2019 at 12:41:48PM +0100, Jean-Philippe Brucker wrote: > > > > [...] > > > > > > > I'm also wondering about ACPI support. > > > > > > > > I'd love to

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-03 Thread Jean-Philippe Brucker
Hi Will, On Fri, Nov 01, 2019 at 05:21:46PM +, Will Deacon wrote: > As far as symbols exported from the IOMMU and PCI layers, did you find you > needed anything on top of the stuff I'm exporting in patches 1 and 3? No, I needed the same symbols (minus fsl_mc_device_group and iommu_group_ref_g

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread Saravana Kannan via iommu
On Fri, Nov 1, 2019 at 5:28 AM Lorenzo Pieralisi wrote: > > On Fri, Nov 01, 2019 at 12:41:48PM +0100, Jean-Philippe Brucker wrote: > > [...] > > > > > I'm also wondering about ACPI support. > > > > > > I'd love to add ACPI support too, but I have zero knowledge of ACPI. > > > I'd be happy to help

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread Saravana Kannan via iommu
On Fri, Nov 1, 2019 at 3:28 AM John Garry wrote: > > On 31/10/2019 23:34, Saravana Kannan via iommu wrote: > > I looked into the iommu-map property and it shouldn't be too hard to > > add support for it. Looks like we can simply hold off on probing the > > root bridge device till all the iommus in

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread Will Deacon
Hi Jean-Philippe, Quick question while you figure out the devlink stuff with Saravana... On Thu, Oct 31, 2019 at 08:37:58PM +0100, Jean-Philippe Brucker wrote: > On Wed, Oct 30, 2019 at 05:57:44PM -0700, Saravana Kannan via iommu wrote: > > > > > Obviously you need to be careful about using IOMMU

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread Lorenzo Pieralisi
On Fri, Nov 01, 2019 at 12:41:48PM +0100, Jean-Philippe Brucker wrote: [...] > > > I'm also wondering about ACPI support. > > > > I'd love to add ACPI support too, but I have zero knowledge of ACPI. > > I'd be happy to help anyone who wants to add ACPI support that allows > > ACPI to add device

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread Jean-Philippe Brucker
On Thu, Oct 31, 2019 at 04:34:14PM -0700, Saravana Kannan wrote: > > Neat, I'm trying to do the same for virtio-iommu. It needs to be modular > > because it depends on the virtio transport, which distributions usually > > build as a module. So far I've been managing the device links in > > virtio-i

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-11-01 Thread John Garry
On 31/10/2019 23:34, Saravana Kannan via iommu wrote: I looked into the iommu-map property and it shouldn't be too hard to add support for it. Looks like we can simply hold off on probing the root bridge device till all the iommus in its iommu-map are probed and we should be fine. I'm also unsu

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-31 Thread Saravana Kannan via iommu
On Thu, Oct 31, 2019 at 12:38 PM Jean-Philippe Brucker wrote: > > Hi Saravana, Will, > > On Wed, Oct 30, 2019 at 05:57:44PM -0700, Saravana Kannan via iommu wrote: > > > > > Obviously you need to be careful about using IOMMU drivers as modules, > > > > > since late loading of the driver for an IOM

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-31 Thread Jean-Philippe Brucker
Hi Saravana, Will, On Wed, Oct 30, 2019 at 05:57:44PM -0700, Saravana Kannan via iommu wrote: > > > > Obviously you need to be careful about using IOMMU drivers as modules, > > > > since late loading of the driver for an IOMMU serving active DMA masters > > > > is going to end badly in many cases.

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-31 Thread Saravana Kannan via iommu
On Wed, Oct 30, 2019 at 8:54 AM Will Deacon wrote: > > Hi Robin, > > On Wed, Oct 30, 2019 at 03:35:55PM +, Robin Murphy wrote: > > On 30/10/2019 14:51, Will Deacon wrote: > > > As part of the work to enable a "Generic Kernel Image" across multiple > > > Android devices, there is a need to sepe

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-30 Thread Will Deacon
Hi Robin, On Wed, Oct 30, 2019 at 03:35:55PM +, Robin Murphy wrote: > On 30/10/2019 14:51, Will Deacon wrote: > > As part of the work to enable a "Generic Kernel Image" across multiple > > Android devices, there is a need to seperate shared, core kernel code > > from modular driver code that m

Re: [PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-30 Thread Robin Murphy
On 30/10/2019 14:51, Will Deacon wrote: Hi all, As part of the work to enable a "Generic Kernel Image" across multiple Android devices, there is a need to seperate shared, core kernel code from modular driver code that may not be needed by all SoCs. This means building IOMMU drivers as modules.

[PATCH 0/7] iommu: Permit modular builds of ARM SMMU[v3] drivers

2019-10-30 Thread Will Deacon
Hi all, As part of the work to enable a "Generic Kernel Image" across multiple Android devices, there is a need to seperate shared, core kernel code from modular driver code that may not be needed by all SoCs. This means building IOMMU drivers as modules. It turns out that most of the groundwork