Re: [PATCH -next v2] iommu/amd: fix a null-ptr-deref in map_sg()

2019-06-12 Thread Joerg Roedel
On Mon, May 06, 2019 at 12:44:40PM -0400, Qian Cai wrote: > The commit 1a1079011da3 ("iommu/amd: Flush not present cache in > iommu_map_page") That patch was reverted by me in 97a18f548548a6ee1b9be14c6fc72090b8839875 because it caused issues by testers. So maybe re-submit the above patc

Re: [PATCH -next v2] iommu/amd: fix a null-ptr-deref in map_sg()

2019-06-06 Thread Tom Murphy
Hi Joerg, Is there anything I need to do to get this patch into linux-next? My patch to convert the amd iommu driver to use the dma-iommu ops depends on this patch. Thanks, Tom On Tue, May 7, 2019 at 8:39 AM Joerg Roedel wrote: > > Hi Qian, > > On Mon, May 06, 2019 at 12:44:40PM -0400, Qian Cai

Re: [PATCH -next v2] iommu/amd: fix a null-ptr-deref in map_sg()

2019-05-07 Thread Joerg Roedel
Hi Qian, On Mon, May 06, 2019 at 12:44:40PM -0400, Qian Cai wrote: > The commit 1a1079011da3 ("iommu/amd: Flush not present cache in > iommu_map_page") added domain_flush_np_cache() in map_sg() which > triggered a crash below during boot. sg_next() could return NULL if > sg_is_last() is true, so a

[PATCH -next v2] iommu/amd: fix a null-ptr-deref in map_sg()

2019-05-06 Thread Qian Cai
The commit 1a1079011da3 ("iommu/amd: Flush not present cache in iommu_map_page") added domain_flush_np_cache() in map_sg() which triggered a crash below during boot. sg_next() could return NULL if sg_is_last() is true, so after for_each_sg(sglist, s, nelems, i), "s" could be NULL which ends up defe