Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-07 Thread Joerg Roedel
On Tue, Apr 05, 2016 at 03:05:46PM +0100, John Keeping wrote: > drivers/iommu/rockchip-iommu.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Applied to iommu/fixes. Thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https:

Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-06 Thread Tomeu Vizoso
On 5 April 2016 at 21:10, Heiko Stuebner wrote: > Am Dienstag, 5. April 2016, 18:28:58 schrieb John Keeping: >> On Tue, 05 Apr 2016 10:21:27 -0700, Heiko Stuebner wrote: >> > Am Dienstag, 5. April 2016, 15:05:46 schrieb John Keeping: >> > > Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct t

Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-05 Thread Heiko Stuebner
Am Dienstag, 5. April 2016, 18:28:58 schrieb John Keeping: > On Tue, 05 Apr 2016 10:21:27 -0700, Heiko Stuebner wrote: > > Am Dienstag, 5. April 2016, 15:05:46 schrieb John Keeping: > > > Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct to support > > > multi > > > slaves") rk_iommu_is_stall

Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-05 Thread John Keeping
On Tue, 05 Apr 2016 10:21:27 -0700, Heiko Stuebner wrote: > Am Dienstag, 5. April 2016, 15:05:46 schrieb John Keeping: > > Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi > > slaves") rk_iommu_is_stall_active() always returns false because the > > bitwise AND operates on t

Re: [PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-05 Thread Heiko Stuebner
Am Dienstag, 5. April 2016, 15:05:46 schrieb John Keeping: > Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi > slaves") rk_iommu_is_stall_active() always returns false because the > bitwise AND operates on the boolean flag promoted to an integer and a > value that is either

[PATCH] iommu/rockchip: Fix "is stall active" check

2016-04-05 Thread John Keeping
Since commit cd6438c5f844 ("iommu/rockchip: Reconstruct to support multi slaves") rk_iommu_is_stall_active() always returns false because the bitwise AND operates on the boolean flag promoted to an integer and a value that is either zero or BIT(2). Explicitly convert the right-hand value to a bool