Re: [PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-09-25 Thread Joerg Roedel
Hi Robin, On Tue, Sep 25, 2018 at 11:48:17AM +0100, Robin Murphy wrote: > Will has the cleaned-up version in his tree along with a couple of other > SMMU fixes, which I assume he's planning to send you a pull for (he's off at > yet another conference just now so I can't confirm offline). Okay, le

Re: [PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-09-25 Thread Robin Murphy
Hi Joerg, On 25/09/18 10:01, Joerg Roedel wrote: Hey Robin, On Thu, Aug 23, 2018 at 01:14:59PM +0100, Robin Murphy wrote: Fixes: 2c3d273eabe8 ("iommu/io-pgtable-arm: Support lockless operation") Signed-off-by: Robin Murphy I can't find a newer version of this in my inbox, do you plan to sen

Re: [PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-09-25 Thread Joerg Roedel
Hey Robin, On Thu, Aug 23, 2018 at 01:14:59PM +0100, Robin Murphy wrote: > Fixes: 2c3d273eabe8 ("iommu/io-pgtable-arm: Support lockless operation") > Signed-off-by: Robin Murphy I can't find a newer version of this in my inbox, do you plan to send one or has it been addressed differently? Rega

Re: [PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-09-06 Thread Robin Murphy
On 06/09/18 11:05, Will Deacon wrote: Hi Robin, On Thu, Aug 23, 2018 at 01:14:59PM +0100, Robin Murphy wrote: In removing the pagetable-wide lock, we gained the possibility of the vanishingly unlikely case where we have a race between two concurrent unmappers splitting the same block entry. The

Re: [PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-09-06 Thread Will Deacon
Hi Robin, On Thu, Aug 23, 2018 at 01:14:59PM +0100, Robin Murphy wrote: > In removing the pagetable-wide lock, we gained the possibility of the > vanishingly unlikely case where we have a race between two concurrent > unmappers splitting the same block entry. The logic to handle this is > fairly s

[PATCH] iommu/io-pgtable-arm: Fix race handling in split_blk_unmap()

2018-08-23 Thread Robin Murphy
In removing the pagetable-wide lock, we gained the possibility of the vanishingly unlikely case where we have a race between two concurrent unmappers splitting the same block entry. The logic to handle this is fairly straightforward - whoever loses the race frees their partial next-level table and