Re: [PATCH] dma-debug: use named initializers for dir2name

2020-07-19 Thread Christoph Hellwig
On Thu, Jul 16, 2020 at 05:12:30PM +0100, Robin Murphy wrote: >> +static const char *dir2name[4] = { > > Nit: I think you can probably drop the explicit array size here. > > Otherwise, very welcome clarity! > > Reviewed-by: Robin Murphy Applied with the explicit array size removed. __

Re: [PATCH] dma-debug: use named initializers for dir2name

2020-07-16 Thread Robin Murphy
On 2020-07-16 16:01, Christoph Hellwig wrote: Make dir2name a little more readable and maintainable by using named initializers. Signed-off-by: Christoph Hellwig --- kernel/dma/debug.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/dma/debug.c b/kernel/dma

[PATCH] dma-debug: use named initializers for dir2name

2020-07-16 Thread Christoph Hellwig
Make dir2name a little more readable and maintainable by using named initializers. Signed-off-by: Christoph Hellwig --- kernel/dma/debug.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c index 36c962a86bf25d..41e720c3ab20c5 1006