Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-03-01 Thread Ohad Ben-Cohen
Hi Laurent, On Thu, Mar 1, 2012 at 6:37 PM, Laurent Pinchart wrote: > I'll try that then. How expensive is the iommu_attach_device() (and detach) > operation in terms of CPU time ? omap_iommu_attach() basically enables the iommu clock and configures that IP block. I suspect it's negligible but

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-03-01 Thread Laurent Pinchart
Hi Ohad, On Monday 27 February 2012 09:00:51 Ohad Ben-Cohen wrote: > On Mon, Feb 27, 2012 at 12:47 AM, Laurent Pinchart wrote: > > I'm asking about the probe deferral mechanism. The omap3-isp driver will > > still call iommu_attach_device() in its probe function. What will happen > > then ? Will i

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-27 Thread Joerg Roedel
On Sun, Feb 26, 2012 at 12:14:14PM +0200, Ohad Ben-Cohen wrote: > omap3isp depends on omap's iommu and will fail to probe if > initialized before it (which always happen if they are builtin). > > Make omap's iommu subsys_initcall as an interim solution until > the probe deferral mechanism is merge

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-27 Thread Joerg Roedel
On Mon, Feb 27, 2012 at 09:00:51AM +0200, Ohad Ben-Cohen wrote: > On Mon, Feb 27, 2012 at 12:47 AM, Laurent Pinchart > > That's what the comment in the Makefile is for ;-) I don't think it's a > > perfect solution either, but it avoids playing with the various initcalls. > > The > > OMAP3 IOMMU is

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-26 Thread Ohad Ben-Cohen
Hi Laurent, On Mon, Feb 27, 2012 at 12:47 AM, Laurent Pinchart wrote: > I'm asking about the probe deferral mechanism. The omap3-isp driver will still > call iommu_attach_device() in its probe function. What will happen then ? Will > it return an error ? On what basis will it do so ? Yes, iommu_

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-26 Thread Laurent Pinchart
Hi Ohad, On Sunday 26 February 2012 20:30:17 Ohad Ben-Cohen wrote: > On Sun, Feb 26, 2012 at 7:34 PM, Laurent Pinchart wrote: > > On Sunday 26 February 2012 12:14:14 Ohad Ben-Cohen wrote: > >> omap3isp depends on omap's iommu and will fail to probe if > >> initialized before it (which always happe

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-26 Thread Ohad Ben-Cohen
Hi Laurent, On Sun, Feb 26, 2012 at 7:34 PM, Laurent Pinchart wrote: > On Sunday 26 February 2012 12:14:14 Ohad Ben-Cohen wrote: >> omap3isp depends on omap's iommu and will fail to probe if >> initialized before it (which always happen if they are builtin). >> >> Make omap's iommu subsys_initcal

Re: [PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-26 Thread Laurent Pinchart
Hi Ohad, On Sunday 26 February 2012 12:14:14 Ohad Ben-Cohen wrote: > omap3isp depends on omap's iommu and will fail to probe if > initialized before it (which always happen if they are builtin). > > Make omap's iommu subsys_initcall as an interim solution until > the probe deferral mechanism is m

[PATCH] ARM: OMAP: make iommu subsys_initcall to fix builtin omap3isp

2012-02-26 Thread Ohad Ben-Cohen
omap3isp depends on omap's iommu and will fail to probe if initialized before it (which always happen if they are builtin). Make omap's iommu subsys_initcall as an interim solution until the probe deferral mechanism is merged. Reported-by: James Debugged-by: Laurent Pinchart Signed-off-by: Ohad