[PATCH] hpsa: fix NULL dereference in hpsa_put_ctlr_into_performant_mode()

2014-04-14 Thread scameron
Initialize local variable trans_support before it is used rather than after. It is supposed to contain the value of a register on the controller containing bits that describe which transport modes the controller supports (e.g. "performant", "ioaccel1", "ioaccel2"). A NULL pointer dereference wi

Re: [PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-14 Thread scameron
On Mon, Apr 14, 2014 at 08:45:16AM -0700, James Bottomley wrote: > Your subject line is very tame. It should be the one line summary of > why we apply the patch, so it should read something like > > hpsa: fix NULL deref in performant mode > > On Thu, 2014-04-10 at 17:17 -0500, scame...@beardog.

[PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-10 Thread scameron
Without this, you'll see a null pointer dereference in hpsa_enter_performant_mode(). Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8cf4a0c..ef4dfdd 100644 ---

Re: hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread scameron
; > > 000e000d 001f 00120011 00040013 > > > Call Trace: > > > [] ? SA5_fifo_full+0x20/0x20 [hpsa] > > > [] ? SA5_ioaccel_mode1_completed+0xd0/0xd0 [hpsa] > > > [] hpsa_put_ctlr_into_performant_mode+0x186/0x320 > > >

Re: hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread scameron
[] local_pci_probe+0x4c/0xb0 > > [] pci_call_probe+0x89/0xb0 > > [] ? pci_match_device+0xc4/0xd0 > > [] pci_device_probe+0x79/0xa0 > > [] ? driver_sysfs_add+0x82/0xb0 > > [] really_probe+0x6c/0x320 > > usb 1-1.6: New USB device found,

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread scameron
On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: > On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: > > [+cc Joerg, iommu list] > > > > On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote: > > > On Wed, 2014-04-09 at 16:50 -0700, James Bottomley wrote: > > >> On Wed, 2014