Re: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled

2022-07-07 Thread Serge Semin
On Thu, Jul 07, 2022 at 09:22:26AM +0100, Marc Zyngier wrote: > On Tue, 05 Jul 2022 14:52:43 +0100, > Serge Semin wrote: > > > > Hi Samuel > > > > On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote: > > > The MIPS GIC irqchip d

Re: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled

2022-07-05 Thread Serge Semin
Hi Samuel On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote: > The MIPS GIC irqchip driver may be selected in a uniprocessor > configuration, but it unconditionally registers an IPI domain. > > Limit the part of the driver dealing with IPIs to only be compiled when > GENERIC_IRQ_IPI

Re: [PATCH] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-06-20 Thread Serge Semin
Folks, On Fri, Jun 10, 2022 at 11:08:02AM +0300, Serge Semin wrote: > A basic device-specific linear memory mapping was introduced back in > commit ("dma: Take into account dma_pfn_offset") as a single-valued offset > preserved in the device.dma_pfn_offset field, which

[PATCH] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-06-10 Thread Serge Semin via iommu
ss from the passed memory resource for the case of the directly mapped DMA. Fixes: 25f1e1887088 ("dma: Take into account dma_pfn_offset") Signed-off-by: Serge Semin --- After a long discussion with Christoph and Robin regarding this patch here: https://lore.kernel.org/lk

Re: [PATCH v2 01/26] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-05-12 Thread Serge Semin
On Mon, May 09, 2022 at 08:15:52AM +0200, Christoph Hellwig wrote: > So I think the big problem pointed out by Robin is that existing DTs > might not take this into account. I'd say that the biggest problem isn't in the DT part but in the drivers using the dma_map_resource() method since they don

[PATCH v2 01/26] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-05-03 Thread Serge Semin
ss from the passed memory resource for the case of the directly mapped DMA. Fixes: 25f1e1887088 ("dma: Take into account dma_pfn_offset") Signed-off-by: Serge Semin --- kernel/dma/direct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/direct.c b/ker

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-24 Thread Serge Semin
On Thu, Apr 21, 2022 at 09:51:31PM +0100, Robin Murphy wrote: > On 2022-04-21 18:35, Serge Semin wrote: > > On Thu, Apr 21, 2022 at 04:45:36PM +0200, Christoph Hellwig wrote: > > > On Wed, Apr 20, 2022 at 11:55:38AM +0300, Serge Semin wrote: > > > > On Wed, Ap

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-21 Thread Serge Semin
On Thu, Apr 21, 2022 at 04:45:36PM +0200, Christoph Hellwig wrote: > On Wed, Apr 20, 2022 at 11:55:38AM +0300, Serge Semin wrote: > > On Wed, Apr 20, 2022 at 10:47:46AM +0200, Christoph Hellwig wrote: > > > I can't really comment on the dma-ranges exlcusion for P2P mappings,

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-20 Thread Serge Semin
orm devices over the system interconnect bus. > > On Wed, Apr 20, 2022 at 11:32:07AM +0300, Serge Semin wrote: > > See, if I get to map a virtual memory address to be accessible by any > > PCIe peripheral device, then the dma_map_sg/dma_map_page/etc > > procedures will take

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-20 Thread Serge Semin
On Wed, Apr 20, 2022 at 09:12:17AM +0200, Christoph Hellwig wrote: > On Mon, Apr 18, 2022 at 01:44:27AM +0300, Serge Semin wrote: > > > but a DMA controller might also want to access something in the MMIO range > > > 0x0-0x7fff, of which it still has an identical

Re: [PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-04-17 Thread Serge Semin
Hello Robin. Sorry for the delayed answer. My comments are below. On Thu, Mar 24, 2022 at 11:30:38AM +, Robin Murphy wrote: > On 2022-03-24 01:48, Serge Semin wrote: > > A basic device-specific linear memory mapping was introduced back in > > commit ("dma: Take into ac

[PATCH 03/25] dma-direct: take dma-ranges/offsets into account in resource mapping

2022-03-24 Thread Serge Semin
ss from the passed memory resource for the case of the directly mapped DMA. Fixes: 25f1e1887088 ("dma: Take into account dma_pfn_offset") Signed-off-by: Serge Semin --- kernel/dma/direct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/direct.c b/ker

Re: [PATCH v2 07/12] NTB: Introduce functions to calculate multi-port resource index

2019-03-12 Thread Serge Semin
On Wed, Mar 06, 2019 at 04:22:33PM -0700, Logan Gunthorpe wrote: > > On 2019-03-06 3:45 p.m., Serge Semin wrote: > [Snip] > > Pretty sure everything above is just agreement... > > > So your current approach is inbound MW-centralized, while mine is developed > > a

Re: [PATCH v2 09/12] NTB: Introduce MSI library

2019-03-06 Thread Serge Semin
On Wed, Mar 06, 2019 at 02:35:53PM -0700, Logan Gunthorpe wrote: > > > On 2019-03-06 1:26 p.m., Serge Semin wrote: > > First of all, It might be unsafe to have some resources consumed by NTB > > MSI or some other library without a simple way to warn NTB client drivers > &

Re: [PATCH v2 07/12] NTB: Introduce functions to calculate multi-port resource index

2019-03-06 Thread Serge Semin
On Wed, Mar 06, 2019 at 12:11:11PM -0700, Logan Gunthorpe wrote: > > > On 2019-03-05 6:24 p.m., Serge Semin wrote: > >> + * In a 5 peer system, this function will return the following matrix > >> + * > >> + * pidx \ port01234 > >

Re: [PATCH v2 10/12] NTB: Introduce NTB MSI Test Client

2019-03-06 Thread Serge Semin
Hi On Wed, Feb 13, 2019 at 10:54:52AM -0700, Logan Gunthorpe wrote: > Introduce a tool to test NTB MSI interrupts similar to the other > NTB test tools. This tool creates a debugfs directory for each > NTB device with the following files: > > port > irqX_occurrences > peerX/port > peerX/count > p

Re: [PATCH v2 09/12] NTB: Introduce MSI library

2019-03-06 Thread Serge Semin
On Wed, Feb 13, 2019 at 10:54:51AM -0700, Logan Gunthorpe wrote: Hi > The NTB MSI library allows passing MSI interrupts across a memory > window. This offers similar functionality to doorbells or messages > except will often have much better latency and the client can > potentially use significan

Re: [PATCH v2 07/12] NTB: Introduce functions to calculate multi-port resource index

2019-03-06 Thread Serge Semin
On Wed, Feb 13, 2019 at 10:54:49AM -0700, Logan Gunthorpe wrote: Hi > When using multi-ports each port uses resources (dbs, msgs, mws, etc) > on every other port. Creating a mapping for these resources such that > each port has a corresponding resource on every other port is a bit > tricky. > >