Re: [PATCH] dma: mark unmapped DMA scatter/gather invalid

2021-01-11 Thread Marc Orr via iommu
> >>> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > >>> index 0a4881e59aa7..3d9b17fe5771 100644 > >>> --- a/kernel/dma/direct.c > >>> +++ b/kernel/dma/direct.c > >>> @@ -374,9 +374,11 @@ void dma_direct_unmap_sg(struct device *dev, struct > >>> scatterlist *sgl, > >>>struct scat

Re: [PATCH] dma: mark unmapped DMA scatter/gather invalid

2021-01-11 Thread Marc Orr via iommu
> On 2021-01-11 15:43, Marc Orr wrote: minus sta...@vger.kernel.org, per gregkh@'s email. > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > index 0a4881e59aa7..3d9b17fe5771 100644 > > --- a/kernel/dma/direct.c > > +++ b/kernel/dma/direct.c > > @@ -374,9 +374,11 @@ void dma_direct_unm

[PATCH] dma: mark unmapped DMA scatter/gather invalid

2021-01-11 Thread Marc Orr via iommu
This patch updates dma_direct_unmap_sg() to mark each scatter/gather entry invalid, after it's unmapped. This fixes two issues: 1. It makes the unmapping code able to tolerate a double unmap. 2. It prevents the NVMe driver from erroneously treating an unmapped DMA address as mapped. The bug that