Re: [PATCH v9 5/8] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-06-26 Thread Leo Yan
eep bisection), it's good to introduce function declaration and definition in one patch. With this fixing, this patch looks good to me: Reviewed-by: Leo Yan > + > +#endif > -- > 2.24.0 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v9 4/8] perf tool: arm: Refactor event list iteration in auxtrace_record__init()

2022-06-26 Thread Leo Yan
by: Qi Liu > Signed-off-by: Yicong Yang Reviewed-by: Leo Yan > --- > tools/perf/arch/arm/util/auxtrace.c | 53 ++--- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git a/tools/perf/arch/arm/util/auxtrace.c > b/tools/perf/

Re: [PATCH v7 5/7] perf tool: Add support for HiSilicon PCIe Tune and Trace device driver

2022-04-30 Thread Leo Yan
On Thu, Apr 07, 2022 at 08:58:39PM +0800, Yicong Yang via iommu wrote: > From: Qi Liu > > 'perf record' and 'perf report --dump-raw-trace' supported in this > patch. > > Example usage: > > Output will contain raw PTT data and its textual representation, such > as: > > 0 0 0x5810 [0x30]: PERF_R

Re: [PATCH v7 2/7] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

2022-04-29 Thread Leo Yan
On Thu, Apr 07, 2022 at 08:58:36PM +0800, Yicong Yang via iommu wrote: > HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex integrated > Endpoint(RCiEP) device, providing the capability to dynamically monitor and > tune the PCIe traffic, and trace the TLP headers. > > Add the driver

Re: [PATCH v2 3/3] perf/smmuv3: Synthesize IIDR from CoreSight ID registers

2021-12-07 Thread Leo Yan
On Tue, Dec 07, 2021 at 02:00:35PM +, John Garry wrote: > On 07/12/2021 13:59, Leo Yan wrote: > > > Whether other implementers might retroactively define "equivalent" IIDR > > > values for their existing implementations in a way we could potentially > > &

Re: [PATCH v2 3/3] perf/smmuv3: Synthesize IIDR from CoreSight ID registers

2021-12-07 Thread Leo Yan
On Tue, Dec 07, 2021 at 01:46:49PM +, Robin Murphy wrote: [...] > >[ 28.854767] arm-smmu-v3-pmcg arm-smmu-v3-pmcg.15.auto: iidr=0x0 > > > > Please confirm if this is expected or not? I think this might > > introduce difficulty for John for the PMU event alias patches, which > > is dep

Re: [PATCH v2 3/3] perf/smmuv3: Synthesize IIDR from CoreSight ID registers

2021-12-07 Thread Leo Yan
On Tue, Dec 07, 2021 at 12:48:13PM +, Robin Murphy wrote: > On 2021-12-07 12:28, John Garry via iommu wrote: > > On 07/12/2021 12:04, Robin Murphy wrote: > > > > > > > > > So is there some userspace part to go with this now? > > > > > > FWIW I've not looked into it - is it just a case of some