Re: [PATCH v2 01/10] iommu/ipmmu-vmsa: Refactor micro-TLB lookup

2014-07-14 Thread Khiem Nguyen
Hi Laurent, On 7/14/2014 6:01 PM, Laurent Pinchart wrote: > On Monday 14 July 2014 09:19:23 Khiem Nguyen wrote: >> On 7/10/2014 7:37 PM, Laurent Pinchart wrote: >>> On Thursday 10 July 2014 09:03:26 Khiem Nguyen wrote: >>>> On 5/15/2014 7:40 PM, Laurent Pinchart wr

Re: [PATCH v2 01/10] iommu/ipmmu-vmsa: Refactor micro-TLB lookup

2014-07-13 Thread Khiem Nguyen
Hi Laurent, On 7/10/2014 7:37 PM, Laurent Pinchart wrote: > On Thursday 10 July 2014 09:03:26 Khiem Nguyen wrote: >> On 5/15/2014 7:40 PM, Laurent Pinchart wrote: >>> Cache the micro-TLB number in archdata allocated in the .add_device >>> handler instead of lookin

Re: [PATCH v2 01/10] iommu/ipmmu-vmsa: Refactor micro-TLB lookup

2014-07-09 Thread Khiem Nguyen
mmu; > + archdata->utlb = utlb; [snip] I have one question for ipmmu_add_device(). In my understanding, your code will find utlb for device base on device name. For any device, it will /only/ return utlb number of first match. How about the case that a device name connected with more

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-07-09 Thread Khiem Nguyen
Hi Laurent, Thanks for your explanation. I'm fine with current situation. I have also checked other drivers and they did the same. As you said, let's improve this driver when the time comes. Thanks. Best regards, KHIEM Nguyen On 6/4/2014 2:39 AM, Laurent Pinchart wrote: > Hi, &g

Re: [PATCH v3] iommu: Add driver for Renesas VMSA-compatible IPMMU

2014-06-02 Thread Khiem Nguyen
_bus_type, &ipmmu_ops); + if (ret < 0) + return ret; In this case, if error occurs, -EBUSY is returned. It's easier for troubleshooting the issue. How do you think ? Best regards, KHIEM Nguyen On 4/2/2014 7:47 PM, Laurent Pinchart wrote: Signed-off-by: Laurent Pinc