Re: [PATCH 14/18] drm/exynos: Consolidate IOMMU mapping code

2020-09-20 Thread Inki Dae
> --- > This is a cheeky revert of 07dc3678bacc ("drm/exynos: Fix cleanup of > IOMMU related objects"), plus removal of the remaining arm_iommu_* > references on top. Thanks for cleanup. Acked-by: Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos5433

Re: [PATCH v7 07/36] drm: exynos: use common helper for a scatterlist contiguity check

2020-07-13 Thread Inki Dae
20. 6. 19. 오후 7:36에 Marek Szyprowski 이(가) 쓴 글: > Use common helper for checking the contiguity of the imported dma-buf. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_gem.c | 23 +++ &g

Re: [PATCH v7 08/36] drm: exynos: fix common struct sg_table related issues

2020-07-13 Thread Inki Dae
ways, hides references to the > nents and orig_nents entries, making the code robust, easier to follow > and copy/paste safe. > > Signed-off-by: Marek Szyprowski Acked-by : Inki Dae Thanks, Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 +- > 1 file

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-15 Thread Inki Dae
On 2015년 06월 12일 22:00, Marek Szyprowski wrote: > Hello, > > On 2015-06-12 14:10, Inki Dae wrote: >> On 2015년 06월 12일 18:07, Marek Szyprowski wrote: >>> One should not do any assumptions on the stare of the fimd hardware >>> during driver initialization, so to pr

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
On 2015년 06월 12일 21:10, Inki Dae wrote: > On 2015년 06월 12일 18:07, Marek Szyprowski wrote: >> One should not do any assumptions on the stare of the fimd hardware >> during driver initialization, so to properly reset fimd before enabling >> IOMMU, one should ensure that all pow

Re: [PATCH v3 (alternative) 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
Exynos guys, could you guys check the same issues also? If you give some helps to us, we'd be glad. Thanks, Inki Dae > > v2: > - rebased onto latest exynos-drm-next branch with atomic mode setting > patches applied. > > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 130

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-12 Thread Inki Dae
On 2015년 06월 12일 18:05, Marek Szyprowski wrote: > Hello, > > On 2015-06-11 17:04, Inki Dae wrote: >> On 2015년 06월 03일 17:26, Marek Szyprowski wrote: >>> One should not do any assumptions on the stare of the fimd hardware >>> during driver initialization, so to pr

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-11 Thread Inki Dae
of fimd_enable_vblank function because ctx object has exynos_crtc object. i.e., struct exynos_drm_crtc_ops *ops = ctx->crtc->ops; ... if (ops->enable_vblank) ops->enable_vblank(ctx->crtc); .

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-04 Thread Inki Dae
On 2015년 06월 04일 22:08, Inki Dae wrote: > Hi Marek, > > On 2015년 06월 03일 17:26, Marek Szyprowski wrote: >> One should not do any assumptions on the stare of the fimd hardware >> during driver initialization, so to properly reset fimd before enabling >> IOMMU, one s

Re: [PATCH v2 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-04 Thread Inki Dae
t;; clocks = <&clock CLK_SMMU_FIMD0>, <&clock CLK_FIMD0>; power-domains = <&pd_lcd0>; #iommu-cells = <0>; }; in exynos4412-trats2.dts file: fimd@11c0 { status = "okay"; iommu-reserved-mapping = &

Re: [PATCH 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-02 Thread Inki Dae
Hi Marek, I have merged atomic patch series. Can you re-base your patch series on top of exynos-drm-next? Thanks, Inki Dae On 2015년 06월 01일 20:15, Marek Szyprowski wrote: > One should not do any assumptions on the stare of the fimd hardware > during driver initialization, so to properly

Re: [PATCH 12/29] DRM: Exynos: fix window clear code

2014-09-01 Thread Inki Dae
*/ > - if (ch_enabled) > + if (ch_enabled) { > + state = ctx->suspended; int state = ctx->suspended; > + ctx->suspended = 0; > fimd_wait_for_vblank(mgr); > + ctx->suspended = state; > + } > } > > stat

Re: [PATCH] iommu/exynos: Remove driver

2014-02-06 Thread Inki Dae
;s obvious that nobody cares about it, so let's remove it. Wait, we are going to fix up this module. It seems that KyoungHo, original author, is busy with some works related to product. we can care about it if KyoungHo cannot afford to care for the time being. Thanks, Inki Dae > > Signed-o

Re: [PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-14 Thread InKi Dae
> +static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) > +{ > +       /* SYSMMU is in blocked when interrupt occurred. */ > +       struct sysmmu_drvdata *data = dev_id; > +       struct resource *irqres; > +       struct platform_device *pdev; > +       enum EXYNOS_SYSMMU_INTERRUPT_TYPE it