Re: [PATCH v5 4/5] iommu/omap: adapt to runtime pm

2012-11-21 Thread Felipe Contreras
it more properly, with __pm_runtime_disable(dev, false). Cheers. -- Felipe Contreras ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-17 Thread Felipe Contreras
On Thu, Oct 18, 2012 at 1:51 AM, Omar Ramirez Luna wrote: > On 15 October 2012 22:23, Felipe Contreras wrote: >>> On probe this patch does pm_runtime_enable, however this doesn't mean >>> the device is turned ON or resumed or kept ON all the time. >> >

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-15 Thread Felipe Contreras
to the TRM. Take a look at 12.3 Camera ISP Integration >> Fig 12-50. > > What I meant is that, you are using the CM_ICLKEN to enable a clock > named "cam_fck" which has l3_ick as a parent. And that is not > consistent with what that register is meant to do,

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-12 Thread Felipe Contreras
On Fri, Oct 12, 2012 at 7:46 PM, Omar Ramirez Luna wrote: > On 12 October 2012 02:48, Felipe Contreras wrote: >> I already made most of these comments, but here they go again. > > I replied to all, but here it goes again: Mostly, but not all :) >>> @@ -142,11 +142,10 @@

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-12 Thread Felipe Contreras
_36XX), + CLK(NULL, "cam_fck", &cam_fck, CK_34XX | CK_36XX), CLK(NULL, "cam_ick", &cam_ick, CK_34XX | CK_36XX), CLK(NULL, "csi2_96m_fck", &csi2_96m_fck, CK_34XX | CK_36XX), CLK(NULL, "usbhost_120m_fck", &usbhost_120m_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), Cheers. -- Felipe Contreras ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu