Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Mon, Nov 18, 2024 at 11:12 AM James Bottomley wrote: > > On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: > > Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should > > exclusively use TPM2_PCR_Event. I would expect that passing, say, > > the entire kernel image to TPM2

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread James Bottomley
On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: > Linux should not use TPM2_PCR_Extend *at all*.  Instead, Linux should > exclusively use TPM2_PCR_Event.  I would expect that passing, say, > the entire kernel image to TPM2_PCR_Event would be a big mistake, so > instead Linux should hash t

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Mon, Nov 18, 2024 at 10:43 AM Andy Lutomirski wrote: > > Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should > exclusively use TPM2_PCR_Event. I would expect that passing, say, the > entire kernel image to TPM2_PCR_Event would be a big mistake, so > instead Linux should hash

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Thu, Nov 14, 2024 at 5:17 PM Daniel P. Smith wrote: > > On 11/2/24 12:04, James Bottomley wrote: > > On Sat, 2024-11-02 at 10:53 -0400, Daniel P. Smith wrote: > >> Hi Luto, > >> > >> My apologies, I missed this response and the active on v11 cause me > >> to > >> get an inquiry why I hadn't res