Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-18 Thread Viresh Kumar
On 18-01-22, 19:50, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually describes

Re: [PATCH] dt-bindings: Improve phandle-array schemas

2022-01-18 Thread Krzysztof Kozlowski
On 19/01/2022 02:50, Rob Herring wrote: > The 'phandle-array' type is a bit ambiguous. It can be either just an > array of phandles or an array of phandles plus args. Many schemas for > phandle-array properties aren't clear in the schema which case applies > though the description usually describes

[PATCH v2] iommu/intel: Fix potential memory leak in intel_setup_irq_remapping

2022-01-18 Thread Guoqing Jiang
After commit e3beca48a45b ("irqdomain/treewide: Keep firmware node unconditionally allocated"). For tear down scenario, fn is only freed after fail to allocate ir_domain, though it also should be freed in case dmar_enable_qi returns error. Besides free fn, irq_domain and ir_msi_domain need to be r

[PATCH] dt-bindings: Improve phandle-array schemas

2022-01-18 Thread Rob Herring
The 'phandle-array' type is a bit ambiguous. It can be either just an array of phandles or an array of phandles plus args. Many schemas for phandle-array properties aren't clear in the schema which case applies though the description usually describes it. The array of phandles case boils down to n

iommu/amd: bug report: page table memory leak

2022-01-18 Thread Daniel Jordan
Hi, I've hit a memory leak while testing qemu v6.2.0-rc4 on an AMD EPYC 7J13 (Milan) system. Starting an almost 1T guest, the leak is over 1.5G per qemu invocation. I haven't checked whether the leak is proportional to guest size. It happens with a vfio device, and only when the guest's memory

Re: nvme: IO_PAGE_FAULT logged with Intel SSDPEKKF512G8

2022-01-18 Thread Paul Menzel
Dear Keith, Thank you for your quick response. Am 18.01.22 um 17:53 schrieb Keith Busch: On Tue, Jan 18, 2022 at 03:32:45PM +0100, Paul Menzel wrote: On a Dell OptiPlex 5055 with an Intel SSDPEKKF512G8, Linux 5.10.82 reported an IO_PAGE_FAULT error. This is the first and only time this has h

Re: nvme: IO_PAGE_FAULT logged with Intel SSDPEKKF512G8

2022-01-18 Thread Keith Busch
On Tue, Jan 18, 2022 at 03:32:45PM +0100, Paul Menzel wrote: > On a Dell OptiPlex 5055 with an Intel SSDPEKKF512G8, Linux 5.10.82 reported > an IO_PAGE_FAULT error. This is the first and only time this has happened. > > $ dmesg --level=err > [4.194306] nvme :01:00.0: AMD-Vi: Event

Re: [PATCH v3] iommu: Fix potential use-after-free during probe

2022-01-18 Thread Vijayanand Jitta
On 1/18/2022 7:19 PM, Robin Murphy wrote: > On 2022-01-12 13:13, Vijayanand Jitta wrote: >> Kasan has reported the following use after free on dev->iommu. >> when a device probe fails and it is in process of freeing dev->iommu >> in dev_iommu_free function, a deferred_probe_work_func runs in para

nvme: IO_PAGE_FAULT logged with Intel SSDPEKKF512G8

2022-01-18 Thread Paul Menzel
Dear Linux folks, On a Dell OptiPlex 5055 with an Intel SSDPEKKF512G8, Linux 5.10.82 reported an IO_PAGE_FAULT error. This is the first and only time this has happened. $ dmesg --level=err [4.194306] nvme :01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000c address=0x

Re: [PATCH v3] iommu: Fix potential use-after-free during probe

2022-01-18 Thread Robin Murphy
On 2022-01-12 13:13, Vijayanand Jitta wrote: Kasan has reported the following use after free on dev->iommu. when a device probe fails and it is in process of freeing dev->iommu in dev_iommu_free function, a deferred_probe_work_func runs in parallel and tries to access dev->iommu->fwspec in of_iom