Re: [PATCH v7 1/9] iommu: Introduce a union to struct iommu_resv_region

2021-10-08 Thread Jon Nettleton
On Fri, Oct 8, 2021 at 2:14 PM Robin Murphy wrote: > > On 2021-08-05 09:07, Shameer Kolothum wrote: > > A union is introduced to struct iommu_resv_region to hold > > any firmware specific data. This is in preparation to add > > support for IORT RMR reserve regions and the union now holds > > the R

Re: [PATCH 1/5] iova: Move fast alloc size roundup into alloc_iova_fast()

2021-10-08 Thread Yongji Xie
On Sat, Oct 9, 2021 at 12:17 AM John Garry wrote: > > On 04/10/2021 12:31, Will Deacon wrote: > > On Fri, Sep 24, 2021 at 06:01:53PM +0800, John Garry wrote: > >> It really is a property of the IOVA rcache code that we need to alloc a > >> power-of-2 size, so relocate the functionality to resize i

Re: [PATCH 1/5] iova: Move fast alloc size roundup into alloc_iova_fast()

2021-10-08 Thread John Garry
On 04/10/2021 12:31, Will Deacon wrote: On Fri, Sep 24, 2021 at 06:01:53PM +0800, John Garry wrote: It really is a property of the IOVA rcache code that we need to alloc a power-of-2 size, so relocate the functionality to resize into alloc_iova_fast(), rather than the callsites. Signed-off-by:

Re: [PATCH v7 9/9] iommu/dma: Reserve any RMR regions associated with a dev

2021-10-08 Thread Robin Murphy
On 2021-08-05 09:07, Shameer Kolothum wrote: Get ACPI IORT RMR regions associated with a dev reserved so that there is a unity mapping for them in SMMU. This feels like most of it belongs in the IORT code rather than iommu-dma (which should save the temporary list copy as well). Robin. Sig

Re: [PATCH v7 3/9] iommu/dma: Introduce generic helper to retrieve RMR info

2021-10-08 Thread Robin Murphy
On 2021-08-05 09:07, Shameer Kolothum wrote: Reserved Memory Regions(RMR) associated with an IOMMU can be described through ACPI IORT tables in systems with devices that require a unity mapping or bypass for those regions. Introduce a generic interface so that IOMMU drivers can retrieve and set

Re: [PATCH v7 2/9] ACPI/IORT: Add support for RMR node parsing

2021-10-08 Thread Robin Murphy
On 2021-08-05 09:07, Shameer Kolothum wrote: Add support for parsing RMR node information from ACPI. Find the associated streamid and smmu node info from the RMR node and populate a linked list with RMR memory descriptors. Signed-off-by: Shameer Kolothum --- drivers/acpi/arm64/iort.c | 134 +

Re: [PATCH v7 1/9] iommu: Introduce a union to struct iommu_resv_region

2021-10-08 Thread Robin Murphy
On 2021-08-05 09:07, Shameer Kolothum wrote: A union is introduced to struct iommu_resv_region to hold any firmware specific data. This is in preparation to add support for IORT RMR reserve regions and the union now holds the RMR specific information. Signed-off-by: Shameer Kolothum --- inclu

Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file

2021-10-08 Thread Lu Baolu
Hi Andy, On 2021/10/7 0:14, Andy Shevchenko wrote: On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: Hi Andy, On 7/30/21 12:35 AM, Andy Shevchenko wrote: Compiler is not happy about hidden declaration of intel_iommu_ops. .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_