Re: [PATCH v2 1/2] iommu/vt-d: convert the return type of first_pte_in_page to bool

2021-10-06 Thread Lu Baolu
On 2021/10/5 23:23, Longpeng(Mike) wrote: first_pte_in_page() returns boolean value, so let's convert its return type to bool. Signed-off-by: Longpeng(Mike) --- include/linux/intel-iommu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/intel-iommu.h b/inclu

Re: [RFC 0/7] Support in-kernel DMA with PASID and SVA

2021-10-06 Thread Barry Song
On Tue, Oct 5, 2021 at 7:21 AM Jason Gunthorpe wrote: > > On Mon, Oct 04, 2021 at 09:40:03AM -0700, Jacob Pan wrote: > > Hi Barry, > > > > On Sat, 2 Oct 2021 01:45:59 +1300, Barry Song <21cn...@gmail.com> wrote: > > > > > > > > > > > I assume KVA mode can avoid this iotlb flush as the device is us

Re: [PATCH v2 11/29] iommu/mediatek: Always pm_runtime_get while tlb flush

2021-10-06 Thread Yong Wu
On Thu, 2021-09-30 at 13:26 +0200, Dafna Hirschfeld wrote: > > On 13.08.21 08:53, Yong Wu wrote: > > Prepare for 2 HWs that sharing pgtable in different power-domains. > > > > The previous SoC don't have PM. Only mt8192 has power-domain, > > and it is display's power-domain which nearly always is

Re: [PATCH v8 09/12] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-10-06 Thread Yong Wu
On Thu, 2021-09-30 at 12:57 +0200, Dafna Hirschfeld wrote: > > On 30.09.21 05:28, Yong Wu wrote: > > Hi Dafna, > > > > Thanks very much for the review. > > > > On Wed, 2021-09-29 at 14:13 +0200, Dafna Hirschfeld wrote: > > > > > > On 29.09.21 03:37, Yong Wu wrote: > > > > MediaTek IOMMU has alr

Re: [RFC 07/20] iommu/iommufd: Add iommufd_[un]bind_device()

2021-10-06 Thread David Gibson
On Fri, Oct 01, 2021 at 09:43:22AM -0300, Jason Gunthorpe wrote: > On Thu, Sep 30, 2021 at 01:10:29PM +1000, David Gibson wrote: > > On Wed, Sep 29, 2021 at 09:24:57AM -0300, Jason Gunthorpe wrote: > > > On Wed, Sep 29, 2021 at 03:25:54PM +1000, David Gibson wrote: > > > > > > > > +struct iommufd_

[PATCH] dma-debug: fix sg checks in debug_dma_map_sg()

2021-10-06 Thread Gerald Schaefer
The following warning occurred sporadically on s390: DMA-API: nvme 0006:00:00.0: device driver maps memory from kernel text or rodata [addr=48cc5e2f] [len=131072] WARNING: CPU: 4 PID: 825 at kernel/dma/debug.c:1083 check_for_illegal_area+0xa8/0x138 It is a false-positive warning, due to

Re: [PATCH v1 1/2] iommu/vt-d: Move intel_iommu_ops to header file

2021-10-06 Thread Andy Shevchenko
On Fri, Jul 30, 2021 at 10:20:08AM +0800, Lu Baolu wrote: > Hi Andy, > > On 7/30/21 12:35 AM, Andy Shevchenko wrote: > > Compiler is not happy about hidden declaration of intel_iommu_ops. > > > > .../drivers/iommu/intel/iommu.c:414:24: warning: symbol 'intel_iommu_ops' > > was not declared. Shou

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Wed, 6 Oct 2021 15:23:36 +0100 Robin Murphy wrote: > On 2021-10-06 14:10, Gerald Schaefer wrote: > > On Fri, 1 Oct 2021 14:52:56 +0200 > > Gerald Schaefer wrote: > > > >> On Thu, 30 Sep 2021 15:37:33 +0200 > >> Karsten Graul wrote: > >> > >>> On 14/09/2021 17:45, Ioana Ciornei wrote: >

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Robin Murphy
On 2021-10-06 14:10, Gerald Schaefer wrote: On Fri, 1 Oct 2021 14:52:56 +0200 Gerald Schaefer wrote: On Thu, 30 Sep 2021 15:37:33 +0200 Karsten Graul wrote: On 14/09/2021 17:45, Ioana Ciornei wrote: On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: +DPAA2, netdev maintainers

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Wed, 6 Oct 2021 15:10:43 +0200 Gerald Schaefer wrote: > On Fri, 1 Oct 2021 14:52:56 +0200 > Gerald Schaefer wrote: > > > On Thu, 30 Sep 2021 15:37:33 +0200 > > Karsten Graul wrote: > > > > > On 14/09/2021 17:45, Ioana Ciornei wrote: > > > > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy

Re: DPAA2 triggers, [PATCH] dma debug: report -EEXIST errors in add_dma_entry

2021-10-06 Thread Gerald Schaefer
On Fri, 1 Oct 2021 14:52:56 +0200 Gerald Schaefer wrote: > On Thu, 30 Sep 2021 15:37:33 +0200 > Karsten Graul wrote: > > > On 14/09/2021 17:45, Ioana Ciornei wrote: > > > On Wed, Sep 08, 2021 at 10:33:26PM -0500, Jeremy Linton wrote: > > >> +DPAA2, netdev maintainers > > >> Hi, > > >> > > >> On

Re: [PATCH RFC v1 10/11] uapi/virtio-iommu: Add a new request type to send page response

2021-10-06 Thread Jean-Philippe Brucker
On Thu, Sep 30, 2021 at 02:54:05PM +0530, Vivek Kumar Gautam wrote: > > > +struct virtio_iommu_req_page_resp { > > > + struct virtio_iommu_req_headhead; > > > + __le32 domain; > > > > I don't think we need this field, since the fault report doesn't come