Re: [rfc v2 3/6] dma-pool: dynamically expanding atomic pools

2020-04-13 Thread Christoph Hellwig
On Fri, Apr 10, 2020 at 12:37:20PM -0700, David Rientjes wrote: > I'll rely on Christoph to determine whether it makes sense to add some > periodic scavening of the atomic pools, whether that's needed for this to > be merged, or wheter we should enforce some maximum pool size. I don't really see

Re: [rfc v2 4/6] dma-direct: atomic allocations must come from atomic coherent pools

2020-04-13 Thread Christoph Hellwig
> + /* > + * Unencrypted memory must come directly from DMA atomic pools if > + * blocking is not allowed. > + */ > + if (IS_ENABLED(CONFIG_DMA_COHERENT_POOL) && > + force_dma_unencrypted(dev) && !gfpflags_allow_blocking(gfp)) { > + ret = dma_alloc_from_po

Re: [rfc v2 1/6] dma-remap: separate DMA atomic pools from direct remap code

2020-04-13 Thread Christoph Hellwig
On Wed, Apr 08, 2020 at 02:21:03PM -0700, David Rientjes wrote: > +++ b/kernel/dma/pool.c > @@ -0,0 +1,125 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2012 ARM Ltd. > + * Copyright (c) 2014 The Linux Foundation > + * Copyright (C) 2020 Google LLC Of the old copyrights the L

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-04-13 Thread Christoph Hellwig
On Tue, Apr 14, 2020 at 04:21:27PM +1000, Alexey Kardashevskiy wrote: > > Good points, I'll post revised version when you post your v3 of this. > > > > Any plans on posting v3 of this? Thanks, Just back from a long weekend. I'll take a stab at it soon. _

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-04-13 Thread Alexey Kardashevskiy
On 07/04/2020 20:12, Alexey Kardashevskiy wrote: > > > On 07/04/2020 03:17, Christoph Hellwig wrote: >> On Mon, Apr 06, 2020 at 11:25:09PM +1000, Alexey Kardashevskiy wrote: > Do you see any serious problem with this approach? Thanks! Do you have a link to the whole branch? The

Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities

2020-04-13 Thread Jacob Pan
Hi Alex, Thanks a lot for the feedback, my comments inline. On Mon, 13 Apr 2020 16:21:29 -0600 Alex Williamson wrote: > On Mon, 13 Apr 2020 13:41:57 -0700 > Jacob Pan wrote: > > > Hi All, > > > > Just a gentle reminder, any feedback on the options I listed below? > > New ideas will be even be

RE: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Tian, Kevin
> From: Alex Williamson > Sent: Tuesday, April 14, 2020 11:29 AM > > On Tue, 14 Apr 2020 02:40:58 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson > > > Sent: Tuesday, April 14, 2020 3:21 AM > > > > > > On Mon, 13 Apr 2020 08:05:33 + > > > "Tian, Kevin" wrote: > > > > > > > > Fr

Re: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Alex Williamson
On Tue, 14 Apr 2020 02:40:58 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 14, 2020 3:21 AM > > > > On Mon, 13 Apr 2020 08:05:33 + > > "Tian, Kevin" wrote: > > > > > > From: Tian, Kevin > > > > Sent: Monday, April 13, 2020 3:55 PM > > > > > > > > > From

RE: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Tian, Kevin
> From: Alex Williamson > Sent: Tuesday, April 14, 2020 3:21 AM > > On Mon, 13 Apr 2020 08:05:33 + > "Tian, Kevin" wrote: > > > > From: Tian, Kevin > > > Sent: Monday, April 13, 2020 3:55 PM > > > > > > > From: Raj, Ashok > > > > Sent: Monday, April 13, 2020 11:11 AM > > > > > > > > On Wed

Re: [RFC PATCH] iommu/amd: fix a race in fetch_pte()

2020-04-13 Thread Qian Cai
> On Apr 8, 2020, at 10:19 AM, Joerg Roedel wrote: > > Hi Qian, > > On Tue, Apr 07, 2020 at 11:36:05AM -0400, Qian Cai wrote: >> After further testing, the change along is insufficient. What I am chasing >> right >> now is the swap device will go offline after heavy memory pressure below. The

Re: [PATCH 2/2] iommu/arm-smmu: Allow client devices to select direct mapping

2020-04-13 Thread Evan Green
On Wed, Jan 22, 2020 at 3:48 AM Sai Prakash Ranjan wrote: > > From: Jordan Crouse > > Some client devices want to directly map the IOMMU themselves instead > of using the DMA domain. Allow those devices to opt in to direct > mapping by way of a list of compatible strings. > > Signed-off-by: Jorda

Re: [PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-13 Thread kbuild test robot
Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on sunxi/sunxi/for-next tegra/for-next linus/master v5.7-rc1 next-20200413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-13 Thread kbuild test robot
Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on linus/master v5.7-rc1 next-20200413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use

Re: [PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-13 Thread kbuild test robot
Hi Hadar, Thank you for the patch! Yet something to improve: [auto build test ERROR on stm32/stm32-next] [also build test ERROR on sunxi/sunxi/for-next tegra/for-next linus/master v5.7-rc1 next-20200413] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities

2020-04-13 Thread Alex Williamson
On Mon, 13 Apr 2020 13:41:57 -0700 Jacob Pan wrote: > Hi All, > > Just a gentle reminder, any feedback on the options I listed below? New > ideas will be even better. > > Christoph, does the explanation make sense to you? We do have the > capability/flag based scheme for IOMMU API extension, th

Re: [RFC PATCH 11/34] iommu: Split off default domain allocation from group assignment

2020-04-13 Thread Derrick, Jonathan
Hi Joerg, On Tue, 2020-04-07 at 20:37 +0200, Joerg Roedel wrote: > From: Joerg Roedel > > When a bus is initialized with iommu-ops, all devices on the bus are > scanned and iommu-groups are allocated for them, and each groups will > also get a default domain allocated. > > Until now this happen

Re: [PATCH 05/10] iommu/ioasid: Create an IOASID set for host SVA use

2020-04-13 Thread Jacob Pan
Hi Jean, Sorry for the delay, I have to do some research based on your feedback. I also plan to document this in the next version. On Tue, 7 Apr 2020 13:01:46 +0200 Jean-Philippe Brucker wrote: > On Mon, Apr 06, 2020 at 08:33:53AM -0700, Jacob Pan wrote: > > Hi Jean, > > > > On Wed, 1 Apr 202

Re: [PATCH v2 1/3] iommu/uapi: Define uapi version and capabilities

2020-04-13 Thread Jacob Pan
Hi All, Just a gentle reminder, any feedback on the options I listed below? New ideas will be even better. Christoph, does the explanation make sense to you? We do have the capability/flag based scheme for IOMMU API extension, the version is mainly used for size lookup. Compatibility checking is

Re: [PATCH 25/28] mm: remove vmalloc_user_node_flags

2020-04-13 Thread Johannes Weiner
On Thu, Apr 09, 2020 at 03:25:03PM -0700, Andrii Nakryiko wrote: > cc Johannes who suggested this API call originally I forgot why we did it this way - probably just cruft begetting more cruft. Either way, Christoph's cleanup makes this look a lot better. > On Wed, Apr 8, 2020 at 5:03 AM Christop

Re: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Alex Williamson
On Thu, 9 Apr 2020 09:35:33 +0200 Jean-Philippe Brucker wrote: > On Wed, Apr 08, 2020 at 10:19:40AM -0600, Alex Williamson wrote: > > On Tue, 7 Apr 2020 21:00:21 -0700 > > "Raj, Ashok" wrote: > > > > > Hi Alex > > > > > > + Bjorn > > > > + Don > > > > > FWIW I can't understand why PCI

Re: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Alex Williamson
On Mon, 13 Apr 2020 08:05:33 + "Tian, Kevin" wrote: > > From: Tian, Kevin > > Sent: Monday, April 13, 2020 3:55 PM > > > > > From: Raj, Ashok > > > Sent: Monday, April 13, 2020 11:11 AM > > > > > > On Wed, Apr 08, 2020 at 10:19:40AM -0600, Alex Williamson wrote: > > > > On Tue, 7 Apr 20

Re: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Alex Williamson
On Sun, 12 Apr 2020 20:29:31 -0700 "Raj, Ashok" wrote: > Hi Alex > > Going through the PCIe Spec, there seems a lot of such capabilities > that are different between PF and VF. Some that make sense > and some don't. > > > On Sun, Apr 12, 2020 at 08:10:43PM -0700, Raj, Ashok wrote: > > > > >

Re: [PATCH 1/1] iommu/vt-d: use DMA domain for real DMA devices and subdevices

2020-04-13 Thread Derrick, Jonathan
On Sun, 2020-04-12 at 11:50 +0800, Daniel Drake wrote: > Hi Jon, > > Thanks for picking this up. Apologies for my absence here - I wasn't > able to work on this recently, but I'm back again now. > > On Fri, Apr 10, 2020 at 3:32 AM Jon Derrick > wrote: > > This becomes problematic if the real DM

Re: [PATCH 1/1] iommu/vt-d: use DMA domain for real DMA devices and subdevices

2020-04-13 Thread Derrick, Jonathan
On Mon, 2020-04-13 at 10:48 +0800, Lu Baolu wrote: > Hi Daniel, > > On 2020/4/13 10:25, Daniel Drake wrote: > > On Fri, Apr 10, 2020 at 9:22 AM Lu Baolu wrote: > > > This is caused by the fragile private domain implementation. We are in > > > process of removing it by enhancing the iommu subsyste

Re: [PATCH 0/2] iommu/arm-smmu: Allow client devices to select direct mapping

2020-04-13 Thread Jordan Crouse
On Thu, Apr 09, 2020 at 04:31:24PM -0700, Matthias Kaehlcke wrote: > On Tue, Feb 04, 2020 at 11:12:17PM +0530, Sai Prakash Ranjan wrote: > > Hello Robin, Will > > > > On 2020-01-22 17:18, Sai Prakash Ranjan wrote: > > > This series allows drm devices to set a default identity > > > mapping using i

[PATCH] of_device: removed #include that caused a recursion in included headers

2020-04-13 Thread Hadar Gat
Both of_platform.h and of_device.h were included each other. In of_device.h, removed unneeded #include to of_platform.h and added include to of_platform.h in the files that needs it. Signed-off-by: Hadar Gat --- drivers/base/platform.c | 1 + drivers/bus/vexpress-config

Re: [PATCH v2 1/3] iommu/virtio: Add topology description to virtio-iommu config space

2020-04-13 Thread Michael S. Tsirkin
On Fri, Feb 28, 2020 at 06:25:36PM +0100, Jean-Philippe Brucker wrote: > diff --git a/include/uapi/linux/virtio_iommu.h > b/include/uapi/linux/virtio_iommu.h > index 237e36a280cb..ec57d215086a 100644 > --- a/include/uapi/linux/virtio_iommu.h > +++ b/include/uapi/linux/virtio_iommu.h > @@ -16,6 +16

[PATCH] dt-bndings: iommu: renesas, ipmmu-vmsa: convert to json-schema

2020-04-13 Thread Yoshihiro Shimoda
Convert Renesas VMSA-Compatible IOMMU bindings documentation to json-schema. Signed-off-by: Yoshihiro Shimoda --- .../bindings/iommu/renesas,ipmmu-vmsa.txt | 73 -- .../bindings/iommu/renesas,ipmmu-vmsa.yaml | 90 ++ 2 files changed, 90 insert

RE: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Monday, April 13, 2020 3:55 PM > > > From: Raj, Ashok > > Sent: Monday, April 13, 2020 11:11 AM > > > > On Wed, Apr 08, 2020 at 10:19:40AM -0600, Alex Williamson wrote: > > > On Tue, 7 Apr 2020 21:00:21 -0700 > > > "Raj, Ashok" wrote: > > > > > > > Hi Alex > > > > > >

RE: [PATCH v1 2/2] vfio/pci: Emulate PASID/PRI capability for VFs

2020-04-13 Thread Tian, Kevin
> From: Raj, Ashok > Sent: Monday, April 13, 2020 11:11 AM > > On Wed, Apr 08, 2020 at 10:19:40AM -0600, Alex Williamson wrote: > > On Tue, 7 Apr 2020 21:00:21 -0700 > > "Raj, Ashok" wrote: > > > > > Hi Alex > > > > > > + Bjorn > > > > + Don > > > > > FWIW I can't understand why PCI SIG went di