On 2/8/2019 8:02 PM, sathyanarayanan kuppuswamy wrote:
This means that you should probably have some kind of version check
here.
There is no version field in ATS v1.0 spec. Also, If I follow the
history log in PCI spec, I think ATS if first added at v1.2. Please
correct me if I am wrong.
v1
On 2/7/19 5:58 PM, Sinan Kaya wrote:
On 2/7/2019 5:16 PM, sathyanarayanan kuppuswamy wrote:
If I remember this right, aligned request is only supported on ATS v1.1
but not supported on v1.0.
Its added in v1.1.
This means that you should probably have some kind of version check
here.
Ther
The pull request you sent on Fri, 8 Feb 2019 17:49:43 +0100:
> git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git
> tags/iommu-fixes-v5.0-rc5
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/2e277fa0893936bb4ab8432828f5d422a9ed0a7f
Thank you!
--
Deet-doot-d
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/intel-iommu.c | 54 +++
1 file changed, 24 insertions(+), 30 deletion
From: Bjorn Helgaas
The "Domain 0 is reserved, so dont process it" comment suggests that a NULL
pointer corresponds to domain 0. I don't think that's true, and in any
case, every caller supplies a non-NULL domain pointer that has already been
dereferenced, so the test is unnecessary.
Remove the
From: Bjorn Helgaas
A local variable initialization is a hint that the variable will be used in
an unusual way. If the initialization is unnecessary, that hint becomes a
distraction.
Remove unnecessary initializations. No functional change intended.
Signed-off-by: Bjorn Helgaas
---
drivers/
From: Bjorn Helgaas
Simplify control flow by returning immediately when we know the result.
No functional change intended.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/intel-iommu.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/driver
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
Signed-off-by: Bjorn Helgaas
---
drivers/iommu/amd_iommu.c | 25 +++--
drivers/iommu/amd_iommu_init.c | 20 ++--
From: Bjorn Helgaas
domain_remove_dev_info() takes a struct dmar_domain * argument, but doesn't
use it. Remove it. No functional change intended.
The last use of this argument was removed by 127c761598f7 ("iommu/vt-d:
Pass device_domain_info to __dmar_remove_one_dev_info").
Signed-off-by: Bjo
I've had these minor iommu cleanups lying around for a while, but the ugly
dmesg logs from [1] prompted me to finally post them. Take what you like,
ignore the rest, and tell me so I can clear out my queue of old stuff.
These fix no actual bugs.
[1]
https://lore.kernel.org/linux-pci/1547649064-
From: Bjorn Helgaas
Use dev_printk() when possible so the IOMMU messages are more consistent
with other messages related to the device.
E.g., I think these messages related to surprise hotplug:
pciehp :80:10.0:pcie004: Slot(36): Link Down
iommu: Removing device :87:00.0 from group 1
Hi Robin,
On Fri, Feb 8, 2019 at 6:55 PM Robin Murphy wrote:
> On 08/02/2019 16:40, Joerg Roedel wrote:
> > On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote:
> >> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> >> index 8ac10af17c0043a3..d62487d024559620 100644
> >> --- a/d
On 08/02/2019 16:40, Joerg Roedel wrote:
Hi Geert,
On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote:
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 8ac10af17c0043a3..d62487d024559620 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -968,9 +968,9 @@ static vo
Hi Linus,
The following changes since commit 9825bd94e3a2baae1f4874767ae3a7d4c049720e:
iommu/amd: Fix IOMMU page flush when detach device from a domain (2019-01-24
15:24:49 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git
tags/iom
Hi Geert,
On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote:
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 8ac10af17c0043a3..d62487d024559620 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -968,9 +968,9 @@ static void __device_release_driver(struct
On Fri, Feb 08, 2019 at 02:04:38PM +, Tom Murphy wrote:
> This variable is useless.
>
> ---
> drivers/iommu/dma-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
A similar change is already in the iommu tree[1].
Joerg
[1]
https://git.kernel.org/pub/scm/linux/kernel
On Thu, Feb 07, lantianyu1...@gmail.com wrote:
> +++ b/drivers/iommu/Kconfig
> +config HYPERV_IOMMU
> + bool "Hyper-V x2APIC IRQ Handling"
> + depends on HYPERV
> + select IOMMU_API
> + help
Consider adding 'default HYPERV' like some other drivers already do it.
Olaf
signature
---
include/linux/iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index a1d28f42cb77..bb4bf1269e5d 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -167,7 +167,7 @@ struct iommu_resv_region {
* @detach_dev
This variable is useless.
---
drivers/iommu/dma-iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
index 8e04b0603a4a..eff301d5e496 100644
--- a/drivers/iommu/dma-iommu.c
+++ b/drivers/iommu/dma-iommu.c
@@ -291,7 +29
On 07/02/2019 19:36, Geert Uytterhoeven wrote:
When unbinding the (IOMMU-enabled) R-Car SATA device on Salvator-XS
(R-Car H3 ES2.0), in preparation of rebinding against vfio-platform for
device pass-through for virtualization:
echo ee30.sata > /sys/bus/platform/drivers/sata_rcar/unbind
OK, I will test it.
— Christian
Sent from my iPhone
> On 8. Feb 2019, at 10:18, Christoph Hellwig wrote:
>
>> On Fri, Feb 08, 2019 at 10:01:46AM +0100, Christian Zigotzky wrote:
>> Hi Christoph,
>>
>> Your new patch fixes the problems with the P.A. Semi Ethernet! :-)
>
> Thanks a lot once ag
On Thu, Feb 7, 2019 at 8:42 PM Geert Uytterhoeven
wrote:
>
> When unbinding the (IOMMU-enabled) R-Car SATA device on Salvator-XS
> (R-Car H3 ES2.0), in preparation of rebinding against vfio-platform for
> device pass-through for virtualization:
>
> echo ee30.sata > /sys/bus/platform/driver
On Fri, Feb 08, 2019 at 10:01:46AM +0100, Christian Zigotzky wrote:
> Hi Christoph,
>
> Your new patch fixes the problems with the P.A. Semi Ethernet! :-)
Thanks a lot once again for testing!
Now can you test with this patch and the whole series?
I've updated the powerpc-dma.6 branch to include
Hi Christoph,
Your new patch fixes the problems with the P.A. Semi Ethernet! :-)
Thanks,
Christian
On 07 February 2019 at 05:34AM, Christian Zigotzky wrote:
Hi Christoph,
I also didn’t notice the 32-bit DMA mask in your patch. I have to read your
patches and descriptions carefully in the fu
24 matches
Mail list logo
