Re: [PATCH 1/5] iommu/amd - Add debugfs support

2018-01-26 Thread Borislav Petkov
On Fri, Jan 26, 2018 at 05:52:15PM -0600, Gary R Hook wrote: > Create the basic debugfs functions. Expose a count of IOMMU device > table entries that appear to be in use. > > Signed-off-by: Gary R Hook > --- > drivers/iommu/Kconfig |9 +++ > drivers/iommu/Makefile|

[PATCH 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry

2018-01-26 Thread Gary R Hook
Initially (at boot) the device table values dumped are all of the active devices. Add a devid debugfs file to allow the user to select a single device table entry to dump (active or not). Let any devid value greater than the maximum allowable PCI ID (0x) restore the behavior to that effective

[PATCH 4/5] iommu/amd - Expose the active IOMMU device table entries

2018-01-26 Thread Gary R Hook
Add a debugfs entry to dump the active device table entries from the IOMMU's table. 'Active' is determined by non-default values in the first and second long words of the DTE. Aside from IOMMU devices, this output should list every device reported by lspci. Use arrays to store DTE bit field defini

[PATCH 1/5] iommu/amd - Add debugfs support

2018-01-26 Thread Gary R Hook
Create the basic debugfs functions. Expose a count of IOMMU device table entries that appear to be in use. Signed-off-by: Gary R Hook --- drivers/iommu/Kconfig |9 +++ drivers/iommu/Makefile|2 - drivers/iommu/amd_iommu_debugfs.c | 112 +++

[PATCH 3/5] iommu/amd - Add a README variable for the IOMMU debugfs

2018-01-26 Thread Gary R Hook
Provide help text via a filesystem entry Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu_debugfs.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/iommu/amd_iommu_debugfs.c b/drivers/iommu/amd_iommu_debugfs.c index c449f3a7452c..5066d3976912

[PATCH 0/5] Add debugfs info for the AMD IOMMU

2018-01-26 Thread Gary R Hook
The following series creates a debugfs directory for AMD IOMMUs, constructs a framework for additional entries, an online README, and a method for dumping device table entries. Data is reported in a default concise mode, but a verbose mode is enabled via a filesystem entry. This is the first of th

[PATCH 2/5] iommu/amd - Add a 'verbose' switch for IOMMU debugfs

2018-01-26 Thread Gary R Hook
Enable more descriptive debugfs output via a 'verbose' variable. Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu_debugfs.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu_debugfs.c b/drivers/iommu/amd_iommu_debugfs.c index 18f7

Re: [PATCH] iommu/exynos: Use generic group callback

2018-01-26 Thread Marek Szyprowski
Hi Robin, On 2018-01-24 15:22, Robin Murphy wrote: Since iommu_group_get_for_dev() already tries iommu_group_get() and will not call ops->device_group if the group is already non-NULL, the check in get_device_iommu_group() is always redundant and it reduces to a duplicate of the generic version;

Re: [PATCH v5 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

2018-01-26 Thread JeffyChen
Hi Robin, Thanks for your reply. On 01/24/2018 09:49 PM, Robin Murphy wrote: +Optional properties: +- clocks : A list of master clocks requires for the IOMMU to be accessible s/requires/required/ ok + by the host CPU. The number of clocks depends on the master + block

Re: [PATCH v3] iommu/mediatek: Move attach_device after iommu-group is ready for M4Uv1

2018-01-26 Thread Yong Wu
On Thu, 2018-01-25 at 12:02 +, Robin Murphy wrote: > On 25/01/18 11:14, Yong Wu wrote: > > In the commit 05f80300dc8b, the iommu framework has supposed all the > > iommu drivers have their owner iommu-group, it get rid of the FIXME > > workarounds while the group is NULL. But the flow of Mediat