On Fri, Jan 19, 2018 at 1:55 PM, JeffyChen wrote:
> Hi Tomasz,
>
> Thanks for your reply.
>
>
> On 01/19/2018 11:23 AM, Tomasz Figa wrote:
>>
>> On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen
>> wrote:
>>>
>>> Add clocks in vop iommu nodes, since we are going to control clocks in
>>> rockchip iommu
Hi Tomasz,
Thanks for your reply.
On 01/19/2018 11:23 AM, Tomasz Figa wrote:
On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen wrote:
Add clocks in vop iommu nodes, since we are going to control clocks in
rockchip iommu driver.
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: Non
Hi Jean-Philippe,
On 10/6/2017 9:31 AM, Jean-Philippe Brucker wrote:
> /**
> + * iommu_process_bind_device - Bind a process address space to a device
> + * @dev: the device
> + * @task: the process to bind
> + * @pasid: valid address where the PASID will be stored
> + * @flags: bond properties (I
On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen wrote:
> When the power domain is powered off, the IOMMU cannot be accessed and
> register programming must be deferred until the power domain becomes
> enabled.
>
> Add runtime PM support, and use runtime PM device link from IOMMU to
> master to startup
Hi Jacob,
I've got minor comments after working with this patch, sorry for the
multiple replies
On 17/11/17 18:55, Jacob Pan wrote:
[...]
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 829e9e9..97b7990 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -
On Thu, 18 Jan 2018 10:25:12 +0700
Suravee Suthikulpanit wrote:
> Hi Alex,
>
> On 1/9/18 3:53 AM, Alex Williamson wrote:
> > On Wed, 27 Dec 2017 04:20:34 -0500
> > Suravee Suthikulpanit wrote:
> >> diff --git a/drivers/vfio/vfio_iommu_type1.c
> >> b/drivers/vfio/vfio_iommu_type1.c
> >> index
On Thu, Jan 18, 2018 at 05:56:12PM +0100, David Sterba wrote:
> On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote:
> > Thank you! I shall attempt to debug. Was this with a btrfs root
> > filesystem? I'm most suspicious of those patches right now, since they've
> > received next to n
On Thu, Jan 18, 2018 at 08:48:43AM -0800, Matthew Wilcox wrote:
> Thank you! I shall attempt to debug. Was this with a btrfs root
> filesystem? I'm most suspicious of those patches right now, since they've
> received next to no testing. I'm going to put together a smaller patchset
> which just
On Thu, Jan 18, 2018 at 05:07:50PM +0100, David Sterba wrote:
> On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote:
> > From: Matthew Wilcox
> >
> > This version of the XArray has no known bugs.
>
> I've booted this patchset on 2 boxes, both had random problems during
> boot. On one
On Wed, Jan 17, 2018 at 12:20:24PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> This version of the XArray has no known bugs.
I've booted this patchset on 2 boxes, both had random problems during
boot. On one I was not able to diagnose what went wrong. On the other
one the system boot
Hi Will,
Thanks for your reply.
On 01/18/2018 10:41 PM, Will Deacon wrote:
>
>Makes sense to me, but I'd like to have an OK from Robin or Will (added
>to Cc) before applying this.
I don't think this patch makes a lot of sense in isolation: the SMMU drivers
themselves will likely still probe, a
On Wed, Jan 17, 2018 at 12:21:49PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox
>
> The reada_lock in struct btrfs_device was only initialised, and not
> actually used. That's good because there's another lock also called
> reada_lock in the btrfs_fs_info that was quite heavily used. Rem
On Wed, Jan 17, 2018 at 02:28:08PM +0100, Joerg Roedel wrote:
> On Wed, Jan 03, 2018 at 02:09:20PM +0800, Jeffy Chen wrote:
> > The for_each_matching_node_and_match() would return every matching
> > nodes including unavailable ones.
> >
> > It's pointless to init unavailable IOMMUs, so add a sanit
Hi Robin,
On 01/18/2018 08:27 PM, Robin Murphy wrote:
Is it worth using the clk_bulk_*() APIs for this? At a glance, most of
the code being added here appears to duplicate what those functions
already do (but I'm no clk API expert, for sure).
right, i think it's doable, the clk_bulk APIs are
Hi Robin,
On 01/18/2018 09:23 PM, Robin Murphy wrote:
@@ -837,7 +837,7 @@ static int rk_iommu_attach_device(struct
iommu_domain *domain,
ret = rk_iommu_enable_paging(iommu);
if (ret)
-return ret;
+goto err_disable_stall;
spin_lock_irqsave(&rk_domain->iommus_loc
Hi Robin,
On 01/18/2018 09:09 PM, Robin Murphy wrote:
-#define FORCE_RESET_TIMEOUT100/* ms */
+#define FORCE_RESET_TIMEOUT10/* us */
+#define POLL_TIMEOUT1000/* us */
Nit: the callsites look a bit odd with the combination of POLL_TIMEOUT
and the magic number 100
Hi Joerg,
Thanks for your reply.
On 01/18/2018 08:44 PM, Joerg Roedel wrote:
On Thu, Jan 18, 2018 at 07:52:38PM +0800, Jeffy Chen wrote:
Jeffy Chen (9):
iommu/rockchip: Prohibit unbind and remove
iommu/rockchip: Fix error handling in probe
iommu/rockchip: Request irqs in rk_iommu_prob
On 18/01/18 11:52, Jeffy Chen wrote:
From: Tomasz Figa
Currently if the driver encounters an error while attaching device, it
will leave the IOMMU in an inconsistent state. Even though it shouldn't
really happen in reality, let's just add proper error path to keep
things consistent.
Signed-off
On 18/01/18 11:52, Jeffy Chen wrote:
From: Tomasz Figa
This patch converts the rockchip-iommu driver to use the in-kernel
iopoll helpers to wait for certain status bits to change in registers
instead of an open-coded custom macro.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy Chen
---
Cha
On 18/01/18 11:52, Jeffy Chen wrote:
There would be some masters sharing the same IOMMU device. Put them in
the same iommu group and share the same iommu domain.
Reviewed-by: Robin Murphy
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
Remove rk_iommudata->domain.
Changes
On 18/01/18 11:52, Jeffy Chen wrote:
It's hard to undo bus_set_iommu() in the error path, so move it to the
end of rk_iommu_probe().
Reviewed-by: Robin Murphy
Signed-off-by: Jeffy Chen
Reviewed-by: Tomasz Figa
---
Changes in v4: None
Changes in v3: None
Changes in v2:
Move bus_set_iommu()
On 18/01/18 11:52, Jeffy Chen wrote:
Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure,
which allows attaching master devices to their IOMMUs automatically
according to DT properties.
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
Add struct rk_iommudata.
On Thu, Jan 18, 2018 at 07:52:38PM +0800, Jeffy Chen wrote:
> Jeffy Chen (9):
> iommu/rockchip: Prohibit unbind and remove
> iommu/rockchip: Fix error handling in probe
> iommu/rockchip: Request irqs in rk_iommu_probe()
> ARM: dts: rockchip: add clocks in vop iommu nodes
> iommu/rockchip:
On 18/01/18 11:52, Jeffy Chen wrote:
Use the first registered IOMMU device for dma mapping operations, and
drop the domain platform device.
This is similar to exynos iommu driver.
I'd been meaning to look into this myself for the sake of removing the
arch_setup_dma_ops() hack, so I'm glad to
On 18/01/18 11:52, Jeffy Chen wrote:
From: Tomasz Figa
Current code relies on master driver enabling necessary clocks before
IOMMU is accessed, however there are cases when the IOMMU should be
accessed while the master is not running yet, for example allocating
V4L2 videobuf2 buffers, which is
It's hard to undo bus_set_iommu() in the error path, so move it to the
end of rk_iommu_probe().
Signed-off-by: Jeffy Chen
Reviewed-by: Tomasz Figa
---
Changes in v4: None
Changes in v3: None
Changes in v2:
Move bus_set_iommu() to rk_iommu_probe().
drivers/iommu/rockchip-iommu.c | 15 ++---
Use the first registered IOMMU device for dma mapping operations, and
drop the domain platform device.
This is similar to exynos iommu driver.
Signed-off-by: Jeffy Chen
Reviewed-by: Tomasz Figa
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/iommu/rockchip-iommu.c | 8
Converts the rockchip-iommu driver to use the OF_IOMMU infrastructure,
which allows attaching master devices to their IOMMUs automatically
according to DT properties.
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
Add struct rk_iommudata.
Squash iommu/rockchip: Use iommu_group_
From: Tomasz Figa
Current code relies on master driver enabling necessary clocks before
IOMMU is accessed, however there are cases when the IOMMU should be
accessed while the master is not running yet, for example allocating
V4L2 videobuf2 buffers, which is done by the VB2 framework using DMA
map
When the power domain is powered off, the IOMMU cannot be accessed and
register programming must be deferred until the power domain becomes
enabled.
Add runtime PM support, and use runtime PM device link from IOMMU to
master to startup and shutdown IOMMU.
Signed-off-by: Jeffy Chen
---
Changes i
There would be some masters sharing the same IOMMU device. Put them in
the same iommu group and share the same iommu domain.
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
Remove rk_iommudata->domain.
Changes in v2: None
drivers/iommu/rockchip-iommu.c | 22 ++
From: Tomasz Figa
Due to the bug in current code, only first IOMMU has the TLB lines
flushed in rk_iommu_zap_lines. This patch fixes the inner loop to
execute for all IOMMUs and properly flush the TLB.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
From: Tomasz Figa
This patch converts the rockchip-iommu driver to use the in-kernel
iopoll helpers to wait for certain status bits to change in registers
instead of an open-coded custom macro.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3: None
Ch
Move request_irq to the end of rk_iommu_probe().
Suggested-by: Robin Murphy
Signed-off-by: Jeffy Chen
---
Changes in v4: None
Changes in v3:
Loop platform_get_irq() as Robin suggested.
Changes in v2: None
drivers/iommu/rockchip-iommu.c | 38 +-
1 file chan
From: Tomasz Figa
Currently if the driver encounters an error while attaching device, it
will leave the IOMMU in an inconsistent state. Even though it shouldn't
really happen in reality, let's just add proper error path to keep
things consistent.
Signed-off-by: Tomasz Figa
Signed-off-by: Jeffy
Removal of IOMMUs cannot be done reliably.
This is similar to exynos iommu driver.
Signed-off-by: Jeffy Chen
Reviewed-by: Tomasz Figa
---
Changes in v4:
Rewrite commit message.
Changes in v3:
Also remove remove() and module_exit() as Tomasz suggested.
Changes in v2: None
drivers/iommu/rock
Add missing iommu_device_sysfs_remove in error path.
Signed-off-by: Jeffy Chen
Reviewed-by: Tomasz Figa
---
Changes in v4: None
Changes in v3: None
Changes in v2: None
drivers/iommu/rockchip-iommu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/rockchi
This series fixes some issues in rockchip iommu driver, and add of_iommu
support in it.
Changes in v4:
Rewrite commit message.
Changes in v3:
Also remove remove() and module_exit() as Tomasz suggested.
Loop platform_get_irq() as Robin suggested.
Add struct rk_iommudata.
Squash iommu/rockchip: Us
Hi Tomasz,
Thanks for your reply.
and just found i forgot to add iommu clocks for other rockchip
platforms(rk3399 already has that)...will also do that in the next version.
On 01/18/2018 12:17 PM, Tomasz Figa wrote:
On Thu, Jan 18, 2018 at 12:25 AM, Jeffy Chen wrote:
Removal the IOMMUs can
39 matches
Mail list logo
