Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-12 Thread Peter Xu
On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: [...] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 9a7ffd13c7f0..87888b102057 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1345,7 +1345,9 @@ void qi_flush_dev_iotlb(struct intel_iommu

Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals

2017-12-12 Thread Mehta, Sohil
On Wed, 2017-12-13 at 10:28 +0800, Lu Baolu wrote: >  > > Would the recommendation be to use pr_warn instead of pr_err or > > should > > we entirely skip the message altogether? > Greg ever educated me about the use of debugfs_ functions in > this thread. > > https://spinics.net/lists/linux-usb/ms

Re: [PATCH v3 2/6] iommu/vt-d: Add Intel IOMMU debugfs to show context internals

2017-12-12 Thread Lu Baolu
Hi, Sorry for late reply. On 12/08/2017 04:19 AM, Mehta, Sohil wrote: > On Wed, 2017-12-06 at 16:16 +0800, Lu Baolu wrote: >> Hi, >> >> On 12/06/2017 11:43 AM, Sohil Mehta wrote: >>> From: Gayatri Kammela >>> >>> >>> + seq_printf(m, "%s Context table entries for Bus: %d\n", >>> +

Re: [PATCH] iommu/amd - Set the device table entry PPR bit for IOMMU V2 devices

2017-12-12 Thread Gary R Hook
Please ignore. I've uncovered a problem and will re-submit. On 12/04/2017 01:52 PM, Gary R Hook wrote: The AMD IOMMU specification Rev 3.00 (December 2016) introduces a new Enhanced PPR Handling Support (EPHSup) bit in the MMIO register offset 0030h (IOMMU Extended Feature Register). When EPHSu

[PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

2017-12-12 Thread Alex Williamson
> Detected by ubsan: > > UBSAN: Undefined behaviour in drivers/iommu/dmar.c:1345:3 > shift exponent 64 is too large for 32-bit type 'int' > CPU: 2 PID: 1167 Comm: perf_pmu Not tainted 4.14.0-rc5+ #532 > Hardware name: LENOVO 80MX/Lenovo E31-80, BIOS DCCN34WW(V2.03) 12/01/2015 > Call Trace

Re: [PATCH 0/2] iommu/tegra: Add IOMMU group support

2017-12-12 Thread Alex Williamson
On Mon, 27 Nov 2017 10:53:43 +0100 Thierry Reding wrote: > On Mon, Nov 27, 2017 at 10:50:53AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > Hi Joerg, > > > > Both patches in this series are built-time dependent and therefore it > > would be easiest if they went in via the same

Re: [PATCH 1/2] iommu/tegra: Allow devices to be grouped

2017-12-12 Thread Alex Williamson
On Mon, 27 Nov 2017 10:50:54 +0100 Thierry Reding wrote: > From: Thierry Reding > > Implement the ->device_group() and ->of_xlate() callbacks which are used > in order to group devices. Each group can then share a single domain. > > This is implemented primarily in order to achieve the same se

RE: [PATCH v10 1/3] ACPI/IORT: Add msi address regions reservation helper

2017-12-12 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Lorenzo Pieralisi [mailto:lorenzo.pieral...@arm.com] > Sent: Monday, December 11, 2017 2:45 PM > To: Shameerali Kolothum Thodi > Cc: will.dea...@arm.com; robin.mur...@arm.com; marc.zyng...@arm.com; > j...@8bytes.org; John Garry ; xuwei (O) > ; Guohanjun (Hanj