Re: [PATCH v2 7/9] iommu/arm-smmu: remove arm_smmu_devices

2015-07-08 Thread leizhen
On 2015/7/8 21:13, Robin Murphy wrote: > On 07/07/15 04:30, Zhen Lei wrote: >> It can be replaced by of_iommu_list(in of_iommu.c). >> >> Signed-off-by: Zhen Lei >> --- >> drivers/iommu/arm-smmu-v3.c | 22 ++ >> 1 file changed, 2 insertions(+), 20 deletions(-) >> >> diff --gi

Re: [PATCH v2 9/9] iommu/arm-smmu: add support for non-pci devices

2015-07-08 Thread leizhen
On 2015/7/8 21:22, Robin Murphy wrote: > On 07/07/15 04:30, Zhen Lei wrote: >> This patch support a master with multiple stream IDs, but doesn't support a >> master behinds more than one SMMUs. > > This should probably include a binding documentation update to make it clear > what values of #iomm

Re: [PATCH v2 5/9] iommu/arm-smmu: skip the execution of CMD_PREFETCH_CONFIG

2015-07-08 Thread leizhen
On 2015/7/9 1:11, Will Deacon wrote: > Hi Robin, > > FWIW, I already queued this ;) > > On Wed, Jul 08, 2015 at 02:03:13PM +0100, Robin Murphy wrote: >> On 07/07/15 04:30, Zhen Lei wrote: >>> Hisilicon SMMUv3 devices treat CMD_PREFETCH_CONFIG as a illegal command, >>> execute it will trigger GERR

Re: [PATCH v2 5/9] iommu/arm-smmu: skip the execution of CMD_PREFETCH_CONFIG

2015-07-08 Thread Will Deacon
Hi Robin, FWIW, I already queued this ;) On Wed, Jul 08, 2015 at 02:03:13PM +0100, Robin Murphy wrote: > On 07/07/15 04:30, Zhen Lei wrote: > > Hisilicon SMMUv3 devices treat CMD_PREFETCH_CONFIG as a illegal command, > > execute it will trigger GERROR interrupt. Although the gerror code manage >

Re: [PATCH v2 4/7] DMA-API: Add dma_(un)map_resource() documentation

2015-07-08 Thread Mark Hounschell
On 07/08/2015 11:11 AM, Bjorn Helgaas wrote: [+cc Rafael] On Tue, Jul 07, 2015 at 01:14:27PM -0400, Mark Hounschell wrote: On 07/07/2015 11:15 AM, Bjorn Helgaas wrote: On Wed, May 20, 2015 at 08:11:17AM -0400, Mark Hounschell wrote: Most currently available hardware doesn't allow reads but wi

Re: Master-aware devices and sideband ID data

2015-07-08 Thread Will Deacon
On Wed, Jul 08, 2015 at 02:30:50PM +0100, Mark Rutland wrote: > On Tue, Jun 09, 2015 at 11:17:54AM +0100, Mark Rutland wrote: > > On Fri, Jun 05, 2015 at 10:05:34AM +0100, Will Deacon wrote: > > > Mark: how do you see this co-existing/merging with the current bindings? > > > > As I mentioned in my

Re: [PATCH v2 4/7] DMA-API: Add dma_(un)map_resource() documentation

2015-07-08 Thread Bjorn Helgaas
[+cc Rafael] On Tue, Jul 07, 2015 at 01:14:27PM -0400, Mark Hounschell wrote: > On 07/07/2015 11:15 AM, Bjorn Helgaas wrote: > >On Wed, May 20, 2015 at 08:11:17AM -0400, Mark Hounschell wrote: > >>Most currently available hardware doesn't allow reads but will allow > >>writes on PCIe peer-to-peer

Re: Master-aware devices and sideband ID data

2015-07-08 Thread Mark Rutland
On Tue, Jun 09, 2015 at 11:17:54AM +0100, Mark Rutland wrote: > On Fri, Jun 05, 2015 at 10:05:34AM +0100, Will Deacon wrote: > > On Thu, Jun 04, 2015 at 11:19:30PM +0100, Chalamarla, Tirumalesh wrote: > > > > On Jun 1, 2015, at 3:22 AM, Mark Rutland wrote: > > > > It's possible to specify that the

Re: [PATCH v2 9/9] iommu/arm-smmu: add support for non-pci devices

2015-07-08 Thread Robin Murphy
On 07/07/15 04:30, Zhen Lei wrote: This patch support a master with multiple stream IDs, but doesn't support a master behinds more than one SMMUs. This should probably include a binding documentation update to make it clear what values of #iommu-cells the driver supports in what circumstances

Re: [PATCH v2 7/9] iommu/arm-smmu: remove arm_smmu_devices

2015-07-08 Thread Robin Murphy
On 07/07/15 04:30, Zhen Lei wrote: It can be replaced by of_iommu_list(in of_iommu.c). Signed-off-by: Zhen Lei --- drivers/iommu/arm-smmu-v3.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c

Re: [PATCH v2 6/9] iommu/arm-smmu: to support probe deferral

2015-07-08 Thread Robin Murphy
On 07/07/15 04:30, Zhen Lei wrote: For pci devices, only the root nodes have "iommus" property. So we should traverse all of its sub nodes in of_xlate. I don't really follow this description; only the host controller is described in DT - the devices behind it are probed dynamically and don't

Re: [PATCH v2 5/9] iommu/arm-smmu: skip the execution of CMD_PREFETCH_CONFIG

2015-07-08 Thread Robin Murphy
Hi, Thanks for the respin. I still have a few comments on the series, starting here; On 07/07/15 04:30, Zhen Lei wrote: Hisilicon SMMUv3 devices treat CMD_PREFETCH_CONFIG as a illegal command, execute it will trigger GERROR interrupt. Although the gerror code manage to turn the prefetch into