Re: [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()

2015-06-02 Thread Li, ZhenHua
Dan, Do not need to call __iommu_free_mapped_mem() for err_unlock. for no new elements are added into __iommu_remapped_mem when drops to err_unlock. Thanks Zhenhua On 06/02/2015 10:06 PM, Dan Carpenter wrote: On Tue, Jun 02, 2015 at 03:45:18PM +0200, Joerg Roedel wrote: On Tue, Jun 02, 2015

Re: [PATCH 1/3] drm/exynos: fimd: ensure proper hw state in fimd_clear_channel()

2015-06-02 Thread Inki Dae
Hi Marek, I have merged atomic patch series. Can you re-base your patch series on top of exynos-drm-next? Thanks, Inki Dae On 2015년 06월 01일 20:15, Marek Szyprowski wrote: > One should not do any assumptions on the stare of the fimd hardware > during driver initialization, so to properly reset fi

RE: [v8 3/9] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip

2015-06-02 Thread Wu, Feng
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Tuesday, June 02, 2015 9:59 PM > To: Wu, Feng > Cc: j...@8bytes.org; dw...@infradead.org; jiang@linux.intel.com; > iommu@lists.linux-foundation.org; linux-ker...@vger.kernel.org > Subject: Re: [v8 3/9] io

Re: [PATCH 2/3] iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices

2015-06-02 Thread Joerg Roedel
On Tue, Jun 02, 2015 at 10:47:46AM +0100, Will Deacon wrote: > On Tue, Jun 02, 2015 at 08:39:56AM +0100, Joerg Roedel wrote: > > I don't think we need to postpone anything. Domains returned by > > iommu_domain_alloc() need to work for all groups. If there are multiple > > IOMMUs in the system with

RE: [PATCH v2 4/7] DMA-API: Add dma_(un)map_resource() documentation

2015-06-02 Thread William Davis
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: Monday, June 1, 2015 4:25 PM > To: William Davis > Cc: j...@8bytes.org; bhelg...@google.com; iommu@lists.linux-foundation.org; > linux-...@vger.kernel.org; Terence Ripperda; John Hubbard; > jgli...@r

Re: [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()

2015-06-02 Thread Dan Carpenter
On Tue, Jun 02, 2015 at 03:45:18PM +0200, Joerg Roedel wrote: > On Tue, Jun 02, 2015 at 01:09:58PM +0300, Dan Carpenter wrote: > > Smatch found some error paths that don't unlock. Also we can return > > -ENOMEM instead of -1 if we don't have an old root entry. > > > > Fixes: 5908f10af4b9 ('iommu/

Re: [v8 3/9] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip

2015-06-02 Thread Thomas Gleixner
On Wed, 27 May 2015, Feng Wu wrote: > + /* stop posting interrupts, back to remapping mode */ > + if (!vcpu_info) { > + modify_irte(&ir_data->irq_2_iommu, &ir_data->irte_entry); > + } else { > + vcpu_pi_info = (struct vcpu_data *)vcpu_info; > + > + /*

Re: [patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()

2015-06-02 Thread Joerg Roedel
On Tue, Jun 02, 2015 at 01:09:58PM +0300, Dan Carpenter wrote: > Smatch found some error paths that don't unlock. Also we can return > -ENOMEM instead of -1 if we don't have an old root entry. > > Fixes: 5908f10af4b9 ('iommu/vt-d: datatypes and functions used for kdump') > Signed-off-by: Dan Carp

[patch] iommu/vt-d: unlock on error in intel_iommu_load_translation_tables()

2015-06-02 Thread Dan Carpenter
Smatch found some error paths that don't unlock. Also we can return -ENOMEM instead of -1 if we don't have an old root entry. Fixes: 5908f10af4b9 ('iommu/vt-d: datatypes and functions used for kdump') Signed-off-by: Dan Carpenter --- Releasing the lock is good, but we might need to do other erro

Re: randconfig build error with next-20150601, in drivers/iommu/intel_irq_remapping.c

2015-06-02 Thread Joerg Roedel
Hi Jim, On Mon, Jun 01, 2015 at 09:57:07AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > drivers/iommu/intel_irq_remapping.c: In function ‘modify_irte’: > drivers/iommu/intel_irq_remapping.c:149:11: error: ‘struct > intel_iommu’ has no member named ‘pre_enabl

[PATCH] iommu/vt-d: Fix compile error when CONFIG_INTEL_IOMMU=n

2015-06-02 Thread Joerg Roedel
From: Joerg Roedel The patches for the Intel IOMMU driver to fix issues with kdump introduced a compile error with: CONFIG_DMAR_TABLE=y CONFIG_INTEL_IOMMU=n CONFIG_IRQ_REMAP=y The error manifests as: drivers/iommu/intel_irq_remapping.c: In function ‘modify_irte’: drivers/iommu/intel_irq_remapp

Re: [PATCH 2/3] iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices

2015-06-02 Thread Will Deacon
On Tue, Jun 02, 2015 at 08:39:56AM +0100, Joerg Roedel wrote: > On Mon, Jun 01, 2015 at 10:40:14AM +0100, Will Deacon wrote: > > I like this proposal. The only remaining part is that the pgsize bitmap > > inherited by the domain can only truly be finalised once the page table > > is allocated, whic

Re: [PATCH 2/3] iommu/arm-smmu: Add initial driver support for ARM SMMUv3 devices

2015-06-02 Thread Joerg Roedel
Hi Will, On Mon, Jun 01, 2015 at 10:40:14AM +0100, Will Deacon wrote: > I like this proposal. The only remaining part is that the pgsize bitmap > inherited by the domain can only truly be finalised once the page table > is allocated, which in turn can only happen once we've identified the > IOMMU