Re: [PATCH 0/6] trivial cleanup for iommu/vt-d

2014-06-17 Thread Yijing Wang
ping... On 2014/5/20 20:37, Yijing Wang wrote: > Some cleanup patches for iommu/vt-d. > > Yijing Wang (6): > iommu/vt-d: Use list_for_each_safe() to simplify code > iommu/vt-d: move up no_iommu and dmar_disabled check > iommu/vt-d: clear the redundant assignment in dmar_enable_qi > iommu/

Re: [PATCH 1/2] iommu/vt-d: remove the useless dma_pte_addr

2014-06-17 Thread Yijing Wang
ping... On 2014/5/26 20:13, Yijing Wang wrote: > Signed-off-by: Yijing Wang > --- > drivers/iommu/intel-iommu.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index f256ffc..7b7127a 100644 > --- a/dr

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Thierry Reding
On Tue, Jun 17, 2014 at 01:18:11PM +0100, Will Deacon wrote: > On Tue, Jun 17, 2014 at 12:58:30PM +0100, Thierry Reding wrote: > > On Mon, Jun 16, 2014 at 01:57:04PM +0100, Will Deacon wrote: > > > On Wed, Jun 04, 2014 at 10:12:38PM +0100, Thierry Reding wrote: > > > > It can easily be argued that

Re: [PATCH v2 02/10] iommu/ipmmu-vmsa: Cleanup failures of ARM mapping creation or attachment

2014-06-17 Thread Laurent Pinchart
Hi Joerg, On Monday 16 June 2014 17:11:42 Joerg Roedel wrote: > On Mon, May 26, 2014 at 12:08:37PM +0200, Laurent Pinchart wrote: > > > Skipped this one because it didn't apply. The others are applied. > > > > Thank you. I'll rebase the patch on top of your tree as soon as you > > publish the rel

Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init

2014-06-17 Thread Greg KH
On Tue, Jun 17, 2014 at 05:21:54PM +0200, Joerg Roedel wrote: > On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote: > > From: Jie Liu > > > > kset_create_and_add() has been fixed to return the actual error > > code ptr rather than NULL, so update iommu_init() to check the > > return value v

Re: [Intel-gfx] [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread Alex Williamson
On Tue, 2014-06-17 at 18:45 +0200, Daniel Vetter wrote: > On Tue, Jun 17, 2014 at 08:15:47AM -0600, Alex Williamson wrote: > > On Tue, 2014-06-17 at 15:44 +0200, Daniel Vetter wrote: > > > On Tue, Jun 17, 2014 at 07:16:22AM -0600, Alex Williamson wrote: > > > > On Tue, 2014-06-17 at 13:41 +0100, Da

Re: [PATCH 09/24] drivers/iommu: check actual error on iommu_init

2014-06-17 Thread Joerg Roedel
On Tue, Jun 17, 2014 at 10:29:19PM +0800, Jeff Liu wrote: > From: Jie Liu > > kset_create_and_add() has been fixed to return the actual error > code ptr rather than NULL, so update iommu_init() to check the > return value via IS_ERR() accordingly. > > Cc: Joerg Roedel > Signed-off-by: Jie Liu

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Stuart Yoder
> -Original Message- > From: Sethi Varun-B16395 > Sent: Tuesday, June 17, 2014 6:22 AM > To: Will Deacon > Cc: Mark Rutland; devicet...@vger.kernel.org; linux-samsung- > s...@vger.kernel.org; Arnd Bergmann; Pawel Moll; Ian Campbell; Grant > Grundler; Stephen Warren; Yoder Stuart-B08248; R

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Stuart Yoder
> -Original Message- > From: Sethi Varun-B16395 > Sent: Tuesday, June 17, 2014 5:27 AM > To: Yoder Stuart-B08248; Will Deacon > Cc: Thierry Reding; Mark Rutland; devicet...@vger.kernel.org; linux- > samsung-...@vger.kernel.org; Pawel Moll; Arnd Bergmann; Ian Campbell; > Grant Grundler; St

Re: [Intel-gfx] [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread Alex Williamson
On Tue, 2014-06-17 at 15:44 +0200, Daniel Vetter wrote: > On Tue, Jun 17, 2014 at 07:16:22AM -0600, Alex Williamson wrote: > > On Tue, 2014-06-17 at 13:41 +0100, David Woodhouse wrote: > > > On Tue, 2014-06-17 at 06:22 -0600, Alex Williamson wrote: > > > > On Tue, 2014-06-17 at 08:04 +0100, David W

Re: [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread Alex Williamson
On Tue, 2014-06-17 at 13:41 +0100, David Woodhouse wrote: > On Tue, 2014-06-17 at 06:22 -0600, Alex Williamson wrote: > > On Tue, 2014-06-17 at 08:04 +0100, David Woodhouse wrote: > > > On Mon, 2014-06-16 at 23:35 -0600, Alex Williamson wrote: > > > > > > > > Any idea what an off-the-shelf Asus mo

Re: [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread David Woodhouse
On Tue, 2014-06-17 at 06:22 -0600, Alex Williamson wrote: > On Tue, 2014-06-17 at 08:04 +0100, David Woodhouse wrote: > > On Mon, 2014-06-16 at 23:35 -0600, Alex Williamson wrote: > > > > > > Any idea what an off-the-shelf Asus motherboard would be doing with an > > > RMRR on the Intel HD graphics

Re: [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread Alex Williamson
On Tue, 2014-06-17 at 08:04 +0100, David Woodhouse wrote: > On Mon, 2014-06-16 at 23:35 -0600, Alex Williamson wrote: > > > > Any idea what an off-the-shelf Asus motherboard would be doing with an > > RMRR on the Intel HD graphics? > > > > dmar: RMRR base: 0x00bb80 end: 0x00bf9f >

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Will Deacon
On Tue, Jun 17, 2014 at 12:58:30PM +0100, Thierry Reding wrote: > On Mon, Jun 16, 2014 at 01:57:04PM +0100, Will Deacon wrote: > > On Wed, Jun 04, 2014 at 10:12:38PM +0100, Thierry Reding wrote: > > > It can easily be argued that if the algorithm used to remap the ID > > > varies, the compatibility

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Thierry Reding
On Mon, Jun 16, 2014 at 01:57:04PM +0100, Will Deacon wrote: > On Wed, Jun 04, 2014 at 10:12:38PM +0100, Thierry Reding wrote: > > On Fri, May 30, 2014 at 12:27:28PM +0100, Dave Martin wrote: > > > On Fri, May 30, 2014 at 08:30:08AM +0100, Thierry Reding wrote: > > [...] > > > > Arnd, can you take

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Varun Sethi
> -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of Will Deacon > Sent: Tuesday, June 17, 2014 4:13 PM > To: Sethi Varun-B16395 > Cc: Mark Rutland; devicet...@vger.kernel.org; linux-samsung- > s...@vger.ke

Re: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Will Deacon
On Tue, Jun 17, 2014 at 11:26:48AM +0100, Varun Sethi wrote: > > The way we generally thought it would work was something like > > this: > >-u-boot/bootloader makes any static streamID allocation if needed, > > sets a default streamID (e.g. 0x0) in device and expresses > > that in the

RE: [PATCH v2] devicetree: Add generic IOMMU device tree bindings

2014-06-17 Thread Varun Sethi
> -Original Message- > From: Yoder Stuart-B08248 > Sent: Tuesday, June 17, 2014 12:24 AM > To: Will Deacon > Cc: Sethi Varun-B16395; Thierry Reding; Mark Rutland; > devicet...@vger.kernel.org; linux-samsung-...@vger.kernel.org; Pawel > Moll; Arnd Bergmann; Ian Campbell; Grant Grundler; St

Re: [Intel-gfx] [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread David Woodhouse
On Tue, 2014-06-17 at 09:15 +0200, Daniel Vetter wrote: > We've always been struggling with stolen handling, and we've' always > been struggling with vt-d stuff. Also pass-through seems to be a major > pain (I've never tried myself). Given all that I'm voting for keeping > the RMRR and everything e

Re: [PATCH v2] iommu/intel: Exclude devices using RMRRs from IOMMU API domains

2014-06-17 Thread David Woodhouse
On Mon, 2014-06-16 at 23:35 -0600, Alex Williamson wrote: > > Any idea what an off-the-shelf Asus motherboard would be doing with an > RMRR on the Intel HD graphics? > > dmar: RMRR base: 0x00bb80 end: 0x00bf9f > IOMMU: Setting identity map for device :00:02.0 [0xbb80 - 0xb