Re: [PATCH v12 00/31] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2014-04-29 Thread Shaik Ameer Basha
On Mon, Apr 28, 2014 at 2:04 PM, Arnd Bergmann wrote: > On Sunday 27 April 2014 13:07:32 Shaik Ameer Basha wrote: >> The current exynos-iommu(System MMU) driver does not work autonomously >> since it is lack of support for power management of peripheral blocks. >> For example, MFC device driver mu

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-29 Thread Arnd Bergmann
On Tuesday 29 April 2014 13:07:54 Grant Grundler wrote: > On Tue, Apr 29, 2014 at 11:16 AM, Dave Martin wrote: > ... > > An IOMMU is really a specialised bridge > > Is a GART a bridge? > > IOMMUs can provide three basic functions: > 1) remap address space to reach phys mem ranges that the device

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-29 Thread Arnd Bergmann
On Tuesday 29 April 2014 19:16:02 Dave Martin wrote: > On Mon, Apr 28, 2014 at 09:55:00PM +0200, Arnd Bergmann wrote: > > On Monday 28 April 2014 20:30:56 Will Deacon wrote: > > > > > > device@4 { > > > > compatible = "some,ethernet"; > > > > iommus = <&/iomm

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-04-29 Thread Grant Grundler
On Tue, Apr 29, 2014 at 11:16 AM, Dave Martin wrote: ... > An IOMMU is really a specialised bridge Is a GART a bridge? IOMMUs can provide three basic functions: 1) remap address space to reach phys mem ranges that the device is otherwise not capable of accessing (classic 32-bit DMA to reach 64-b

Re: IOMMU DMA-mapping API for arm64 ?

2014-04-29 Thread Ritesh Harjani
On Tue, Apr 29, 2014 at 6:22 PM, Will Deacon wrote: > On Sat, Apr 26, 2014 at 03:28:37PM +0100, Ritesh Harjani wrote: >> Hi Guys, >> >> Need again some help in deciding which all functions/Data structures >> needs to be moved out from arch/arm/mm/dma-mapping to >> lib/iommu-helper.c. >> >> 1. Ther

Re: [RFC PATCH v5 08/11] VFIO_PLATFORM: Support MMAP of MMIO regions

2014-04-29 Thread Antonios Motakis
On Mon, Apr 28, 2014 at 7:27 PM, Alex Williamson wrote: > On Mon, 2014-04-28 at 17:52 +0200, Antonios Motakis wrote: >> Allow to memory map the MMIO regions of the device so userspace can >> directly access them. >> >> Signed-off-by: Antonios Motakis >> --- >> drivers/vfio/platform/vfio_platform

Re: [RFC PATCH v5 07/11] VFIO_PLATFORM: Read and write support for the device fd

2014-04-29 Thread Antonios Motakis
On Mon, Apr 28, 2014 at 7:24 PM, Alex Williamson wrote: > On Mon, 2014-04-28 at 17:52 +0200, Antonios Motakis wrote: >> VFIO returns a file descriptor which we can use to manipulate the memory >> regions of the device. Since some memory regions we cannot mmap due to >> security concerns, we also a

Re: [RFC PATCH v5 05/11] VFIO_PLATFORM: Initial skeleton of VFIO support for platform devices

2014-04-29 Thread Antonios Motakis
On Mon, Apr 28, 2014 at 7:04 PM, Alex Williamson wrote: > On Mon, 2014-04-28 at 17:52 +0200, Antonios Motakis wrote: >> This patch forms the skeleton for platform devices support with VFIO. >> >> Signed-off-by: Antonios Motakis >> --- >> drivers/vfio/Kconfig | 1 + >>

Re: [RFC PATCH v5 04/11] VFIO_IOMMU_TYPE1: Introduce the VFIO_DMA_MAP_FLAG_EXEC flag

2014-04-29 Thread Antonios Motakis
On Mon, Apr 28, 2014 at 6:53 PM, Alex Williamson wrote: > On Mon, 2014-04-28 at 17:52 +0200, Antonios Motakis wrote: >> The ARM SMMU driver expects the IOMMU_EXEC flag, otherwise it will >> set the page tables for a device as XN (execute never). This affects >> devices such as the ARM PL330 DMA Co

Re: IOMMU DMA-mapping API for arm64 ?

2014-04-29 Thread Will Deacon
On Sat, Apr 26, 2014 at 03:28:37PM +0100, Ritesh Harjani wrote: > Hi Guys, > > Need again some help in deciding which all functions/Data structures > needs to be moved out from arch/arm/mm/dma-mapping to > lib/iommu-helper.c. > > 1. There is this dma_iommu_mapping structure defination in > arch/a

Re: [RFC PATCH v5 02/11] ARM SMMU: Add capability IOMMU_CAP_DMA_EXEC

2014-04-29 Thread Antonios Motakis
On Mon, Apr 28, 2014 at 9:37 PM, Will Deacon wrote: > On Mon, Apr 28, 2014 at 04:52:42PM +0100, Antonios Motakis wrote: >> The ARM SMMU can take an IOMMU_EXEC protection flag in addition to >> IOMMU_READ and IOMMU_WRITE. Expose this as an IOMMU capability. > > The other way of handling this would

Re: [RFC PATCH v5 02/11] ARM SMMU: Add capability IOMMU_CAP_DMA_EXEC

2014-04-29 Thread Antonios Motakis
I agree, that would be simpler for the user. As it is now we have to worry about whether the EXEC flac is available just to use the PL330, with NOEXEC the device would always be usable by default. On Mon, Apr 28, 2014 at 9:37 PM, Will Deacon wrote: > On Mon, Apr 28, 2014 at 04:52:42PM +0100, An