Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Baoquan He
On 04/10/14 at 04:34pm, Jiang Liu wrote: > Hi Baoquan, > Could you please help to give output of "lspci -"? > Is device "hpsa :03:00.0" a legacy PCI device(non-PCIe)? > It may have relationship with IOMMU driver. > Thanks! > Gerry Well, the machine bug was reported on is a AMD machin

Re: [PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-10 Thread Baoquan He
This patch works for me. Tested-by: Baoquan He Thanks Baoquan On 04/10/14 at 05:17pm, scame...@beardog.cce.hp.com wrote: > > Without this, you'll see a null pointer dereference in > hpsa_enter_performant_mode(). > > Signed-off-by: Stephen M. Cameron > --- > drivers/scsi/hpsa.c |4 >

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Baoquan He
On 04/10/14 at 04:34pm, Jiang Liu wrote: > Hi Baoquan, > Could you please help to give output of "lspci -"? > Is device "hpsa :03:00.0" a legacy PCI device(non-PCIe)? > It may have relationship with IOMMU driver. > Thanks! > Gerry Hi, I just saw your mail now. Do you still need the

Re: [PATCH 0/5] OMAP IOMMU fixes and IOMMU architecture questions

2014-04-10 Thread Laurent Pinchart
Hi Joerg, On Wednesday 09 April 2014 17:08:31 Joerg Roedel wrote: > On Tue, Apr 08, 2014 at 05:02:37PM +0200, Laurent Pinchart wrote: > > On Tuesday 08 April 2014 15:43:22 Joerg Roedel wrote: > > > Who is "someone" in this case? > > > > That's exactly the problem :-) The ARM DMA API implementatio

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Shuah Khan
On Thu, Apr 10, 2014 at 2:45 PM, wrote: >> > 3f583bc21977 BAD ("Merge tag 'iommu-updates-v3.15'") >> >> Yes, specifically (finally done bisecting): >> >> commit 2e45528930388658603ea24d49cf52867b928d3e >> Author: Jiang Liu >> Date: Wed Feb 19 14:07:36 2014 +0800 >> >> iommu/vt-d: Unify the

Re: [PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-10 Thread Davidlohr Bueso
On Thu, 2014-04-10 at 17:17 -0500, scame...@beardog.cce.hp.com wrote: > Without this, you'll see a null pointer dereference in > hpsa_enter_performant_mode(). So I'm not surprised that this patch doesn't solve the problem I am seeing with DMAR and the hpsa driver hard lockup. In any case it shoul

[PATCH] hpsa: fix uninitialized trans_support in hpsa_put_ctlr_into_performant_mode()

2014-04-10 Thread scameron
Without this, you'll see a null pointer dereference in hpsa_enter_performant_mode(). Signed-off-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8cf4a0c..ef4dfdd 100644 ---

Re: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-10 Thread Alex Williamson
On Thu, 2014-04-10 at 15:15 -0600, Alex Williamson wrote: > On Thu, 2014-04-10 at 20:52 +, Stuart Yoder wrote: > > > Another advantage to this approach is that we can specify a driver > > > override to force a specific binding or prevent any binding. For > > > instance when an IOMMU group is e

Re: hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread scameron
On Thu, Apr 10, 2014 at 04:20:46PM -0500, scame...@beardog.cce.hp.com wrote: > On Thu, Apr 10, 2014 at 02:53:30PM -0600, Bjorn Helgaas wrote: > > [subject changed] > > > > On Thu, Apr 10, 2014 at 2:45 PM, wrote: > > > On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: > > >> On Wed

Re: hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread scameron
On Thu, Apr 10, 2014 at 02:53:30PM -0600, Bjorn Helgaas wrote: > [subject changed] > > On Thu, Apr 10, 2014 at 2:45 PM, wrote: > > On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: > >> On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: > >> > [+cc Joerg, iommu list] > >> > >

Re: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-10 Thread Alex Williamson
On Thu, 2014-04-10 at 20:52 +, Stuart Yoder wrote: > > Another advantage to this approach is that we can specify a driver > > override to force a specific binding or prevent any binding. For > > instance when an IOMMU group is exposed to userspace through VFIO > > we require that all devices w

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread scameron
On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: > On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: > > [+cc Joerg, iommu list] > > > > On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote: > > > On Wed, 2014-04-09 at 16:50 -0700, James Bottomley wrote: > > >> On Wed, 2014

hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread Bjorn Helgaas
[subject changed] On Thu, Apr 10, 2014 at 2:45 PM, wrote: > On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: >> On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: >> > [+cc Joerg, iommu list] >> > >> > On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote: >> > > On Wed, 20

RE: [RFC PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-10 Thread Stuart Yoder
> Another advantage to this approach is that we can specify a driver > override to force a specific binding or prevent any binding. For > instance when an IOMMU group is exposed to userspace through VFIO > we require that all devices within that group are owned by VFIO. > However, devices can be h

RE: [PATCH] driver core: platform: add device binding path 'driver_override'

2014-04-10 Thread Stuart Yoder
> -Original Message- > From: Kim Phillips [mailto:kim.phill...@freescale.com] > Sent: Tuesday, April 08, 2014 8:47 PM > To: Alex Williamson; gre...@linuxfoundation.org > Cc: bhelg...@google.com; linux-...@vger.kernel.org; k...@vger.kernel.org; > konrad.w...@oracle.com; Yoder Stuart-B08248

RE: [PATCH] PCI: Introduce new device binding path using pci_dev.driver_override

2014-04-10 Thread Stuart Yoder
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, April 04, 2014 3:19 PM > To: bhelg...@google.com; linux-...@vger.kernel.org > Cc: ag...@suse.de; k...@vger.kernel.org; konrad.w...@oracle.com; > kim.phill...@linaro.org; gre...@linuxfoundation

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Woodhouse, David
On Thu, 2014-04-10 at 09:19 -0700, Davidlohr Bueso wrote: > > > > > >> > > > > dmar: DMAR:[DMA Read] Request device [02:00.0] fault addr > > > > > >> > > > > 7f61e000 > > > > That "Present bit in context entry is clear" fault means that we have > > not set up *any* mappings for this PCI deviceā€¦ o

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Davidlohr Bueso
On Thu, 2014-04-10 at 16:34 +0800, Jiang Liu wrote: > Hi Baoquan, > Could you please help to give output of "lspci -"? Attached. > Is device "hpsa :03:00.0" a legacy PCI device(non-PCIe)? > It may have relationship with IOMMU driver. I honestly don't know. PCI is way out of my area

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Woodhouse, David
On Thu, 2014-04-10 at 09:14 -0600, Bjorn Helgaas wrote: > > Thus, my first guess would be that we are quite happily setting up the > > requested DMA maps on the *wrong* IOMMU, and then taking faults when the > > device actually tries to do DMA. > > > I like the "wrong IOMMU (or no IOMMU at all)" th

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Linda Knippers
On 4/10/2014 11:14 AM, Bjorn Helgaas wrote: > On Thu, Apr 10, 2014 at 2:46 AM, Woodhouse, David > wrote: > >>> DMAR:[fault reason 02] Present bit in context entry is clear >>> dmar: DRHD: handling fault status reg 602 >>> dmar: DMAR:[DMA Read] Request device [02:00.0] faul

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Bjorn Helgaas
On Thu, Apr 10, 2014 at 2:46 AM, Woodhouse, David wrote: >> > > >> > > > > DMAR:[fault reason 02] Present bit in context entry is clear >> > > >> > > > > dmar: DRHD: handling fault status reg 602 >> > > >> > > > > dmar: DMAR:[DMA Read] Request device [02:00.0] fault addr >> > > >> > > > > 7f61e0

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Davidlohr Bueso
On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: > [+cc Joerg, iommu list] > > On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote: > > On Wed, 2014-04-09 at 16:50 -0700, James Bottomley wrote: > >> On Wed, 2014-04-09 at 16:40 -0700, Davidlohr Bueso wrote: > >> > On Wed, 2014-04-09 at 16

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Woodhouse, David
On Thu, 2014-04-10 at 09:15 +0200, Joerg Roedel wrote: > [+ David, VT-d maintainer ] > > Jiang, David, can you please have a look into this issue? > > > > >> > > > > DMAR:[fault reason 02] Present bit in context entry is clear > > > >> > > > > dmar: DRHD: handling fault status reg 602 > > > >> >

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Jiang Liu
Hi Baoquan, Could you please help to give output of "lspci -"? Is device "hpsa :03:00.0" a legacy PCI device(non-PCIe)? It may have relationship with IOMMU driver. Thanks! Gerry On 2014/4/10 12:03, Bjorn Helgaas wrote: > [+cc Joerg, iommu list] > > On Wed, Apr 9, 2014 at 6:19 PM,

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Joerg Roedel
[+ David, VT-d maintainer ] Jiang, David, can you please have a look into this issue? Thanks, Joerg On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: > On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: > > [+cc Joerg, iommu list] > > > > On Wed, Apr 9, 2014 at 6:19