Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:54:58 +0100, Tomasz Figa wrote: > On 20.03.2014 11:22, Cho KyongHo wrote: > > On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: > >> On 19.03.2014 14:20, Tomasz Figa wrote: > >>> On 19.03.2014 01:39, Cho KyongHo wrote: > On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Fi

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Thu, 20 Mar 2014 11:44:50 +0100, Tomasz Figa wrote: > On 20.03.2014 11:03, Cho KyongHo wrote: > > On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: > >> On 19.03.2014 10:01, Sachin Kamat wrote: > >>> On 19 March 2014 14:29, Cho KyongHo wrote: > On Tue, 18 Mar 2014 16:14:53 +0100, Toma

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 19:51:21 +0100, Tomasz Figa wrote: > On 19.03.2014 19:37, Grant Grundler wrote: > > On Wed, Mar 19, 2014 at 10:30 AM, Tomasz Figa wrote: > > ... > >> As I said, AFAIK the trend is to get rid of ordering by initcalls and make > >> sure that drivers can handle missing dependencie

[PATCH 4/4] iommu/vt-d: Be less pessimistic about domain coherency where possible

2014-03-20 Thread David Woodhouse
In commit 2e12bc29 ("intel-iommu: Default to non-coherent for domains unattached to iommus") we decided to err on the side of caution and always assume that it's possible that a device will be attached which is behind a non-coherent IOMMU. In some cases, however, that just *cannot* happen. If the

[PATCH 3/4] iommu/vt-d: Honour intel_iommu=sp_off for non-VMM domains

2014-03-20 Thread David Woodhouse
Signed-off-by: David Woodhouse --- drivers/iommu/intel-iommu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index f5934fc..c3d4bc9 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c @@ -

[PATCH 2/4] iommu/vt-d: Clean up and fix page table clear/free behaviour

2014-03-20 Thread David Woodhouse
There is a race condition between the existing clear/free code and the hardware. The IOMMU is actually permitted to cache the intermediate levels of the page tables, and doesn't need to walk the table from the very top of the PGD each time. So the existing back-to-back calls to dma_pte_clear_range

[PATCH 1/4] iommu/vt-d: Clean up size handling for intel_iommu_unmap()

2014-03-20 Thread David Woodhouse
We have this horrid API where iommu_unmap() can unmap more than it's asked to, if the IOVA in question happens to be mapped with a large page. Instead of propagating this nonsense to the point where we end up returning the page order from dma_pte_clear_range(), let's just do it once and adjust th

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 09:54:39 -0700, Grant Grundler wrote: > On Wed, Mar 19, 2014 at 6:12 AM, Tomasz Figa wrote: > ... > >> Device driver is not only for the scholarship but also for the real use. > > > > Huh? I'm not sure what kind of comment is this. > > I'm guessing Cho meant: "This isn't an ac

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: On 18.03.2014 14:01, Cho KyongHo wrote: On Fri, 14 Mar 2014

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Tomasz Figa
On 20.03.2014 11:03, Cho KyongHo wrote: On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: On 19.03.2014 10:01, Sachin Kamat wrote: On 19 March 2014 14:29, Cho KyongHo wrote: On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: On 18.03.2014 12:09, Cho KyongHo wrote: On Fri, 14 Mar 20

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: > On 19.03.2014 14:20, Tomasz Figa wrote: > > On 19.03.2014 01:39, Cho KyongHo wrote: > >> On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: > >>> > >>> > >>> On 18.03.2014 14:01, Cho KyongHo wrote: > On Fri, 14 Mar 2014 17:12:03 +010

Re: [PATCH v11 10/27] iommu/exynos: use managed device helper functions

2014-03-20 Thread Cho KyongHo
On Wed, 19 Mar 2014 13:08:42 +0100, Tomasz Figa wrote: > On 19.03.2014 10:01, Sachin Kamat wrote: > > On 19 March 2014 14:29, Cho KyongHo wrote: > >> On Tue, 18 Mar 2014 16:14:53 +0100, Tomasz Figa wrote: > >>> On 18.03.2014 12:09, Cho KyongHo wrote: > On Fri, 14 Mar 2014 20:52:43 +0530, Sach

Re: [PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-20 Thread Cho KyongHo
On Tue, 18 Mar 2014 18:33:20 -0700, Grant Grundler wrote: > On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote: > > This commit introduces sysmmu_pte_t for page table entries and > > sysmmu_iova_t vor I/O virtual address that is manipulated by > > exynos-iommu driver. The purpose of the typedef i