RE: [PATCH 1/5 v10] iommu/fsl: Make iova u64 in the iommu_iova_to_phys API.

2013-03-25 Thread Sethi Varun-B16395
Because of the PAMU supported window sizes the iova can be > 32bit value even on 32 bit architectures. I see that we have the "CONFIG_ARCH_DMA_ADDR_T_64BIT" config option enabled in our case, so dma_addr_t would be u64 in our case. -Varun > -Original Message- > From: Don Dutile [mailto:

Re: [PATCH 1/5 v10] iommu/fsl: Make iova u64 in the iommu_iova_to_phys API.

2013-03-25 Thread Don Dutile
I agree that unsigned long was an improper choice for iova's, but why aren't they dma_addr_t ? ... an iova is a dma-addr, just a 'virtual' one wrt phys-addr. On 03/22/2013 06:34 PM, Varun Sethi wrote: This is required in case of PAMU, as it can support a window size of up to 64G (even on 32bit).

Re: [PATCH] iommu: add a function to find an iommu group by id

2013-03-25 Thread Don Dutile
On 03/25/2013 10:28 AM, Alex Williamson wrote: On Mon, 2013-03-25 at 10:23 +1100, Alexey Kardashevskiy wrote: As IOMMU groups are exposed to the user space by their numbers, the user space can use them in various kernel APIs so the kernel might need an API to find a group by its ID. As an examp

Re: [PATCH] iommu: add a function to find an iommu group by id

2013-03-25 Thread Alex Williamson
On Mon, 2013-03-25 at 10:23 +1100, Alexey Kardashevskiy wrote: > As IOMMU groups are exposed to the user space by their numbers, > the user space can use them in various kernel APIs so the kernel > might need an API to find a group by its ID. > > As an example, QEMU VFIO on PPC64 platform needs it