Re: [PATCH] iommu: moving initialization earlier

2013-01-10 Thread Shuah Khan
On Thu, Jan 10, 2013 at 1:40 PM, Shuah Khan wrote: > On Thu, Jan 10, 2013 at 10:09 AM, Joerg Roedel wrote: >> On Mon, Jan 07, 2013 at 06:51:52PM +1100, Alexey Kardashevskiy wrote: >>> The iommu_init() initializes IOMMU internal structures and data >>> required for the IOMMU API as iommu_group_all

Re: [PATCH] iommu: moving initialization earlier

2013-01-10 Thread Shuah Khan
On Thu, Jan 10, 2013 at 10:09 AM, Joerg Roedel wrote: > On Mon, Jan 07, 2013 at 06:51:52PM +1100, Alexey Kardashevskiy wrote: >> The iommu_init() initializes IOMMU internal structures and data >> required for the IOMMU API as iommu_group_alloc(). >> It is registered as a subsys_initcall now. >> >>

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
'Joerg Roedel' wrote: > > On Thu, Jan 10, 2013 at 10:34:48AM -0800, Kukjin Kim wrote: > > Hmm, I think, just one [7/12] patch does matter so if you could create topic > > branch and apply [7/12] patch firstly before other drivers/ changes would > be > > better to me. It's OK on both trees if I jus

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:34:48AM -0800, Kukjin Kim wrote: > Hmm, I think, just one [7/12] patch does matter so if you could create topic > branch and apply [7/12] patch firstly before other drivers/ changes would be > better to me. It's OK on both trees if I just _merge_ the first [7/12] > commit

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:06:24AM -0800, Kukjin Kim wrote: > You know, we have several options to avoid it. When you take this series in > your tree, you can provide topic branch for me. Or this series should be > separated for arch/arm/ and drivers/ for both trees, then only drivers/iommu > chang

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
Kukjin Kim wrote: > > 'Joerg Roedel' wrote: > > > > On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > > > Cho KyongHo wrote: > > > > > > Diffstats: > > > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > > > arch/

Re: [PATCH v5 1/4] iommu/shmobile: Add iommu driver for Renesas IPMMU modules

2013-01-10 Thread Joerg Roedel
Hi, On Mon, Jan 07, 2013 at 07:11:58PM +0100, Laurent Pinchart wrote: > > + l2index = (iova >> 12) & 0xff; > > + spin_lock(&sh_domain->map_lock); > > + ret = l2alloc(sh_domain, l1index); > > l2alloc calls dma_pool_alloc(GFP_KERNEL), that not safe in a non-sleepable

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
'Joerg Roedel' wrote: > > On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > > Cho KyongHo wrote: > > > > Diffstats: > > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > > arch/arm/mach-exynos/Kconfig

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > Cho KyongHo wrote: > > Diffstats: > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > arch/arm/mach-exynos/Kconfig |5 - > > arch/arm/mach-exynos/Mak

Re: [PATCH] iommu: moving initialization earlier

2013-01-10 Thread Joerg Roedel
On Mon, Jan 07, 2013 at 06:51:52PM +1100, Alexey Kardashevskiy wrote: > The iommu_init() initializes IOMMU internal structures and data > required for the IOMMU API as iommu_group_alloc(). > It is registered as a subsys_initcall now. > > One of the IOMMU users is going to be a PCI subsystem on POW