Re: OMAP and MSM IOMMU driver misbehavior

2012-01-23 Thread Ohad Ben-Cohen
Hi Joerg, On Mon, Jan 23, 2012 at 4:03 PM, Joerg Roedel wrote: > Please tell me when I mis-read the code, otherwise please fix this in > your drivers so that we can get consistent behavior for IOMMU-API > users :-) I'm a bit tied up with some schedule I have to meet this week, but I'll definitel

[PATCH v2 5/5] vfio: VFIO core Kconfig and Makefile

2012-01-23 Thread Alex Williamson
Enable the base code. Signed-off-by: Alex Williamson --- MAINTAINERS |8 drivers/Kconfig |2 ++ drivers/Makefile |1 + drivers/vfio/Kconfig |8 drivers/vfio/Makefile |3 +++ 5 files changed, 22 insertions(+), 0 deletions(-) create mod

[PATCH v2 4/5] vfio: VFIO core IOMMU mapping support

2012-01-23 Thread Alex Williamson
Backing for operations on the IOMMU object, including DMA mapping and unmapping. Signed-off-by: Alex Williamson --- drivers/vfio/vfio_iommu.c | 611 + 1 files changed, 611 insertions(+), 0 deletions(-) create mode 100644 drivers/vfio/vfio_iommu.c d

[PATCH v2 3/5] vfio: VFIO core group interface

2012-01-23 Thread Alex Williamson
This provides the base group management with conduits to the IOMMU driver and VFIO bus drivers. Signed-off-by: Alex Williamson --- drivers/vfio/vfio_main.c| 1248 +++ drivers/vfio/vfio_private.h | 36 + 2 files changed, 1284 insertions(+), 0 deletio

[PATCH v2 2/5] vfio: VFIO core header

2012-01-23 Thread Alex Williamson
This defines both the user and bus driver APIs. Signed-off-by: Alex Williamson --- Documentation/ioctl/ioctl-number.txt |1 include/linux/vfio.h | 395 ++ 2 files changed, 396 insertions(+), 0 deletions(-) create mode 100644 include/linux/v

[PATCH v2 1/5] vfio: Introduce documentation for VFIO driver

2012-01-23 Thread Alex Williamson
Including rationale for design, example usage and API description. Signed-off-by: Alex Williamson --- Documentation/vfio.txt | 359 1 files changed, 359 insertions(+), 0 deletions(-) create mode 100644 Documentation/vfio.txt diff --git a/Docum

[PATCH v2 0/5] VFIO core framework

2012-01-23 Thread Alex Williamson
This series includes the core framework for the VFIO driver. VFIO is a userspace driver interface meant to replace both the KVM device assignment code as well as interfaces like UIO. Please see patch 1/5 for a complete description of VFIO, what it can do, and how it's designed. This series can al

Re: [PATCH 2/2] ARM: IOMMU: Tegra30: Add iommu_ops for SMMU driver

2012-01-23 Thread Joerg Roedel
Hi, please see my comments inline. When you fix these issues I think the driver is ready for merging. On Thu, Jan 05, 2012 at 09:11:49AM +0200, Hiroshi DOYU wrote: > +static int smmu_iommu_map(struct iommu_domain *domain, unsigned long iova, > + phys_addr_t pa, size_t bytes,

Re: [PATCH 1/2] ARM: IOMMU: Tegra20: Add iommu_ops for GART driver

2012-01-23 Thread Joerg Roedel
Hi, first, some questions about the GART on your platform. 1) How many GARTs are usually implemented? One GART per device or is there a single GART covering all devices, or a mix of both? 2) Are devices allowed to DMA outside of the remappable range or will this fail? Besides that I think

Re: [PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-01-23 Thread 'Joerg Roedel'
Hi, please also get and inclue Acks from the Exynos maintainer for the next post. Since I have a compiling config for exynos now I will merge the patches when you have the Acks and addressed or explained the issues I pointed out below. On Thu, Dec 29, 2011 at 09:26:08PM +0900, KyongHo Cho wrote:

OMAP and MSM IOMMU driver misbehavior

2012-01-23 Thread Joerg Roedel
Hi, while reviewing another IOMMU driver again I came across a problem in the IOMMU drivers for OMAP and MSM platforms. In both drivers the 'domain_destroy with devices attached' case isn't handled correctly. OMAP driver seems not to track the devices attached to a domain at all. So when a domain

[PATCH] iommu/amd: Work around broken IVRS tables

2012-01-23 Thread Joerg Roedel
On some systems the IVRS table does not contain all PCI devices present in the system. In case a device not present in the IVRS table is translated by the IOMMU no DMA is possible from that device by default. This patch fixes this by removing the DTE entry for every PCI device present in the system