[PHP-DEV] SplFileObject Countable

2011-03-11 Thread Sebastian Marek
bject' internal integrity, but maybe it would make sense to make it work with the stream itself. If it's fine I can write some unit tests to cover this and then submit a complete patch. Regards -- Sebastian Marek proo...@gmail.com Follow me online at: Blog: http://criticallog.thornet.net

Re: [PHP-DEV] SplFileObject Countable

2011-03-14 Thread Sebastian Marek
Hello, That makes perfect sense. I have raised a feature request and have attached a patch containing both countLines() method implementation and phpt tests. thx On Sun, Mar 13, 2011 at 9:39 PM, Etienne Kneuss wrote: > On Mar 11 23:22:04, Sebastian Marek wrote: > > Hi, > > >

Re: [PHP-DEV] SplFileObject Countable

2011-03-15 Thread Sebastian Marek
Length(). This would need a > different name however as this method would be to count the longest line of > the file rather than indicate the maximum length of a line to read as the > current SplFileObject::getMaxLineLen() method does. > > Just my thoughts, > > Nick > > &