Re: [PHP-DEV] Re: [RFC] Decoding HTML and the Ambiguous Ampersand

2024-08-22 Thread Niels Dossche
On 20/08/2024 00:45, Dennis Snell wrote: > >> On Jul 9, 2024, at 4:55 PM, Dennis Snell wrote: >> >> Greetings all, >> >> The `html_entity_decode( … ENT_HTML5 … )` function has a number of issues >> that I’d like to correct. >> >>  - It’s missing 720 of HTML5’s specified named character reference

Re: [PHP-DEV] ext/gd: drop XPM support on Windows

2024-09-11 Thread Niels Dossche
On 11/09/2024 14:55, Christoph M. Becker wrote: > Hi all, > > I'm in the progress of updating all libraries required for ext/gd on > Windows. Since libxpm hasn't been updated for quite a while (we're > still shipping libxpm 3.5.12), I've attempted updating to libxpm 3.5.17. > However, besides th

[PHP-DEV] Re: Allowing $a = foo($a) to operate in-place (was Re: [PHP-DEV] Array spread append)

2023-04-10 Thread Niels Dossche
Hi On 10/04/2023 22:11, Tim Düsterhus wrote: > Hi > > On 4/10/23 21:50, Niels Dossche wrote: >>> The suggested optimization of "the input is overwritten with the output" >>> would then also allow to avoid introducing reference parameters just for >>

Re: [PHP-DEV] Introduction - SuitespaceRnD

2023-04-23 Thread Niels Dossche
Hi On 4/19/23 17:11, Garet Claborn wrote: > Hello PHP Internals, > > I am Garet Claborn, CTO for Suitespace Inc > , leading > up our R&D team. Just registered and my PHP Wiki username is: > *suitespacernd* > > We use PHP extensively in our projects. Specifically I fi

Re: [PHP-DEV] [RFC] [Discussion] nameof

2023-05-13 Thread Niels Dossche
On 13/05/2023 09:27, Robert Landers wrote: > Hello Internals, > > It is with much trepidation and excitement that I'd like to announce > the `nameof` RFC (https://wiki.php.net/rfc/nameof). It has changed > quite a bit in the last couple of days, so if you haven't seen the > latest draft, please ch

[PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-20 Thread Niels Dossche
Hello internals I'm opening the discussion for my RFC to implement mb_str_pad. RFC: https://wiki.php.net/rfc/mb_str_pad Implementation pull request: https://github.com/php/php-src/pull/11284 Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https

Re: [PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-20 Thread Niels Dossche
Hi Rowan On 5/20/23 17:13, Rowan Tommins wrote: > On 20 May 2023 13:53:20 BST, Niels Dossche wrote: >> RFC: https://wiki.php.net/rfc/mb_str_pad > > Hi Niels, > > This seems like a reasonable addition. My only hesitation is that it will > share with other mbstrin

Re: [PHP-DEV] RFC [Discussion]: mb_str_pad

2023-05-22 Thread Niels Dossche
Hi On 5/22/23 00:08, Jorg Sowa wrote: > Hello, > As this is a new function do you consider any namespace for it? Based on > passed RFC[1] allowing for namespaces in bundled extensions it would be > nice to introduce new functions with namespace. Maybe the namespace could > be voted in the RFC sepa

[PHP-DEV] mb_ucfirst and mb_lcfirst

2023-05-27 Thread Niels Dossche
Hey internals I recently saw a comment on Reddit about the lack of a multibyte version of ucfirst and lcfirst. I was surprised to see this is indeed the case. I also checked the modes of mb_convert_case: the closest supported one is title case, but there's no mode for only handling the first let

Re: [PHP-DEV] RFC [Discussion]: Marking overridden methods (#[\Override])

2023-06-02 Thread Niels Dossche
Hi Tim On 5/11/23 18:37, Tim Düsterhus wrote: > Hi > > I'm now opening discussion for the RFC "Marking overridden methods > (#[\Override])": > > > > RFC: Marking overridden methods (#[\Override]) > https://wiki.php.net/rfc/marking_overriden_methods > > Proof of concept implementation is

Re: [PHP-DEV] Deprecation of the formats DATE_ISO8601 and DATE_RFC7231

2023-06-02 Thread Niels Dossche
On 6/3/23 00:28, Jorg Sowa wrote: > I would write RFC anyway to check the reception, but I need Karma to do it. > Could I ask someone for it? > You'll need to register on the wiki, and send an email to internals in which you say your wiki name. Kind regards Niels -- PHP Internals - PHP Runtim

[PHP-DEV] Re: RFC [Discussion]: mb_str_pad

2023-06-04 Thread Niels Dossche
Hi internals I haven't seen more discussion for some time now. I plan on starting the vote tomorrow evening 20:00 GMT+2, and to end it on June 19 20:00 GMT+2. Any final comments should be raised now. Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, vis

[PHP-DEV] [RFC] [VOTE] mb_str_pad

2023-06-05 Thread Niels Dossche
Hello internals I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. RFC link: https://wiki.php.net/rfc/mb_str_pad The vote will last until 2023-06-19 20:00 GMT+2. Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https:/

Re: [PHP-DEV] [RFC] [VOTE] mb_str_pad

2023-06-06 Thread Niels Dossche
Hi Christian On 06/06/2023 09:12, Christian Schneider wrote: > Am 05.06.2023 um 19:59 schrieb Niels Dossche : >> I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. >> RFC link: https://wiki.php.net/rfc/mb_str_pad > > I voted "N

[PHP-DEV] Re: [RFC] [VOTE] mb_str_pad

2023-06-19 Thread Niels Dossche
On 05/06/2023 19:59, Niels Dossche wrote: > Hello internals > > I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. > RFC link: https://wiki.php.net/rfc/mb_str_pad > > The vote will last until 2023-06-19 20:00 GMT+2. > > Kind regards >

Re: [PHP-DEV] Re: [RFC] Migrating to GitHub issues

2023-06-24 Thread Niels Dossche
On 6/24/23 21:39, Nikita Popov wrote: > On Fri, Dec 30, 2022, at 22:39, Christoph M. Becker wrote: >> On 30.12.2022 at 22:12, Nikita Popov wrote: >> >>> On Thu, Nov 10, 2022, at 14:29, Christoph M. Becker wrote: >>> On 09.11.2022 at 23:27, Nikita Popov wrote: > It looks like GitHub ha

Re: [PHP-DEV] Updating the RFC list page

2023-08-07 Thread Niels Dossche
On 06/08/2023 14:58, Juliette Reinders Folmer wrote: > On 6-8-2023 13:13, Juliette Reinders Folmer wrote: >> RFC authors, >> >> I just noticed that the PHP 8.3 "PDO driver specific sub-classes" RFC is >> still listed as "in voting". The "Deprecate functions with overloaded >> signatures" RFC is s

[PHP-DEV] SimpleXML and JSON

2023-08-14 Thread Niels Dossche
Hi internals! While browsing through bugsnet I encountered this SimpleXML issue with 252 votes: https://bugs.php.net/bug.php?id=54632 TLDR: when you have a XML document (modified a bit from the example in the bugtracker): foobar And you load it into simpleXML, the result of calling json_enco

Re: [PHP-DEV] SimpleXML and JSON

2023-08-15 Thread Niels Dossche
On 14/08/2023 23:56, Rowan Tommins wrote: > On 14 August 2023 13:40:40 BST, Niels Dossche wrote: >>And you load it into simpleXML, the result of calling >>json_encode($the_simplexml_object) > > My usual reaction to this is "why would you take an object designed for &

Re: [PHP-DEV] Re: Introducing 2 new modes to round function

2023-08-30 Thread Niels Dossche
On 8/31/23 01:16, Jorg Sowa wrote: > Hello everyone, > As I am not sure what I should next I decided to follow the formal way and > I created the RFC for the change. I will start voting soon. Please let me > know if you have any suggestions. > > RFC under discussion: > https://wiki.php.net/rfc/new

Re: [PHP-DEV] Casing of acronyms in class and method names

2023-08-31 Thread Niels Dossche
Hi Tim On 30/08/2023 13:43, Tim Düsterhus wrote: > Hi > > after suggesting the use of ucfirst(strtolower(...)) casing for acronyms > within a classname of a draft RFC, I was made aware of previous class naming > RFC (June 2017) that required the use of PascalCase for class names, with the > ex

[PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-02 Thread Niels Dossche
Hello internals I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization support". https://wiki.php.net/rfc/domdocument_html5_parser Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [Discussion] Add 4 new rounding modes to round() function

2023-09-02 Thread Niels Dossche
Hey Jorg Thanks for your RFC. On 9/2/23 21:33, Jorg Sowa wrote: > Hello everyone, > > I would like to start the RFC process about adding 4 new rounding modes to > the round() function. > > As the topic was previously discussed and the change is quite small, I > would like to start the voting on

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
Hey Christian Thank you for going through my proposal. On 04/09/2023 09:23, naitsi...@e.mail.de wrote: > Am 02-Sep-2023 21:41:50 +0200 schrieb dossche.ni...@gmail.com: >> Hello internals >> >> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization >> support". >> https://wiki

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-04 Thread Niels Dossche
e spec compliance issues in an opt-in manner. This would help with security & sanitization problems (HTML5 should help with the encoding&decoding). > > Warmly, > Dennis Snell Kind regards Niels > >> On Sep 2, 2023, at 12:41 PM, Niels Dossche > <mailto:dossch

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-05 Thread Niels Dossche
Hi Ben On 05/09/2023 03:31, Ben Ramsey wrote: > On 9/2/23 14:41, Niels Dossche wrote: >> I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization >> support". >> https://wiki.php.net/rfc/domdocument_html5_parser > > > Thanks, Niels

Re: [PHP-DEV] Breakages with rc1

2023-09-05 Thread Niels Dossche
Hi Hanz On 05/09/2023 11:39, Hanz wrote: > Hello, > > Ran into a couple of issues with RC1 that I haven't seen online. > > With --with-pear: The --with-pear option is deprecated > > With --enable-pear: configure: WARNING: unrecognized options: --enable-pear > > I'm using --disable-all as the f

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-06 Thread Niels Dossche
Hi Dennis On 06/09/2023 22:02, Dennis Snell wrote: > > >> On Sep 4, 2023, at 1:15 PM, Niels Dossche wrote: >> >> On 04/09/2023 21:54, Dennis Snell wrote: >>> Thanks for the proposal Niels, >>> >>> I’ve dealt with my own grief working throug

Re: [PHP-DEV] RFC: Increasing the default BCrypt cost

2023-09-07 Thread Niels Dossche
Hi Tim On 07/09/2023 19:26, Tim Düsterhus wrote: > Hi > > in response to the recent "PASSWORD_DEFAULT value" thread [1], I've created > an RFC to discuss an increase of the default BCrypt costs for > `password_hash()` from the current value of 10. > > https://wiki.php.net/rfc/bcrypt_cost_2023

[PHP-DEV] Proposal: $options argument for SimpleXMLElement::asXML

2023-09-09 Thread Niels Dossche
Hi internals I came across https://bugs.php.net/bug.php?id=67387. Passing the option in via the constructor doesn't work because the constructor only allows parser options. We can implement support for options (such as LIBXML_NOXMLDECL, LIBXML_SAVE_NOEMPTYTAG) by adding an (optional) argument to

[PHP-DEV] Bugfix backport for bundled pcre2lib

2023-09-14 Thread Niels Dossche
Hi internals I currently have a PR open to fix bug https://github.com/php/php-src/issues/11956. PR link: https://github.com/php/php-src/pull/12108 To give some context: OP's code worked fine in PHP 8.0 but not in 8.1. That's because pcre2lib got updated in 8.1 and brought a JIT regression with

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-15 Thread Niels Dossche
On 9/2/23 21:41, Niels Dossche wrote: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels Hi internals I'd like

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-16 Thread Niels Dossche
Hi Larry On 9/17/23 01:04, Larry Garfield wrote: > On Fri, Sep 15, 2023, at 6:17 PM, Niels Dossche wrote: >> On 9/2/23 21:41, Niels Dossche wrote: >>> Hello internals >>> >>> I'm opening the discussion for my RFC "DOM HTML5 parsing and serializati

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-17 Thread Niels Dossche
Hi Alexandru On 9/17/23 11:59, Alexandru Pătrănescu wrote: > On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: > >> >> We'll add a common abstract base class DOM\Document (name taken from the >> DOM spec & Javascript world). >> DOM\Document contains the pr

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-18 Thread Niels Dossche
Hi Stephen On 18/09/2023 08:46, Stephen Reay wrote: > > >> On 17 Sep 2023, at 18:28, Niels Dossche wrote: >> >> Hi Alexandru >> >> On 9/17/23 11:59, Alexandru Pătrănescu wrote: >>> On Sat, Sep 16, 2023, 02:17 Niels Dossche wrote: >>>

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-19 Thread Niels Dossche
Hi Stephen On 19/09/2023 08:35, Stephen Reay wrote: > >> On 19 Sep 2023, at 01:00, Niels Dossche >> >> Cheers >> Niels >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: https://www.php.net/unsub.ph

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-19 Thread Niels Dossche
Hi Stephen On 19/09/2023 09:58, Stephen Reay wrote: > > >> On 19 Sep 2023, at 14:30, Tim Düsterhus wrote: >> >> Hi >> >> On 9/19/23 08:35, Stephen Reay wrote: >>> Regarding the private constructor: I understand the issue with the *old* >>> class being confusing - but your new class doesn't hav

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-21 Thread Niels Dossche
Hi Stephen On 20/09/2023 12:02, Stephen Reay wrote: > > >> On 20 Sep 2023, at 03:03, Niels Dossche wrote: >> >> Hi Stephen >> >> On 19/09/2023 09:58, Stephen Reay wrote: >>> >>> >>>> On 19 Sep 2023, at 14:30, Tim Düsterhus

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-21 Thread Niels Dossche
On 02/09/2023 21:41, Niels Dossche wrote: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels Hi internals After the dis

Re: [PHP-DEV] [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-21 Thread Niels Dossche
Hi Dennis On 21/09/2023 22:26, Dennis Snell wrote: > > >> On Sep 19, 2023, at 12:30 AM, Tim Düsterhus wrote: >> >> From the perspective of the user of the API, I like the symmetry between all >> the named constructors: >> >> Whenever I want to create a new document, I use one of the fromXyz()

[PHP-DEV] [RFC] [Discussion] XML_OPTION_PARSE_HUGE

2023-09-21 Thread Niels Dossche
Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/xml_option_parse_huge Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [Discussion] XML_OPTION_PARSE_HUGE

2023-09-22 Thread Niels Dossche
Hi Aleksander On 22/09/2023 07:51, Aleksander Machniak wrote: > On 21.09.2023 23:26, Niels Dossche wrote: >> I'd like to put a new RFC under discussion: >> https://wiki.php.net/rfc/xml_option_parse_huge > > Looking at LIBXML_PARSEHUGE at > https://www.php.net/m

Re: [PHP-DEV] [RFC] [Discussion] XML_OPTION_PARSE_HUGE

2023-09-22 Thread Niels Dossche
Hi Larry On 22/09/2023 01:05, Larry Garfield wrote: > On Thu, Sep 21, 2023, at 9:26 PM, Niels Dossche wrote: >> Hi internals >> >> I'd like to put a new RFC under discussion: >> https://wiki.php.net/rfc/xml_option_parse_huge >> >> Kind regards >>

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-23 Thread Niels Dossche
Hi internals On 9/2/23 21:41, Niels Dossche wrote: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels Some minor chan

Re: [PHP-DEV] Security Audit Priorities

2023-09-27 Thread Niels Dossche
Hi On 25/09/2023 17:33, Tim Düsterhus wrote: > Hi > > On 9/25/23 10:49, Derick Rethans wrote: >> So, if you can suggest an area where doing an external review would have >> high impact, please reply to this email. > > Some things from top of my head in arbitrary order. Not all of them are > nec

[PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
On 02/09/2023 21:41, Niels Dossche wrote: > Hello internals > > I'm opening the discussion for my RFC "DOM HTML5 parsing and serialization > support". > https://wiki.php.net/rfc/domdocument_html5_parser > > Kind regards > Niels Hi internals Discussion se

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
Hi Marc On 29/09/2023 09:39, Marc Bennewitz wrote: > Hi Niels, > > On 29.09.23 09:07, Niels Dossche wrote: >> Hi internals >> >> Discussion seems to have died down. >> Today, it's been 14 days since the last major change was done to the RFC >> (i.e. t

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
Hi Tim On 29/09/2023 18:06, Tim Düsterhus wrote: > Hi > > On 9/29/23 17:45, Niels Dossche wrote: >> Right, we follow the HTML spec in this regard. Roughly speaking we determine >> the charset in the following order of priorities. >> If one option fails, it will f

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
Hi Larry On 29/09/2023 18:58, Larry Garfield wrote: > On Fri, Sep 29, 2023, at 7:07 AM, Niels Dossche wrote: >> On 02/09/2023 21:41, Niels Dossche wrote: >>> Hello internals >>> >>> I'm opening the discussion for my RFC "DOM HTML5 parsing and seriali

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
On 9/29/23 20:22, Larry Garfield wrote: > On Fri, Sep 29, 2023, at 6:12 PM, Niels Dossche wrote: > >>> Unclear to me: Would the XML constants also be aliased into the namespace >>> verbatim, or left globally? >>> >> >> I'll clarify this. >&g

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
Hi Dennis On 9/29/23 20:20, Dennis Snell wrote: >> >>> >>> For both, `XMLDocument::fromEmpty` and `HTMLDocument::createEmpty` there is >>> an argument available to define the encoding but none of the other >>> `createFrom*` methods have this argument. >>> >>> As far as I understand, in the these

Re: [PHP-DEV] Re: [RFC] [Discussion] DOM HTML5 parsing and serialization support

2023-09-29 Thread Niels Dossche
Hi Dennis On 9/29/23 23:38, Dennis Snell wrote: >> Just chiming in here to say that while we don't offer a createFragment() in >> this proposal, it's possible to parse fragments by passing the >> LIBXML_HTML_NOIMPLIED option. Alternatively, in the future I plan to offer >> innerHTML which you c

Re: [PHP-DEV] What should I do to create an RFC?

2023-09-30 Thread Niels Dossche
Hi Saki On 9/30/23 06:03, Saki Takamachi wrote: > Hi. > > I want to create an RFC. This is my first time. > > The next two pages each have sections on how to create RFCs. However, they > differ slightly in content. Which way should I use? > > https://wiki.php.net/rfc/howto You should follow t

[PHP-DEV] XSLTProcessor max depth

2023-09-30 Thread Niels Dossche
Hi internals I'm looking to address https://bugs.php.net/bug.php?id=71571. TL;DR: XSL has a maximum recursion depth, and it may even depend on the distro/OS config. For complex inputs you may reach this limit, but PHP offers no way to change that limit. As we already have methods in XSLTProcess

[PHP-DEV] [RFC] [VOTE] DOM HTML5 parsing and serialization

2023-10-02 Thread Niels Dossche
Hi internals I just opened the vote on my RFC "DOM HTML5 parsing and serialization". RFC link: https://wiki.php.net/rfc/domdocument_html5_parser Discussion (externals.io): https://externals.io/message/120972 Voting will run for two weeks until 2023-10-16 20:20 GMT+2 There is one primary vote (2/3

[PHP-DEV] Re: [RFC] [Discussion] XML_OPTION_PARSE_HUGE

2023-10-06 Thread Niels Dossche
On 9/21/23 23:26, Niels Dossche wrote: > Hi internals > > I'd like to put a new RFC under discussion: > https://wiki.php.net/rfc/xml_option_parse_huge > > Kind regards > Niels Hi internals It's been two weeks, I'd like to start the vote tomorrow evening.

[PHP-DEV] [RFC] [VOTE] XML_OPTION_PARSE_HUGE

2023-10-07 Thread Niels Dossche
Hi internals I'm starting the vote on my RFC to add the XML_OPTION_PARSE_HUGE option to ext/xml. Discussion: https://externals.io/message/121121 RFC link: https://wiki.php.net/rfc/xml_option_parse_huge The voting will run for two weeks, until October 21st 21:10 GMT+2. Kind regards Niels -- PH

[PHP-DEV] DOMXPath / XSLTProcessor function callbacks

2023-10-12 Thread Niels Dossche
Hi internals I'm looking to extend the functionality of calling PHP functions from within the DOMXPath or XSLTProcessor classes. In case you're unfamiliar here's a quick rundown. The DOMXPath class allows you to execute XPath queries on a DOM tree to lookup certain nodes satisfying a filter. PH

Re: [PHP-DEV] DOMXPath / XSLTProcessor function callbacks

2023-10-14 Thread Niels Dossche
Hi Tim On 10/14/23 12:30, Tim Düsterhus wrote: > Hi > > On 10/13/23 00:39, Niels Dossche wrote: >> Please let me know your thoughts. > > What does calling ->registerPHPFunctions() do when it's called more than > once? Will the existing allow-list be

Re: [PHP-DEV] DOMXPath / XSLTProcessor function callbacks

2023-10-14 Thread Niels Dossche
Hi Tim On 10/14/23 14:42, Tim Düsterhus wrote: > Hi > > On 10/14/23 13:54, Niels Dossche wrote: >>> (a) Call ucfirst(), but not strtoupper() >>> (b) Call both >> >> You can call both, it's additive. >> > > Okay, for your suggestion (1) th

Re: [PHP-DEV] DOMXPath / XSLTProcessor function callbacks

2023-10-15 Thread Niels Dossche
Hi Marc On 10/15/23 12:53, Marc wrote: > Hi, > > On 14.10.23 13:54, Niels Dossche wrote: >> Hi Tim >> >> On 10/14/23 12:30, Tim Düsterhus wrote: >>> Hi >>> >>> On 10/13/23 00:39, Niels Dossche wrote: >>>> Please let me know you

[PHP-DEV] Re: [RFC] [VOTE] DOM HTML5 parsing and serialization

2023-10-16 Thread Niels Dossche
On 02/10/2023 20:19, Niels Dossche wrote: > Hi internals > > I just opened the vote on my RFC "DOM HTML5 parsing and serialization". > RFC link: https://wiki.php.net/rfc/domdocument_html5_parser > Discussion (externals.io): https://externals.io/message/120972 > >

[PHP-DEV] Re: DOMXPath / XSLTProcessor function callbacks

2023-10-16 Thread Niels Dossche
Functions as is, and maybe discourage it in favor of > the method above. What if both are called? I think it would be most clear if > the registerFunctionsNS method throws InvalidArgumentException when > http://php.net/xsl or http://php.net/xpath is passed as namespace. > > Cheers, &

Re: [PHP-DEV] [RFC] [Discussion] Add multibyte trim function (mb_trim, mb_ltrim and mb_rtrim)

2023-10-19 Thread Niels Dossche
Hi Yuya On 19/10/2023 13:57, youkidearitai wrote: > Hi, internals. > > 8ctopus san can't send email, so I'm writing new RFC for multibyte > trim function. > https://wiki.php.net/rfc/mb_trim > https://github.com/php/php-src/pull/12459 > > I would like to under discussion. Thanks for this. I hav

[PHP-DEV] Re: [RFC] [VOTE] XML_OPTION_PARSE_HUGE

2023-10-21 Thread Niels Dossche
Hi internals On 10/7/23 21:10, Niels Dossche wrote: > Hi internals > > I'm starting the vote on my RFC to add the XML_OPTION_PARSE_HUGE option to > ext/xml. > Discussion: https://externals.io/message/121121 > RFC link: https://wiki.php.net/rfc/xml_option_parse_huge >

[PHP-DEV] [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-11-07 Thread Niels Dossche
Hi internals I'm opening the discussion for my RFC "Improve callbacks in ext/dom and ext/xsl". RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-11-11 Thread Niels Dossche
Hi Tim On 11/11/23 16:32, Tim Düsterhus wrote: > Hi > > On 11/7/23 20:32, Niels Dossche wrote: >> I'm opening the discussion for my RFC "Improve callbacks in ext/dom and >> ext/xsl". >> RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl

[PHP-DEV] Re: DOMXPath / XSLTProcessor function callbacks

2023-11-19 Thread Niels Dossche
Hi Frederik On 16/11/2023 20:34, Frederik Bosch wrote: > Hi Niels, > > On 16-10-2023 23:19, Niels Dossche wrote: >> Sorry for the resend... I accidentally replied to you only without including >> the list the first time. >> >> On 15/10/2023 21:37, Fre

[PHP-DEV] Re: [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-12-04 Thread Niels Dossche
Hi internals On 07/11/2023 20:32, Niels Dossche wrote: > Hi internals > > I'm opening the discussion for my RFC "Improve callbacks in ext/dom and > ext/xsl". > RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl > > Kind regards > Niels I ha

[PHP-DEV] Filesystem path APIs

2023-12-06 Thread Niels Dossche
Hi internals I'd like to start a pre-RFC discussion about filesystem path APIs in PHP. The reason I bring this up is because of this recent feature request: https://github.com/php/php-src/issues/11258 The feature request is about the following: We already have some functions to work with paths

[PHP-DEV] Re: [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-12-06 Thread Niels Dossche
Hi again On 04/12/2023 23:11, Niels Dossche wrote: > Hi internals > > On 07/11/2023 20:32, Niels Dossche wrote: >> Hi internals >> >> I'm opening the discussion for my RFC "Improve callbacks in ext/dom and >> ext/xsl". >> RFC link:

Re: [PHP-DEV] PHP test coverage

2023-12-08 Thread Niels Dossche
Hi On 08/12/2023 17:04, Vinicius Dias wrote: >> The code coverage report can be found at >> https://app.codecov.io/github/php/php-src > > Ah, perfect. Thank you for sharing. I will take a closer look after > work, but something seems weird to me. Here[1] you see that > ctype_alpha seems to be un

Re: [PHP-DEV] Filesystem path APIs

2023-12-08 Thread Niels Dossche
Hi David On 08/12/2023 10:08, David CARLIER wrote: > I think these would be great additions to PHP as working with paths and > files is a core part of any programming language. > > > Seems like it, is there an argument to be made to, let's say, in the > performance side ?  A native implem

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2023-12-09 Thread Niels Dossche
Hi Max On 12/9/23 13:30, Max Semenik wrote: > Hi, I'd like to propose a new attribute, #[NotSerializable]. This > functionality is already available for internal classes - userspace should > benefit from it, too. > > The RFC: https://wiki.php.net/rfc/not_serializable > Proposed implementation: ht

Re: [PHP-DEV] Filesystem path APIs

2023-12-09 Thread Niels Dossche
On 12/9/23 10:40, David CARLIER wrote: > On Fri, 8 Dec 2023 at 16:10, Niels Dossche wrote: > >> Hi David >> >> On 08/12/2023 10:08, David CARLIER wrote: >>> I think these would be great additions to PHP as working with paths >> and files is

Re: [PHP-DEV] [RFC][Discussion] NotSerializable attribute

2023-12-09 Thread Niels Dossche
On 12/9/23 17:28, Larry Garfield wrote: > On Sat, Dec 9, 2023, at 10:17 AM, Niels Dossche wrote: >> Hi Max >> >> On 12/9/23 13:30, Max Semenik wrote: >>> Hi, I'd like to propose a new attribute, #[NotSerializable]. This >>> functionality is already avail

Re: [PHP-DEV] Are warnings guaranteed?

2023-12-14 Thread Niels Dossche
Hi On 14/12/2023 11:39, petrov.boris.v.mail.ru via internals wrote: > Is relying on warnings being converted to exceptions by error handler is > equivalent to checking return value with regards to the set of error > conditions covered? If this guarantee is already there, please point to me to

[PHP-DEV] Re: [RFC] [Discussion] Improve callbacks in ext/dom and ext/xsl

2023-12-19 Thread Niels Dossche
Hi internals On 07/11/2023 20:32, Niels Dossche wrote: > Hi internals > > I'm opening the discussion for my RFC "Improve callbacks in ext/dom and > ext/xsl". > RFC link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl > > Kind regards > Niels

[PHP-DEV] [RFC] [VOTE] Improve callbacks in ext/dom and ext/xsl

2023-12-21 Thread Niels Dossche
Hi internals I'm opening the vote for my RFC "Improve callbacks in ext/dom and ext/xsl". Link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl The voting will run for three weeks, i.e. until 2024-01-11 18:00 GMT+2. Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing Li

[PHP-DEV] Partitioned cookies

2023-12-24 Thread Niels Dossche
Hi internals I opened a PR [1] to implement Partitioned cookie support, as requested on the bugtracker [2], into the setcookie() PHP function. This is done by adding an option to the $options array, not via an additional argument to the function. The amount of code to support this is tiny. Thi

Re: [PHP-DEV] Partitioned cookies

2023-12-24 Thread Niels Dossche
Hi On 24/12/2023 17:04, Derick Rethans wrote: > On 24 December 2023 12:46:40 CET, Niels Dossche > wrote: >> Hi internals >> >> I opened a PR [1] to implement Partitioned cookie support, as requested on >> the bugtracker [2], into the setcookie() PHP function.

[PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Niels Dossche
Hi internals The DOM extension in PHP is used to parse, query and manipulate XML/HTML documents. The DOM extension is based on the DOM specification. Originally this was the DOM Core Level 3 specification, but nowadays, that specification has evolved into the current "Living Specification" maint

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-26 Thread Niels Dossche
Hi Tim On 26/12/2023 22:58, Tim Düsterhus wrote: > Hi > > On 12/26/23 22:45, Niels Dossche wrote: >> In my opinion, having them become proper classes instead of aliases has my >> preference: either we fix everything in one go now while we have the >> opportunity, or

Re: [PHP-DEV] security email address broken?

2023-12-28 Thread Niels Dossche
Hi On 28/12/2023 19:36, Robert Landers wrote: > Hello internals, > > I sent an email to secur...@php.net (which I got from this page: > https://wiki.php.net/security#:~:text=Please%20report%20it,security/advisories/new) > and got back: > > I'm sorry to have to inform you that your message could

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread Niels Dossche
Hi Gina On 29/12/2023 15:40, G. P. B. wrote: > Thank you for the work! > > I agree that making them proper classes instead of aliases is the better > proposition here. > I'm not fully informed about the DOM spec, and I don't know if the current > class/interface hierarchy is in the best shape,

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-29 Thread Niels Dossche
Hi Larry On 29/12/2023 17:58, Larry Garfield wrote: > > I am also on team "yes, let's just do it right." If that means the new > classes are only 99% drop ins for the old ones, I'm OK with that. People can > switch over when they're ready and do all the clean up at once. > They are indeed

Re: [PHP-DEV] Pre-RFC: Fixing spec bugs in the DOM extension

2023-12-30 Thread Niels Dossche
Hi Robert On 30/12/2023 10:25, Robert Landers wrote: > Hi Niels, > >> They are indeed going to be very similar, but at least having better return >> types would be good to give one particular example. >> e.g. we currently have a lot of methods that can return an object or false. >> The current

[PHP-DEV] Re: [RFC] [VOTE] Improve callbacks in ext/dom and ext/xsl

2024-01-11 Thread Niels Dossche
On 21/12/2023 17:52, Niels Dossche wrote: > Hi internals > > I'm opening the vote for my RFC "Improve callbacks in ext/dom and ext/xsl". > Link: https://wiki.php.net/rfc/improve_callbacks_dom_and_xsl > > The voting will run for three weeks, i.e. until 2024-01-

[PHP-DEV] [RFC] [Discussion] Opt-in DOM spec-compliance

2024-01-17 Thread Niels Dossche
Hi internals I'm starting discussion of my RFC "Opt-in DOM spec-compliance". RFC link: https://wiki.php.net/rfc/opt_in_dom_spec_compliance Pre-RFC pitch: https://externals.io/message/122048 Kind regards Niels -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https:

Re: [PHP-DEV] [RFC] [Discussion] Opt-in DOM spec-compliance

2024-01-18 Thread Niels Dossche
Hi Gina On 18/01/2024 14:05, Gina P. Banyard wrote: > Hello Niels, > > Thank you for the RFC and the thorough overview of the current state. > > I think converting the new aliases to proper classes which have the correct > spec behaviour is indeed the way to proceed. > > I do have some questio

Re: [PHP-DEV] `PDO::FETCH_CONSTRUCTOR` fetch mode proposal

2024-01-18 Thread Niels Dossche
Hi Frederik On 18/01/2024 21:21, Frederik van der Els wrote: > Hi internals, > > First off, please excuse me if I’ve done something wrong related to the usage > of the mailing list. This all is completely new to me. > > I hereby want to propose a new fetch mode for PDO. I’ve detailed the > mot

[PHP-DEV] Re: [RFC] [Discussion] Opt-in DOM spec-compliance

2024-02-05 Thread Niels Dossche
Hi internals On 17/01/2024 21:22, Niels Dossche wrote: > Hi internals > > I'm starting discussion of my RFC "Opt-in DOM spec-compliance". > > RFC link: https://wiki.php.net/rfc/opt_in_dom_spec_compliance > Pre-RFC pitch: https://externals.io/message/1220

[PHP-DEV] Re: [RFC] [Discussion] Opt-in DOM spec-compliance

2024-02-10 Thread Niels Dossche
Hi internals On 1/17/24 21:22, Niels Dossche wrote: > Hi internals > > I'm starting discussion of my RFC "Opt-in DOM spec-compliance". > > RFC link: https://wiki.php.net/rfc/opt_in_dom_spec_compliance > Pre-RFC pitch: https://externals.io/message/122048 >

[PHP-DEV] [RFC] [Vote] Opt-in DOM spec-compliance

2024-02-13 Thread Niels Dossche
Hi internals I'm starting the vote on my RFC "Opt-in DOM spec-compliance". Voting will run until the 27th of February 21:00 GMT+1. RFC link: https://wiki.php.net/rfc/opt_in_dom_spec_compliance Discussion: https://externals.io/message/122169 Pre-RFC pitch: https://externals.io/message/122048 Kind

[PHP-DEV] New ext-dom features

2024-02-17 Thread Niels Dossche
Hi internals After (and if) my current in-voting RFC about spec-compliance DOM passes, some features become more easily possible to implement due to the necessary building blocks becoming in place in the extension code. I would like to start implementing those. Therefore, I'd like to gauge the

Re: [PHP-DEV] New ext-dom features

2024-02-19 Thread Niels Dossche
Hi Larry On 18/02/2024 18:25, Larry Garfield wrote: > On Sat, Feb 17, 2024, at 5:11 PM, Niels Dossche wrote: >> Hi internals >> >> After (and if) my current in-voting RFC about spec-compliance DOM >> passes, some features become more easily possible to implement due to

[PHP-DEV] Re: [RFC] [Vote] Opt-in DOM spec-compliance

2024-02-27 Thread Niels Dossche
Hi internals The RFC was accepted with 14 yes and 0 no votes. Thanks to everyone who participated! Kind regards Niels On 13/02/2024 20:49, Niels Dossche wrote: > Hi internals > > I'm starting the vote on my RFC "Opt-in DOM spec-compliance". > Voting will run until

Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function

2024-03-04 Thread Niels Dossche
Hi Yuya This sounds useful. I do have a question about the function signature: function grapheme_str_split(string $string, int $length = 1): array {} This always returns an array. However, looking at your PR it seems you return NULL on failure, but the return type in the signature isn't nullabl

Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function

2024-03-05 Thread Niels Dossche
. Either it should return false to match the other functions, or throw something and not return a value. On 05/03/2024 18:40, Larry Garfield wrote: > On Tue, Mar 5, 2024, at 7:25 AM, youkidearitai wrote: >> 2024年3月5日(火) 5:52 Niels Dossche : >>> >>> Hi Yuya >>> >>

Re: [PHP-DEV] [Discussion] grapheme cluster for str_split function

2024-03-06 Thread Niels Dossche
On 06/03/2024 01:37, youkidearitai wrote: > 2024年3月6日(水) 9:22 youkidearitai : >> >> Hi, Larry >> Hi, Niels >> >> 2024年3月6日(水) 6:47 Niels Dossche : >>> >>> Hi Larry >>> Hi Yuya >>> >>> So first of all, I meant the erro

  1   2   3   >