Re: [PHP-DEV] [RFC] Allow non-variable arguments to empty() and isset()

2012-05-03 Thread Herman Radtke
That is the only use-case the RFC gives for making this change. From the RFC: "For example if func() is expected to return an array, it feels more natural to verify it's emptiness using empty() instead of !." -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Adding a simple API for secure password hashing?

2012-06-15 Thread Herman Radtke
This userland library already solves all the issues you outlined with bcrypt: http://www.openwall.com/phpass/ The API is very easy to use, has been around for a while and has a number of detailed articles that explain how to use it. -- Herman Radtke hermanrad...@gmail.com | http

Re: [PHP-DEV] re: removing an item from an array

2012-08-20 Thread Herman Radtke
remove something from an array. The "filter" function/method is common in functional languages (and functional frameworks like Underscore). These are things developers just need to learn as part of development. Really, this is entire thread should be on stack overflow, not internals. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com

[PHP-DEV] CVS Account Request: hradtke

2008-01-13 Thread Herman Radtke
Maintaining the documentation. I emailed the phpdoc mailing list and Hannes Magnusson suggested I request and account. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Bug 43313

2009-03-31 Thread Herman Radtke
Hi all, When someone gets a chance could they please review my comment on http://bugs.php.net/bug.php?id=43313 ? I have a patch and test cases, but have a question before I submit them. Thanks, Herman Radtke -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http

Re: [PHP-DEV] Moving forward: PHP 5.5

2012-09-17 Thread Herman Radtke
> David, I think you're experienced enough to fill this role alone. One benefit to having two RM's is that Julien is learning from DSP. If there is a strong reason to have only one RM, then maybe we should consider a RM/vice-RM kind of pairing. -- Herman Radtke hermanrad...@gma

Re: [PHP-DEV] DateTime improvement

2012-12-10 Thread Herman Radtke
t. > But I don't think it'd be a win to do such thing now. > Another option is to make an ImmutableDateTime class. The DateTime class could actually be changed to inherit the ImmutableDateTime class. The only extensions on the DateTime class would be the mutable methods. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] array_column() function

2013-01-14 Thread Herman Radtke
On Sat, Jan 12, 2013 at 12:04 AM, Levi Morrison wrote: > The real problem here (in my opinion) is that `array_filter` does not > pass the key information to the callback. If you could do that, you > could select columns that way. I opened a PR with this feature, but it was rejected. -

Re: [PHP-DEV] [VOTE] array_column() function

2013-01-14 Thread Herman Radtke
rd/Calculations/pluck Python example: http://stackoverflow.com/questions/9816545/pluck-in-python -- Herman Radtke @hermanradtke | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Travis-CI support for the latest PHP Release Candidate

2013-02-10 Thread Herman Radtke
https://github.com/travis-ci/travis-ci/issues/920 There was a recent thread about testing against PHP 5.5 using Travis-CI. I thought this might make it even easier to get feedback on which projects are having problems with the Release Candidates. -- Herman Radtke @hermanradtke | http

Re: [PHP-DEV] Dropping requirement for `function` keyword for methods in classes/interfaces/etc

2013-02-19 Thread Herman Radtke
> Protip: use an IDE. Linux is my IDE. -- Herman Radtke @hermanradtke | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [VOTE] Integrating Zend Optimizer+ into the PHP distribution

2013-03-04 Thread Herman Radtke
> production environment, your development environment will have an opcode > cache as well. And possibly xdebug. I run xdebug on 1% of my production servers to a nice stack trace for errors that reveal themselves in production. Similar to how I run xhprof on 1% of all web requests. -- Herman Radt

[PHP-DEV] [PATCH] Bug #47481

2009-07-13 Thread Herman Radtke
This bug only exists in PHP 5.x. The unicode support in PHP 6 takes care of it already, but I added a PHP 6 version of the test case as well. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com diff --git a/ext/standard/strnatcmp.c b/ext/standard/strnatcmp.c index 2459e46..366c124

[PHP-DEV] [PATCH] Bug #45599 - php_strip_tags() treats backslash character as an escape character inside HTML tags

2009-07-16 Thread Herman Radtke
Patch files for php 5.x and 6 with a test. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com Index: ext/standard/string.c === --- ext/standard/string.c (revision 284189) +++ ext/standard/string.c (working

[PHP-DEV] differences in the way spl_autoload() works on windows and *nix with namespaces

2009-10-24 Thread Herman Radtke
+ ret = php_stream_open_for_zend_ex(class_file, &file_handle, ENFORCE_SAFE_MODE|USE_PATH|STREAM_OPEN_FOR_INCLUDE TSRMLS_CC); if (ret == SUCCESS) { -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Unserialize is broken

2010-02-28 Thread Herman Radtke
ng to kill your > code anymore. This seems like a corner case and one that a conversion script should handle. Considering that serialize and unserialize are called for every single web-request, degrading the performance of unserialize is not something that should be done lightly. -- Herman Radt

Re: [PHP-DEV] Re: moving forward

2010-03-14 Thread Herman Radtke
tween git branches means I have to recompile PHP every time (or set up some system of symlinks). -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: moving forward

2010-03-14 Thread Herman Radtke
maybe I am just doing it all wrong? -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] Raise warning first on "Maximum execution time exceeded"

2010-03-22 Thread Herman Radtke
like "95%". When a script reaches that memory threshold it can trigger a warning so you can log it. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] Raise warning first on "Maximum execution time exceeded"

2010-03-22 Thread Herman Radtke
> This patch handles timeout, not memory exhaustion. Apologies. My train of thought inexplicably switched over to memory. I meant to assert that your custom error handler could extend the length of the script to n extra seconds. This violates that idea of the timeout. -- Herman Rad

Re: [PHP-DEV] More formal feature request cycle

2010-11-05 Thread Herman Radtke
> Stas - quick question - what is a PEP? Python Enhancement Proposal http://www.python.org/dev/peps/ There is even a PEP for PEP. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: h

Re: [PHP-DEV] git anyone?

2010-11-25 Thread Herman Radtke
S is less work than managing cvs/svn. Sure, individuals and entire development teams can shoot themselves in the foot if they use DVCS incorrectly. But, I would rather use a sharp tool (like git) than a dull one (like svn). -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] git anyone?

2010-11-25 Thread Herman Radtke
job. My mistake. The github mirror really isn't the point thought. The point is that anyone can use git-svn to make a git repo of PHP source and isolate themselves. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] git anyone?

2010-11-27 Thread Herman Radtke
well. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch: Marking DateTime Instances Immutable

2010-12-05 Thread Herman Radtke
lass and add this functionality than to change the inner workings of the existing class. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [patch] Session RSHUTDOWN, shutdown_destructors() issues

2011-03-16 Thread Herman Radtke
> Could you please also open a ticket in the bug tracker? > thanks He did: http://bugs.php.net/bug.php?id=54157 Now he is bringing the discussion here per Johannes. I too have experienced Tim's problem and am interested in getting a discussion going on what can be done to solve it.

[PHP-DEV] Why does zend_call_function return SUCCESS if an exception is thrown

2011-04-09 Thread Herman Radtke
after zend_call_function returns a SUCCESS? For reference I am looking in Zend/zend_execute_API.c: if (EG(exception)) { zend_throw_exception_internal(NULL TSRMLS_CC); } return SUCCESS; -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals

Re: [PHP-DEV] Why does zend_call_function return SUCCESS if an exception is thrown

2011-04-09 Thread Herman Radtke
ven begin. > > You can check for exceptions via EG(exception). Perfect, thank you. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Fwd: What's up with Quercus?

2011-05-29 Thread Herman Radtke
additions to a complex system need to really be thought out. Annotations are a major addition and PHP is already a very complex system. [1] http://www.amazon.com/Coders-Work-Reflections-Craft-Programming/dp/1430219483 - page 192 -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -

Re: [PHP-DEV] Re: RFC: Short syntax for Arrays (redux)

2011-06-01 Thread Herman Radtke
b78aa4daa.html Using : (JSON) separator: http://paste.roguecoders.com/p/b117894e85b6f980b8390bc2828ca227.html -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Choosing a distributed version control system for PHP (or not). Call for Participation.

2011-08-12 Thread Herman Radtke
p all sorts of problems and issues, but that is the point. Moving svn to a dvcs is less of a technical change and more of a paradigm shift in the fundamental way a user interacts with version control. As a long time dvcs proponent and user, I support the move to distributed version control. I jus

Re: [PHP-DEV] [RFC] Function autoloading through spl_autoload*

2011-08-15 Thread Herman Radtke
ctions within a class. The main difference is that using the namespace would allow functions to be called without a prefix. -- Herman Radtke hermanrad...@gmail.com | http://hermanradtke.com -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php